procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix bug #18874 with rgrep not obeying grep-scroll-output.

Browse source 
lisp/progmodes/compile.el (compilation-start): If
 compilation-scroll-output is non-nil, don't force window-start of
 the compilation buffer to be at beginning of buffer.
This commit is contained in:
Eli Zaretskii 2014-10-29 17:17:18 +02:00
parent 205be0810a
commit 091d3228b7
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lisp/ChangeLog
View file

@ -1,3 +1,9 @@
2014-10-29 Eli Zaretskii <eliz@gnu.org>
* progmodes/compile.el (compilation-start): If
compilation-scroll-output is non-nil, don't force window-start of
the compilation buffer to be at beginning of buffer. (Bug#18874)
2014-10-23 Tassilo Horn <tsdh@gnu.org>
* doc-view.el (doc-view-open-text): View the document's plain text

11
lisp/progmodes/compile.el
View file

@ -1651,7 +1651,16 @@ Returns the compilation buffer created."
(list command mode name-function highlight-regexp))
(set (make-local-variable 'revert-buffer-function)
'compilation-revert-buffer)
(and outwin (set-window-start outwin (point-min)))
(and outwin
;; Forcing the window-start overrides the usual redisplay
;; feature of bringing point into view, so setting the
;; window-start to top of the buffer risks losing the
;; effect of moving point to EOB below, per
;; compilation-scroll-output, if the command is long
;; enough to push point outside of the window. This
;; could happen, e.g., in `rgrep'.
(not compilation-scroll-output)
(set-window-start outwin (point-min)))
;; Position point as the user will see it.
(let ((desired-visible-point