procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Switch the order of ERC's '/whois' arguments sent to the server

Browse source 
* lisp/erc/erc.el (erc-cmd-WHOIS): Switch the order of 'server' and
'user' arguments sent to the server.  Per RFC 1459 and RFC 2812, the
optional 'server' argument command comes before the 'user' argument,
not after.  While at it, update the doc string to explain why one may
want to specify the 'server' argument.
* etc/NEWS: Announce the change.
This commit is contained in:
Amin Bandali 2021-09-29 00:44:43 -04:00
parent fcfcb35791
commit 081eb52e4d
No known key found for this signature in database
GPG key ID: 8B44A0CDC7B956F2
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
etc/NEWS
View file

@ -2853,6 +2853,11 @@ The new '/opme' convenience command asks ChanServ to set the operator
status for the current nick in the current channel, and '/deopme'
unsets it.
---
*** Fix the order of '/whois' arguments sent to the server.
Per RFC 1459 and RFC 2812, when given, the optional 'server' argument
for the WHOIS command must come before the 'user' argument, not after.
** xwidget-webkit mode
---

9
lisp/erc/erc.el
View file

@ -3301,10 +3301,13 @@ a script after exceeding the flood threshold."
(defun erc-cmd-WHOIS (user &optional server)
"Display whois information for USER.
If SERVER is non-nil, use that, rather than the current server."
;; FIXME: is the above docstring correct? -- Lawrence 2004-01-08
If SERVER is non-nil, use that, rather than the current server.
This is useful for getting the time USER has been idle for, if
USER is on a different server of the network than the current
user, since only the server the user is connected to knows this
information."
(let ((send (if server
(format "WHOIS %s %s" user server)
(format "WHOIS %s %s" server user)
(format "WHOIS %s" user))))
(erc-log (format "cmd: %s" send))
(erc-server-send send)