procyberian/emacs
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* lisp/emacs-lisp/timer.el (timer-event-handler): Protect against timers

Browse source 
that change current buffer.
This commit is contained in:
Stefan Monnier 2010-08-02 11:00:46 +02:00
parent 9a747ba650
commit 0798a8d85c
2 changed files with 24 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lisp/emacs-lisp/timer.el
View file

@ -321,7 +321,11 @@ This function is called, by name, directly by the C code."
;; We do this after rescheduling so that the handler function
;; can cancel its own timer successfully with cancel-timer.
(condition-case nil
(apply (timer--function timer) (timer--args timer))
;; Timer functions should not change the current buffer.
;; If they do, all kinds of nasty surprises can happen,
;; and it can be hellish to track down their source.
(save-current-buffer
(apply (timer--function timer) (timer--args timer)))
(error nil))
(if retrigger
(setf (timer--triggered timer) nil)))