diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 04cb6e73e1c..3e10f1f16fe 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,5 +1,7 @@ 2014-04-23 Stefan Monnier + * simple.el (region-active-p): Check there's a mark (bug#17324). + * simple.el (completion-list-mode-map): Use choose-completion for the mouse binding as well (bug#17302). (completion-list-mode, completion-setup-function): Adjust docstring and diff --git a/lisp/simple.el b/lisp/simple.el index 61b7279568f..36d2d0b3a15 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -4495,7 +4495,12 @@ Some commands act specially on the region when Transient Mark mode is enabled. Usually, such commands should use `use-region-p' instead of this function, because `use-region-p' also checks the value of `use-empty-active-region'." - (and transient-mark-mode mark-active)) + (and transient-mark-mode mark-active + ;; FIXME: Somehow we sometimes end up with mark-active non-nil but + ;; without the mark being set (e.g. bug#17324). We really should fix + ;; that problem, but in the mean time, let's make sure we don't say the + ;; region is active when there's no mark. + (mark))) (defvar redisplay-unhighlight-region-function