procyberian/emacs
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix two Flymake bugs

Browse source 
* lisp/progmodes/flymake.el (define-fringe-bitmap): Protect
against --without-x.
(flymake--mode-line-format): Ensure mode-line's mouse-4 and mouse-5 work
in their own windows.
This commit is contained in:
João Távora 2017-10-10 12:47:46 +01:00
parent 3dfa2ca4dc
commit 042b3cfbd2
1 changed files with 25 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

47
lisp/progmodes/flymake.el
View file

@ -142,24 +142,25 @@ Specifically, start it when the buffer is actually displayed."
"If non-nil, moving to errors wraps around buffer boundaries." "If non-nil, moving to errors wraps around buffer boundaries."
:type 'boolean) :type 'boolean)
(define-fringe-bitmap 'flymake-double-exclamation-mark (when (fboundp 'define-fringe-bitmap)
(vector #b00000000 (define-fringe-bitmap 'flymake-double-exclamation-mark
#b00000000 (vector #b00000000
#b00000000 #b00000000
#b00000000 #b00000000
#b01100110 #b00000000
#b01100110 #b01100110
#b01100110 #b01100110
#b01100110 #b01100110
#b01100110 #b01100110
#b01100110 #b01100110
#b01100110 #b01100110
#b01100110 #b01100110
#b00000000 #b01100110
#b01100110 #b00000000
#b00000000 #b01100110
#b00000000 #b00000000
#b00000000)) #b00000000
#b00000000)))
(defvar-local flymake-timer nil (defvar-local flymake-timer nil
"Timer for starting syntax check.") "Timer for starting syntax check.")
@ -1040,13 +1041,15 @@ applied."
,(let ((map (make-sparse-keymap)) ,(let ((map (make-sparse-keymap))
(type type)) (type type))
(define-key map [mode-line mouse-4] (define-key map [mode-line mouse-4]
(lambda (_event) (lambda (event)
(interactive "e") (interactive "e")
(flymake-goto-prev-error 1 (list type) t))) (with-selected-window (posn-window (event-start event))
(flymake-goto-prev-error 1 (list type) t))))
(define-key map [mode-line mouse-5] (define-key map [mode-line mouse-5]
(lambda (_event) (lambda (event)
(interactive "e") (interactive "e")
(flymake-goto-next-error 1 (list type) t))) (with-selected-window (posn-window (event-start event))
(flymake-goto-next-error 1 (list type) t))))
map) map)
help-echo help-echo
,(concat (format "%s diagnostics of type %s\n" ,(concat (format "%s diagnostics of type %s\n"