procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

(rng-do-some-validation): Fix dangerous use of with-silent-modifications

Browse source 
* lisp/nxml/rng-valid.el (rng-do-some-validation): Don't let-bind
`inhibit-modification-hooks` around code which can wait.
(rng-cache-state): Bind it here instead.
This commit is contained in:
Stefan Monnier 2024-06-10 10:43:14 -04:00
parent 8a55f4d0b0
commit 018a6d2ee9
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lisp/nxml/rng-valid.el
View file

@ -444,8 +444,7 @@ The schema is set like `rng-auto-set-schema'."
(condition-case-unless-debug err
(and (rng-validate-prepare)
(let ((rng-dt-namespace-context-getter '(nxml-ns-get-context)))
(with-silent-modifications
(rng-do-some-validation-1 continue-p-function))))
(rng-do-some-validation-1 continue-p-function)))
;; errors signaled from a function run by an idle timer
;; are ignored; if we don't catch them, validation
;; will get mysteriously stuck at a single place
@ -585,10 +584,8 @@ Return t if there is work to do, nil otherwise."
(defun rng-cache-state (pos)
"Save the current state in a text property on the character at pos."
(put-text-property pos
(1+ pos)
'rng-state
(rng-get-state)))
(with-silent-modifications
(put-text-property pos (1+ pos) 'rng-state (rng-get-state))))
(defun rng-state-matches-current (state)
(and state