procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
emacs/lisp/progmodes/flymake-proc.el

1229 lines
53 KiB
EmacsLisp
Raw Normal View History

Flymake's flymake-proc.el backend slightly easier to debug Misc cleanup in flymake-proc.el Improve description of what this file contains. Better name for the backend function. Fix the case where it is run interactively. Keep the output buffer alive iff the external process panics. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Rename from flymake-proc-start-syntax-check. Allow running interactively. (flymake-start-syntax-check): Obsolete alias for flymake-proc-legacy-flymake. (flymake-proc-start-syntax-check): Delete. (flymake-diagnostic-functions): Include flymake-proc-legacy-flymake (flymake-proc--process-sentinel): Keep output buffer alive. Clarify with comments. (flymake-proc--diagnostics-for-pattern) (flymake-proc--process-sentinel) (flymake-proc--safe-delete-directory) (flymake-proc--start-syntax-check-process): Use condition-case-unless-debug.
2017-09-19 14:56:59 +01:00
;;; flymake-proc.el --- Flymake backend for external tools -*- lexical-binding: t; -*-
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Update copyright year to 2021 Run "TZ=UTC0 admin/update-copyright".
2021-01-01 01:13:56 -08:00
;; Copyright (C) 2003-2021 Free Software Foundation, Inc.
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Update author/maintainer info Update email addresses and fix spellings of some author and maintainer names.
2019-05-26 00:58:28 -07:00
;; Author: Pavel Kobyakov <pk_at_work@yahoo.com>
Update version information for Flymake package and manual * doc/misc/flymake.texi: Update date and version. Make myself the first author. * lisp/progmodes/flymake.el: Update Maintainer and Version fields. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Update Maintainer and Version fields.
2018-06-05 14:20:42 +01:00
;; Maintainer: João Távora <joaotavora@gmail.com>
;; Version: 1.0
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;; Keywords: c languages tools
;; This file is part of GNU Emacs.
;; GNU Emacs is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; GNU Emacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
; Prefer https: to http: in GNU URLs
2017-10-14 19:18:37 -07:00
;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;;; Commentary:
;;
;; Flymake is a minor Emacs mode performing on-the-fly syntax checks.
;;
Flymake's flymake-proc.el backend slightly easier to debug Misc cleanup in flymake-proc.el Improve description of what this file contains. Better name for the backend function. Fix the case where it is run interactively. Keep the output buffer alive iff the external process panics. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Rename from flymake-proc-start-syntax-check. Allow running interactively. (flymake-start-syntax-check): Obsolete alias for flymake-proc-legacy-flymake. (flymake-proc-start-syntax-check): Delete. (flymake-diagnostic-functions): Include flymake-proc-legacy-flymake (flymake-proc--process-sentinel): Keep output buffer alive. Clarify with comments. (flymake-proc--diagnostics-for-pattern) (flymake-proc--process-sentinel) (flymake-proc--safe-delete-directory) (flymake-proc--start-syntax-check-process): Use condition-case-unless-debug.
2017-09-19 14:56:59 +01:00
;; This file contains a significant part of the original flymake's
;; implementation, a buffer-checking mechanism that parses the output
;; of an external syntax check tool with regular expressions.
;;
;; That work has been adapted into a flymake "backend" function,
;; `flymake-proc-legacy-flymake' suitable for adding to the
;; `flymake-diagnostic-functions' variable.
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;;
;;; Bugs/todo:
;; - Only uses "Makefile", not "makefile" or "GNUmakefile"
; Prefer https to http in many URLs These were all tested with https and confirmed working.
2020-10-01 15:24:21 +02:00
;; (from https://bugs.debian.org/337339).
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;;; Code:
User can specify files never subject to flymake. * lisp/progmodes/flymake-proc.el (flymake-proc-ignored-file-name-regexps): Add user customization option. (flymake-proc--get-file-name-mode-and-masks): Check it before `flymake-proc-allowed-file-name-masks'.
2017-11-01 09:36:41 -04:00
(require 'cl-lib)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(require 'flymake)
Fix some flymake aliases * lisp/progmodes/flymake-proc.el (flymake-xml-program) (flymake-compilation-prevents-syntax-check, flymake-master-file-dirs) (flymake-master-file-count-limit, flymake-allowed-file-name-masks): * lisp/progmodes/flymake.el (flymake-start-syntax-check-on-find-file): Define aliases to user options before the options are defined.
2017-12-20 14:31:03 -05:00
(define-obsolete-variable-alias 'flymake-compilation-prevents-syntax-check
'flymake-proc-compilation-prevents-syntax-check "26.1")
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defcustom flymake-proc-compilation-prevents-syntax-check t
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"If non-nil, don't start syntax check if compilation is running."
:group 'flymake
:type 'boolean)
Fix some flymake aliases * lisp/progmodes/flymake-proc.el (flymake-xml-program) (flymake-compilation-prevents-syntax-check, flymake-master-file-dirs) (flymake-master-file-count-limit, flymake-allowed-file-name-masks): * lisp/progmodes/flymake.el (flymake-start-syntax-check-on-find-file): Define aliases to user options before the options are defined.
2017-12-20 14:31:03 -05:00
(define-obsolete-variable-alias 'flymake-xml-program
'flymake-proc-xml-program "26.1")
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defcustom flymake-proc-xml-program
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(if (executable-find "xmlstarlet") "xmlstarlet" "xml")
"Program to use for XML validation."
:type 'file
:group 'flymake
:version "24.4")
Fix some flymake aliases * lisp/progmodes/flymake-proc.el (flymake-xml-program) (flymake-compilation-prevents-syntax-check, flymake-master-file-dirs) (flymake-master-file-count-limit, flymake-allowed-file-name-masks): * lisp/progmodes/flymake.el (flymake-start-syntax-check-on-find-file): Define aliases to user options before the options are defined.
2017-12-20 14:31:03 -05:00
(define-obsolete-variable-alias 'flymake-master-file-dirs
'flymake-proc-master-file-dirs "26.1")
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defcustom flymake-proc-master-file-dirs '("." "./src" "./UnitTest")
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Dirs where to look for master files."
:group 'flymake
:type '(repeat (string)))
Fix some flymake aliases * lisp/progmodes/flymake-proc.el (flymake-xml-program) (flymake-compilation-prevents-syntax-check, flymake-master-file-dirs) (flymake-master-file-count-limit, flymake-allowed-file-name-masks): * lisp/progmodes/flymake.el (flymake-start-syntax-check-on-find-file): Define aliases to user options before the options are defined.
2017-12-20 14:31:03 -05:00
(define-obsolete-variable-alias 'flymake-master-file-count-limit
'flymake-proc-master-file-count-limit "26.1")
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defcustom flymake-proc-master-file-count-limit 32
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Max number of master files to check."
:group 'flymake
:type 'integer)
User can specify files never subject to flymake. * lisp/progmodes/flymake-proc.el (flymake-proc-ignored-file-name-regexps): Add user customization option. (flymake-proc--get-file-name-mode-and-masks): Check it before `flymake-proc-allowed-file-name-masks'.
2017-11-01 09:36:41 -04:00
(defcustom flymake-proc-ignored-file-name-regexps '()
"Files syntax checking is forbidden for.
Overrides `flymake-proc-allowed-file-name-masks'."
:group 'flymake
:type '(repeat (regexp))
:version "27.1")
Fix some flymake aliases * lisp/progmodes/flymake-proc.el (flymake-xml-program) (flymake-compilation-prevents-syntax-check, flymake-master-file-dirs) (flymake-master-file-count-limit, flymake-allowed-file-name-masks): * lisp/progmodes/flymake.el (flymake-start-syntax-check-on-find-file): Define aliases to user options before the options are defined.
2017-12-20 14:31:03 -05:00
(define-obsolete-variable-alias 'flymake-allowed-file-name-masks
'flymake-proc-allowed-file-name-masks "26.1")
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defcustom flymake-proc-allowed-file-name-masks
Fix three Flymake bugs when checking C header files The first of these problems is longstanding: if an error-less B.h is included from error-ridden A.h, flymake's legacy parser will panic (and disable itself) since it sees a non-zero exit for a clean file. To fix this, recommend returning 'true' in the documentation for the check-syntax target. Another problem was introduced by the parser rewrite. For error patterns spanning more than one line, point may be left in the middle of a line and thus render other patterns useless. Those patterns were written for the old line-by-line parser. To make them useful again, move to the beginning of line in those situations. The third problem was also longstanding and happened on newer GCC's: The "In file included from" prefix confused flymake-proc-get-real-file-name. Fix this. Also updated flymake--diag-region to fallback to highlighting a full line less often. Add automatic tests to check this. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Fix bug when patterns accidentally spans more than one line. Don't create diagnostics without error messages. (flymake-proc-real-file-name-considering-includes): New helper. (flymake-proc-allowed-file-name-masks): Use it. * lisp/progmodes/flymake.el (flymake-diag-region): Make COL argument explicitly optional. Only fall back to full line in extreme cases. * test/lisp/progmodes/flymake-tests.el (included-c-header-files): New test. (different-diagnostic-types): Update. * test/lisp/progmodes/flymake-resources/Makefile (check-syntax): Always return success (0) error code. (CC_OPTS): Add -Wextra * test/lisp/progmodes/flymake-resources/errors-and-warnings.c (main): Rewrite comments. * test/lisp/progmodes/flymake-resources/errors-and-warnings.c: Include some dummy header files. * test/lisp/progmodes/flymake-resources/no-problems.h: New file. * test/lisp/progmodes/flymake-resources/some-problems.h: New file. * doc/misc/flymake.texi (Example---Configuring a tool called via make): Recommend adding "|| true" to the check-syntax target.
2017-09-28 12:06:56 +01:00
'(("\\.\\(?:c\\(?:pp\\|xx\\|\\+\\+\\)?\\|CC\\)\\'"
flymake-proc-simple-make-init
nil
flymake-proc-real-file-name-considering-includes)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
("\\.xml\\'" flymake-proc-xml-init)
("\\.html?\\'" flymake-proc-xml-init)
("\\.cs\\'" flymake-proc-simple-make-init)
Add a Flymake backend for Perl Define a simple backend in perl-mode.el, which cperl-mode.el also uses. * lisp/progmodes/cperl-mode.el (cperl-mode): Add to flymake-diagnostic-functions. * lisp/progmodes/flymake-proc.el (flymake-proc-allowed-file-name-masks): Disable legacy backend for perl files. * lisp/progmodes/perl-mode.el (perl-flymake-command): New defcustom. (perl--flymake-proc): New buffer-local variable. (perl-flymake): New function. (perl-mode): Add to flymake-diagnostic-functions.
2017-11-03 16:05:39 +00:00
;; ("\\.p[ml]\\'" flymake-proc-perl-init)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
("\\.php[345]?\\'" flymake-proc-php-init)
("\\.h\\'" flymake-proc-master-make-header-init flymake-proc-master-cleanup)
("\\.java\\'" flymake-proc-simple-make-java-init flymake-proc-simple-java-cleanup)
("[0-9]+\\.tex\\'" flymake-proc-master-tex-init flymake-proc-master-cleanup)
("\\.tex\\'" flymake-proc-simple-tex-init)
("\\.idl\\'" flymake-proc-simple-make-init)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;; ("\\.cpp\\'" 1)
;; ("\\.java\\'" 3)
;; ("\\.h\\'" 2 ("\\.cpp\\'" "\\.c\\'")
;; ("[ \t]*#[ \t]*include[ \t]*\"\\([\w0-9/\\_\.]*[/\\]*\\)\\(%s\\)\"" 1 2))
;; ("\\.idl\\'" 1)
;; ("\\.odl\\'" 1)
;; ("[0-9]+\\.tex\\'" 2 ("\\.tex\\'")
;; ("[ \t]*\\input[ \t]*{\\(.*\\)\\(%s\\)}" 1 2 ))
;; ("\\.tex\\'" 1)
)
"Files syntax checking is allowed for.
User can specify files never subject to flymake. * lisp/progmodes/flymake-proc.el (flymake-proc-ignored-file-name-regexps): Add user customization option. (flymake-proc--get-file-name-mode-and-masks): Check it before `flymake-proc-allowed-file-name-masks'.
2017-11-01 09:36:41 -04:00
Variable `flymake-proc-ignored-file-name-regexps' overrides this variable.
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
This is an alist with elements of the form:
REGEXP INIT [CLEANUP [NAME]]
REGEXP is a regular expression that matches a file name.
INIT is the init function to use.
Shorten over-wide docstrings in defcustoms * lisp/calc/calc.el (calc-embedded-announce-formula-alist) (calc-embedded-open-formula, calc-embedded-close-formula) (calc-matrix-mode): * lisp/cedet/semantic/imenu.el (semantic-imenu-sort-bucket-function): * lisp/emacs-lisp/find-func.el (find-feature-regexp): * lisp/emulation/cua-base.el (cua-paste-pop-rotate-temporarily): * lisp/emulation/viper-init.el (viper-fast-keyseq-timeout) (viper-related-files-and-buffers-ring): * lisp/emulation/viper-keym.el (viper-want-ctl-h-help): * lisp/gnus/gnus-art.el (gnus-article-banner-alist): * lisp/gnus/gnus-group.el (gnus-keep-same-level): * lisp/gnus/gnus-score.el (gnus-adaptive-word-length-limit): * lisp/gnus/gnus-sum.el (gnus-inhibit-user-auto-expire): * lisp/gnus/gnus-uu.el (gnus-uu-ignore-files-by-type) (gnus-uu-do-not-unpack-archives) (gnus-uu-unmark-articles-not-decoded) (gnus-uu-correct-stripped-uucode, gnus-uu-save-in-digest) (gnus-uu-post-include-before-composing): * lisp/gnus/gnus.el (gnus-use-long-file-name) (gnus-install-group-spam-parameters): * lisp/gnus/message.el (message-cite-style): * lisp/gnus/nnmail.el (nnmail-split-fancy-with-parent-ignore-groups) (nnmail-cache-ignore-groups): * lisp/ido.el (ido-rewrite-file-prompt-functions): * lisp/mail/feedmail.el (feedmail-fiddle-plex-user-list) (feedmail-spray-address-fiddle-plex-list): * lisp/mh-e/mh-e.el (mh-annotate-msg-hook): * lisp/net/imap.el (imap-process-connection-type): * lisp/net/rcirc.el (rcirc-omit-threshold): * lisp/net/tramp-sh.el (tramp-copy-size-limit): * lisp/nxml/nxml-mode.el (nxml-default-buffer-file-coding-system): * lisp/obsolete/landmark.el (landmark-max-stall-time): * lisp/obsolete/tls.el (tls-checktrust): * lisp/org/org-indent.el (org-indent-mode-turns-off-org-adapt-indentation) (org-indent-mode-turns-on-hiding-stars): * lisp/org/org-protocol.el (org-protocol-project-alist): * lisp/progmodes/cc-vars.el (c-doc-comment-style): * lisp/progmodes/cperl-mode.el (cperl-indent-subs-specially): * lisp/progmodes/flymake-proc.el (flymake-proc-allowed-file-name-masks): * lisp/progmodes/hideif.el (hide-ifdef-expand-reinclusion-protection): * lisp/simple.el (minibuffer-history-case-insensitive-variables): * lisp/tab-bar.el (tab-bar-close-last-tab-choice): * lisp/textmodes/reftex-vars.el (reftex-special-environment-functions): * lisp/vc/ediff-init.el (ediff-startup-hook, ediff-cleanup-hook) (ediff-metachars): * lisp/vc/ediff-merg.el (ediff-show-clashes-only): * lisp/vc/ediff-mult.el (ediff-default-filtering-regexp): Shorten doc strings to not exceed 80-column limits. (Bug#44858)
2020-12-19 17:26:58 +01:00
CLEANUP is the cleanup function to use, default
`flymake-proc-simple-cleanup'.
NAME is the file name function to use, default
`flymake-proc-get-real-file-name'."
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
:group 'flymake
:type '(alist :key-type (regexp :tag "File regexp")
:value-type
(list :tag "Handler functions"
(function :tag "Init function")
(choice :tag "Cleanup function"
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(const :tag "flymake-proc-simple-cleanup" nil)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
function)
(choice :tag "Name function"
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(const :tag "flymake-proc-get-real-file-name" nil)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
function))))
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(defvar-local flymake-proc--current-process nil
Capitalize "Flymake" in docstrings and comments * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-setup-backends): Capitalize "Flymake" * lisp/progmodes/flymake-proc.el: (flymake-proc-reformat-err-line-patterns-from-compile-el) (flymake-proc--panic, flymake-proc-legacy-flymake) (flymake-start-syntax-check, flymake-proc-compile) (define-obsolete-variable-alias): Capitalize "Flymake" * lisp/progmodes/flymake.el (flymake-fringe-indicator-position) (flymake-make-diagnostic, flymake-delete-own-overlays) (flymake-diagnostic-functions) (flymake-diagnostic-types-alist, flymake-is-running) (flymake-make-report-fn, flymake-mode-on, flymake-mode-off) (flymake-goto-next-error, flymake-goto-prev-error): Capitalize "Flymake"
2017-09-30 18:04:45 +01:00
"Currently active Flymake process for a buffer, if any.")
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
(defvar flymake-proc--report-fn nil
Fix typos in Flymake documentation * doc/misc/flymake.texi (Syntax check statuses) (Adding support for a new syntax check tool) (Implementation overview, Locating the buildfile): Fix typos. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn) (flymake-proc--find-possible-master-files):Fix typos. (flymake-proc--panic) (flymake-proc-legacy-flymake): Fix function reference in doc. * lisp/progmodes/flymake.el (flymake-error) (flymake-diagnostic-functions): Fix typos. (flymake-diagnostic-types-alist): Rephrase and fix typos. (flymake--backend-state): Fix typos and rephrase. (flymake--handle-report): Delete empty line. (flymake--disable-backend) (flymake--run-backend): Fix typos. (flymake-goto-next-error, flymake-goto-prev-error): Rephrase.
2017-10-06 14:08:49 +01:00
"If bound, function used to report back to Flymake's UI.")
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
Batch of minor Flymake cleanup actions agreed to with Stefan Discussed with Stefan, in no particular order - Remove aliases for symbols thought to be internal to flymake-proc.el - Don’t need :group in defcustom and defface in flymake.el - Fix docstring of flymake-make-diagnostic - Fix docstring of flymake-diagnostic-functions to clarify keywords. - Mark overlays with just the property ’flymake, not ’flymake-overlay - Tune flymake-overlays for performance - Make flymake-mode-on and flymake-mode-off obsolete - Don’t use hash-table-keys unless necessary. - Copyright notice in flymake-elisp. Added some more - Clarify docstring of flymake-goto-next-error - Clarify a comment in flymake--run-backend complaining about ert-deftest. - Prevent compilation warnings in flymake-proc.el - Remove doctring from obsolete aliases Now the changelog: * lisp/progmodes/flymake-elisp.el: Proper copyright notice. * lisp/progmodes/flymake-proc.el (flymake-warning-re) (flymake-proc-diagnostic-type-pred) (flymake-proc-default-guess) (flymake-proc--get-file-name-mode-and-masks): Move up to beginning of file to shoosh compiler warnings (define-obsolete-variable-alias): Delete many obsolete aliases. * lisp/progmodes/flymake.el (flymake-error-bitmap) (flymake-warning-bitmap, flymake-note-bitmap) (flymake-fringe-indicator-position) (flymake-start-syntax-check-on-newline) (flymake-no-changes-timeout, flymake-gui-warnings-enabled) (flymake-start-syntax-check-on-find-file, flymake-log-level) (flymake-wrap-around, flymake-error, flymake-warning) (flymake-note): Don't need :group in these defcustom and defface. (flymake--run-backend): Clarify comment (flymake-mode-map): Remove. (flymake-make-diagnostic): Fix docstring. (flymake--highlight-line, flymake--overlays): Identify flymake overlays with just ’flymake. (flymake--overlays): Reverse order of invocation for cl-remove-if-not and cl-sort. (flymake-mode-on) (flymake-mode-off): Make obsolete. (flymake-goto-next-error, flymake-goto-prev-error): Fix docstring. (flymake-diagnostic-functions): Clarify keyword arguments in docstring. Maybe squash in that one where I remove many obsoletes
2017-09-29 11:02:36 +01:00
(defun flymake-proc-reformat-err-line-patterns-from-compile-el (original-list)
"Grab error line patterns from ORIGINAL-LIST in compile.el format.
Capitalize "Flymake" in docstrings and comments * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-setup-backends): Capitalize "Flymake" * lisp/progmodes/flymake-proc.el: (flymake-proc-reformat-err-line-patterns-from-compile-el) (flymake-proc--panic, flymake-proc-legacy-flymake) (flymake-start-syntax-check, flymake-proc-compile) (define-obsolete-variable-alias): Capitalize "Flymake" * lisp/progmodes/flymake.el (flymake-fringe-indicator-position) (flymake-make-diagnostic, flymake-delete-own-overlays) (flymake-diagnostic-functions) (flymake-diagnostic-types-alist, flymake-is-running) (flymake-make-report-fn, flymake-mode-on, flymake-mode-off) (flymake-goto-next-error, flymake-goto-prev-error): Capitalize "Flymake"
2017-09-30 18:04:45 +01:00
Convert it to Flymake internal format."
Batch of minor Flymake cleanup actions agreed to with Stefan Discussed with Stefan, in no particular order - Remove aliases for symbols thought to be internal to flymake-proc.el - Don’t need :group in defcustom and defface in flymake.el - Fix docstring of flymake-make-diagnostic - Fix docstring of flymake-diagnostic-functions to clarify keywords. - Mark overlays with just the property ’flymake, not ’flymake-overlay - Tune flymake-overlays for performance - Make flymake-mode-on and flymake-mode-off obsolete - Don’t use hash-table-keys unless necessary. - Copyright notice in flymake-elisp. Added some more - Clarify docstring of flymake-goto-next-error - Clarify a comment in flymake--run-backend complaining about ert-deftest. - Prevent compilation warnings in flymake-proc.el - Remove doctring from obsolete aliases Now the changelog: * lisp/progmodes/flymake-elisp.el: Proper copyright notice. * lisp/progmodes/flymake-proc.el (flymake-warning-re) (flymake-proc-diagnostic-type-pred) (flymake-proc-default-guess) (flymake-proc--get-file-name-mode-and-masks): Move up to beginning of file to shoosh compiler warnings (define-obsolete-variable-alias): Delete many obsolete aliases. * lisp/progmodes/flymake.el (flymake-error-bitmap) (flymake-warning-bitmap, flymake-note-bitmap) (flymake-fringe-indicator-position) (flymake-start-syntax-check-on-newline) (flymake-no-changes-timeout, flymake-gui-warnings-enabled) (flymake-start-syntax-check-on-find-file, flymake-log-level) (flymake-wrap-around, flymake-error, flymake-warning) (flymake-note): Don't need :group in these defcustom and defface. (flymake--run-backend): Clarify comment (flymake-mode-map): Remove. (flymake-make-diagnostic): Fix docstring. (flymake--highlight-line, flymake--overlays): Identify flymake overlays with just ’flymake. (flymake--overlays): Reverse order of invocation for cl-remove-if-not and cl-sort. (flymake-mode-on) (flymake-mode-off): Make obsolete. (flymake-goto-next-error, flymake-goto-prev-error): Fix docstring. (flymake-diagnostic-functions): Clarify keyword arguments in docstring. Maybe squash in that one where I remove many obsoletes
2017-09-29 11:02:36 +01:00
(let* ((converted-list '()))
(dolist (item original-list)
(setq item (cdr item))
(let ((regexp (nth 0 item))
(file (nth 1 item))
(line (nth 2 item))
(col (nth 3 item)))
(if (consp file) (setq file (car file)))
(if (consp line) (setq line (car line)))
(if (consp col) (setq col (car col)))
(when (not (functionp line))
(setq converted-list (cons (list regexp file line col) converted-list)))))
converted-list))
The tedious game of whack-a-mole with compiler warnings continues * lisp/abbrev.el (edit-abbrevs-map): * lisp/emacs-lock.el (emacs-lock-from-exiting): * lisp/htmlfontify.el (hfy-optimisations): * lisp/ielm.el (inferior-emacs-lisp-mode-hook) (inferior-emacs-lisp-mode-map): * lisp/isearch.el (isearch-lazy-highlight-word): * lisp/select.el (x-select-enable-clipboard, x-select-enable-primary): * lisp/shell.el (shell-dirtrack-mode): * lisp/skeleton.el (skeleton-transformation, skeleton-filter): * lisp/startup.el (inhibit-splash-screen, inhibit-startup-message): * lisp/window.el (even-window-heights): * lisp/calendar/timeclock.el (timeclock-modeline-display): * lisp/cedet/semantic/db-mode.el (semanticdb-mode-hook) (semanticdb-global-mode): * lisp/emacs-lisp/edebug.el (gud-inhibit-global-bindings): * lisp/emacs-lisp/warnings.el (display-warning-minimum-level) (log-warning-minimum-level): * lisp/erc/erc-dcc.el (erc-dcc-chat-filter-hook): * lisp/gnus/nnspool.el (news-path): * lisp/org/org-agenda.el (org-agenda-search-view-search-words-only) (org-agenda-remove-tags-when-in-prefix) (org-agenda-align-tags-to-column, org-agenda-keymap): * lisp/org/org.el (org-special-ctrl-a) (org-log-state-notes-into-drawer) (org-agenda-multi-occur-extra-files): * lisp/progmodes/flymake-proc.el (flymake-err-line-patterns) (flymake-check-file-limit): * lisp/progmodes/make-mode.el (makefile-query-one-target-method): * lisp/progmodes/octave.el (inferior-octave-startup-hook): * lisp/progmodes/python.el (python-buffer) (python-preoutput-result): * lisp/progmodes/sql.el (sql-dialect): * lisp/textmodes/artist.el (artist-text-renderer): * lisp/textmodes/bibtex.el (bibtex-autokey-name-case-convert) (bibtex-autokey-titleword-case-convert): * lisp/textmodes/flyspell.el (flyspell-generic-check-word-p): * lisp/textmodes/ispell.el (ispell-format-word): * lisp/textmodes/rst.el (rst-preferred-decorations): * lisp/textmodes/sgml-mode.el (sgml-transformation): Move aliases before targets, to silence new compiler warning. * lisp/term/ns-win.el (ns-option-modifier, ns-right-option-modifier): Silence warning.
2018-04-20 18:34:39 -04:00
(define-obsolete-variable-alias 'flymake-err-line-patterns
'flymake-proc-err-line-patterns "26.1")
Batch of minor Flymake cleanup actions agreed to with Stefan Discussed with Stefan, in no particular order - Remove aliases for symbols thought to be internal to flymake-proc.el - Don’t need :group in defcustom and defface in flymake.el - Fix docstring of flymake-make-diagnostic - Fix docstring of flymake-diagnostic-functions to clarify keywords. - Mark overlays with just the property ’flymake, not ’flymake-overlay - Tune flymake-overlays for performance - Make flymake-mode-on and flymake-mode-off obsolete - Don’t use hash-table-keys unless necessary. - Copyright notice in flymake-elisp. Added some more - Clarify docstring of flymake-goto-next-error - Clarify a comment in flymake--run-backend complaining about ert-deftest. - Prevent compilation warnings in flymake-proc.el - Remove doctring from obsolete aliases Now the changelog: * lisp/progmodes/flymake-elisp.el: Proper copyright notice. * lisp/progmodes/flymake-proc.el (flymake-warning-re) (flymake-proc-diagnostic-type-pred) (flymake-proc-default-guess) (flymake-proc--get-file-name-mode-and-masks): Move up to beginning of file to shoosh compiler warnings (define-obsolete-variable-alias): Delete many obsolete aliases. * lisp/progmodes/flymake.el (flymake-error-bitmap) (flymake-warning-bitmap, flymake-note-bitmap) (flymake-fringe-indicator-position) (flymake-start-syntax-check-on-newline) (flymake-no-changes-timeout, flymake-gui-warnings-enabled) (flymake-start-syntax-check-on-find-file, flymake-log-level) (flymake-wrap-around, flymake-error, flymake-warning) (flymake-note): Don't need :group in these defcustom and defface. (flymake--run-backend): Clarify comment (flymake-mode-map): Remove. (flymake-make-diagnostic): Fix docstring. (flymake--highlight-line, flymake--overlays): Identify flymake overlays with just ’flymake. (flymake--overlays): Reverse order of invocation for cl-remove-if-not and cl-sort. (flymake-mode-on) (flymake-mode-off): Make obsolete. (flymake-goto-next-error, flymake-goto-prev-error): Fix docstring. (flymake-diagnostic-functions): Clarify keyword arguments in docstring. Maybe squash in that one where I remove many obsoletes
2017-09-29 11:02:36 +01:00
(defvar flymake-proc-err-line-patterns ; regexp file-idx line-idx col-idx (optional) text-idx(optional), match-end to end of string is error text
(append
'(
;; MS Visual C++ 6.0
("\\(\\([a-zA-Z]:\\)?[^:(\t\n]+\\)(\\([0-9]+\\)) : \\(\\(error\\|warning\\|fatal error\\) \\(C[0-9]+\\):[ \t\n]*\\(.+\\)\\)"
1 3 nil 4)
;; jikes
("\\(\\([a-zA-Z]:\\)?[^:(\t\n]+\\):\\([0-9]+\\):[0-9]+:[0-9]+:[0-9]+: \\(\\(Error\\|Warning\\|Caution\\|Semantic Error\\):[ \t\n]*\\(.+\\)\\)"
1 3 nil 4)
;; MS midl
("midl[ ]*:[ ]*\\(command line error .*\\)"
nil nil nil 1)
;; MS C#
("\\(\\([a-zA-Z]:\\)?[^:(\t\n]+\\)(\\([0-9]+\\),[0-9]+): \\(\\(error\\|warning\\|fatal error\\) \\(CS[0-9]+\\):[ \t\n]*\\(.+\\)\\)"
1 3 nil 4)
;; perl
("\\(.*\\) at \\([^ \n]+\\) line \\([0-9]+\\)[,.\n]" 2 3 nil 1)
;; PHP
("\\(?:Parse\\|Fatal\\) error: \\(.*\\) in \\(.*\\) on line \\([0-9]+\\)" 2 3 nil 1)
;; LaTeX warnings (fileless) ("\\(LaTeX \\(Warning\\|Error\\): .*\\) on input line \\([0-9]+\\)" 20 3 nil 1)
;; ant/javac. Note this also matches gcc warnings!
(" *\\(\\[javac\\] *\\)?\\(\\([a-zA-Z]:\\)?[^:(\t\n]+\\):\\([0-9]+\\)\\(?::\\([0-9]+\\)\\)?:[ \t\n]*\\(.+\\)"
2 4 5 6))
;; compilation-error-regexp-alist)
(flymake-proc-reformat-err-line-patterns-from-compile-el compilation-error-regexp-alist-alist))
; Minor stylistic fixes found by checkdoc
2021-09-14 08:43:18 +02:00
"Patterns for matching error/warning lines.
Each pattern has the form:
(REGEXP FILE-IDX LINE-IDX COL-IDX ERR-TEXT-IDX)
Use `flymake-proc-reformat-err-line-patterns-from-compile-el' to
add patterns from compile.el.")
Batch of minor Flymake cleanup actions agreed to with Stefan Discussed with Stefan, in no particular order - Remove aliases for symbols thought to be internal to flymake-proc.el - Don’t need :group in defcustom and defface in flymake.el - Fix docstring of flymake-make-diagnostic - Fix docstring of flymake-diagnostic-functions to clarify keywords. - Mark overlays with just the property ’flymake, not ’flymake-overlay - Tune flymake-overlays for performance - Make flymake-mode-on and flymake-mode-off obsolete - Don’t use hash-table-keys unless necessary. - Copyright notice in flymake-elisp. Added some more - Clarify docstring of flymake-goto-next-error - Clarify a comment in flymake--run-backend complaining about ert-deftest. - Prevent compilation warnings in flymake-proc.el - Remove doctring from obsolete aliases Now the changelog: * lisp/progmodes/flymake-elisp.el: Proper copyright notice. * lisp/progmodes/flymake-proc.el (flymake-warning-re) (flymake-proc-diagnostic-type-pred) (flymake-proc-default-guess) (flymake-proc--get-file-name-mode-and-masks): Move up to beginning of file to shoosh compiler warnings (define-obsolete-variable-alias): Delete many obsolete aliases. * lisp/progmodes/flymake.el (flymake-error-bitmap) (flymake-warning-bitmap, flymake-note-bitmap) (flymake-fringe-indicator-position) (flymake-start-syntax-check-on-newline) (flymake-no-changes-timeout, flymake-gui-warnings-enabled) (flymake-start-syntax-check-on-find-file, flymake-log-level) (flymake-wrap-around, flymake-error, flymake-warning) (flymake-note): Don't need :group in these defcustom and defface. (flymake--run-backend): Clarify comment (flymake-mode-map): Remove. (flymake-make-diagnostic): Fix docstring. (flymake--highlight-line, flymake--overlays): Identify flymake overlays with just ’flymake. (flymake--overlays): Reverse order of invocation for cl-remove-if-not and cl-sort. (flymake-mode-on) (flymake-mode-off): Make obsolete. (flymake-goto-next-error, flymake-goto-prev-error): Fix docstring. (flymake-diagnostic-functions): Clarify keyword arguments in docstring. Maybe squash in that one where I remove many obsoletes
2017-09-29 11:02:36 +01:00
(define-obsolete-variable-alias 'flymake-warning-re 'flymake-proc-diagnostic-type-pred "26.1")
(defvar flymake-proc-diagnostic-type-pred
'flymake-proc-default-guess
"Predicate matching against diagnostic text to detect its type.
Takes a single argument, the diagnostic's text and should return
Obsolete Flymake's flymake-diagnostic-types-alist That varaiable was an association between symbols and properties, effecively duplicating symbol's property lists. It is simpler to just put properties on symbols. Backward compatibility to the old variable has been kept. * doc/misc/flymake.texi (Flymake error types): Don't mention flymake-diagnostic-types-alist. (Flymake error types): Rework section. (Backend functions): Refill a paragraph. (Flymake utility functions): Don't mention flymake-diagnostic-types-alist. (Proc customization variables): Don't mention flymake-diagnostic-types-alist. * etc/NEWS: Mention obsoletion of flymake-diagnostic-types-alist. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Don't use flymake-diagnostic-types-alist. * lisp/progmodes/flymake.el: Rewrite commentary. (flymake-make-diagnostic, flymake-mode, flymake-goto-next-error) (flymake-goto-prev-error): Don't mention flymake-diagnostic-types-alist in docstring. (flymake-diagnostic-types-alist): Make obsolete. (:error, :warning, :note): Put flymake-category in these symbols. (flymake-error, flymake-warning, flymake-note): Put `flymake-bitmap', not `bitmap' in these symbols. (flymake--lookup-type-property, flymake--highlight-line): Rewrite. Honor flymake-diagnostic-types-alist for backward compatibility. * lisp/progmodes/python.el (python-flymake-msg-alist): Don't mention flymake-diagnostic-types-alist.
2018-06-05 15:13:02 +01:00
a diagnostic symbol naming a type. If the returned value is nil,
a type of `:error' is assumed. For some backward compatibility,
if a non-nil value is returned that doesn't name a type,
`:warning' is assumed.
Batch of minor Flymake cleanup actions agreed to with Stefan Discussed with Stefan, in no particular order - Remove aliases for symbols thought to be internal to flymake-proc.el - Don’t need :group in defcustom and defface in flymake.el - Fix docstring of flymake-make-diagnostic - Fix docstring of flymake-diagnostic-functions to clarify keywords. - Mark overlays with just the property ’flymake, not ’flymake-overlay - Tune flymake-overlays for performance - Make flymake-mode-on and flymake-mode-off obsolete - Don’t use hash-table-keys unless necessary. - Copyright notice in flymake-elisp. Added some more - Clarify docstring of flymake-goto-next-error - Clarify a comment in flymake--run-backend complaining about ert-deftest. - Prevent compilation warnings in flymake-proc.el - Remove doctring from obsolete aliases Now the changelog: * lisp/progmodes/flymake-elisp.el: Proper copyright notice. * lisp/progmodes/flymake-proc.el (flymake-warning-re) (flymake-proc-diagnostic-type-pred) (flymake-proc-default-guess) (flymake-proc--get-file-name-mode-and-masks): Move up to beginning of file to shoosh compiler warnings (define-obsolete-variable-alias): Delete many obsolete aliases. * lisp/progmodes/flymake.el (flymake-error-bitmap) (flymake-warning-bitmap, flymake-note-bitmap) (flymake-fringe-indicator-position) (flymake-start-syntax-check-on-newline) (flymake-no-changes-timeout, flymake-gui-warnings-enabled) (flymake-start-syntax-check-on-find-file, flymake-log-level) (flymake-wrap-around, flymake-error, flymake-warning) (flymake-note): Don't need :group in these defcustom and defface. (flymake--run-backend): Clarify comment (flymake-mode-map): Remove. (flymake-make-diagnostic): Fix docstring. (flymake--highlight-line, flymake--overlays): Identify flymake overlays with just ’flymake. (flymake--overlays): Reverse order of invocation for cl-remove-if-not and cl-sort. (flymake-mode-on) (flymake-mode-off): Make obsolete. (flymake-goto-next-error, flymake-goto-prev-error): Fix docstring. (flymake-diagnostic-functions): Clarify keyword arguments in docstring. Maybe squash in that one where I remove many obsoletes
2017-09-29 11:02:36 +01:00
Instead of a function, it can also be a string, a regular
Fix some duplicate words typos * lisp/erc/erc.el (erc-hide-current-message-p): * lisp/progmodes/flymake-proc.el (flymake-proc-diagnostic-type-pred): * doc/lispref/display.texi (Bidirectional Display, Delayed Warnings): * doc/lispref/functions.texi (Defining Functions): * doc/lispref/os.texi (Terminal-Specific): * doc/misc/sem-user.texi (Analyzer Debug): * doc/misc/srecode.texi (Special Variables): Fix typos.
2017-10-27 20:45:23 -04:00
expression. A match indicates `:warning' type, otherwise
Batch of minor Flymake cleanup actions agreed to with Stefan Discussed with Stefan, in no particular order - Remove aliases for symbols thought to be internal to flymake-proc.el - Don’t need :group in defcustom and defface in flymake.el - Fix docstring of flymake-make-diagnostic - Fix docstring of flymake-diagnostic-functions to clarify keywords. - Mark overlays with just the property ’flymake, not ’flymake-overlay - Tune flymake-overlays for performance - Make flymake-mode-on and flymake-mode-off obsolete - Don’t use hash-table-keys unless necessary. - Copyright notice in flymake-elisp. Added some more - Clarify docstring of flymake-goto-next-error - Clarify a comment in flymake--run-backend complaining about ert-deftest. - Prevent compilation warnings in flymake-proc.el - Remove doctring from obsolete aliases Now the changelog: * lisp/progmodes/flymake-elisp.el: Proper copyright notice. * lisp/progmodes/flymake-proc.el (flymake-warning-re) (flymake-proc-diagnostic-type-pred) (flymake-proc-default-guess) (flymake-proc--get-file-name-mode-and-masks): Move up to beginning of file to shoosh compiler warnings (define-obsolete-variable-alias): Delete many obsolete aliases. * lisp/progmodes/flymake.el (flymake-error-bitmap) (flymake-warning-bitmap, flymake-note-bitmap) (flymake-fringe-indicator-position) (flymake-start-syntax-check-on-newline) (flymake-no-changes-timeout, flymake-gui-warnings-enabled) (flymake-start-syntax-check-on-find-file, flymake-log-level) (flymake-wrap-around, flymake-error, flymake-warning) (flymake-note): Don't need :group in these defcustom and defface. (flymake--run-backend): Clarify comment (flymake-mode-map): Remove. (flymake-make-diagnostic): Fix docstring. (flymake--highlight-line, flymake--overlays): Identify flymake overlays with just ’flymake. (flymake--overlays): Reverse order of invocation for cl-remove-if-not and cl-sort. (flymake-mode-on) (flymake-mode-off): Make obsolete. (flymake-goto-next-error, flymake-goto-prev-error): Fix docstring. (flymake-diagnostic-functions): Clarify keyword arguments in docstring. Maybe squash in that one where I remove many obsoletes
2017-09-29 11:02:36 +01:00
`:error'")
(defun flymake-proc-default-guess (text)
"Guess if TEXT means a warning, a note or an error."
(cond ((string-match "^[wW]arning" text)
:warning)
((string-match "^[nN]ote" text)
:note)
(t
:error)))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-file-name-mode-and-masks (file-name)
User can specify files never subject to flymake. * lisp/progmodes/flymake-proc.el (flymake-proc-ignored-file-name-regexps): Add user customization option. (flymake-proc--get-file-name-mode-and-masks): Check it before `flymake-proc-allowed-file-name-masks'.
2017-11-01 09:36:41 -04:00
"Return the corresponding entry from `flymake-proc-allowed-file-name-masks'.
If the FILE-NAME matches a regexp from `flymake-proc-ignored-file-name-regexps',
`flymake-proc-allowed-file-name-masks' is not searched."
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(unless (stringp file-name)
(error "Invalid file-name"))
User can specify files never subject to flymake. * lisp/progmodes/flymake-proc.el (flymake-proc-ignored-file-name-regexps): Add user customization option. (flymake-proc--get-file-name-mode-and-masks): Check it before `flymake-proc-allowed-file-name-masks'.
2017-11-01 09:36:41 -04:00
(if (cl-find file-name flymake-proc-ignored-file-name-regexps
:test (lambda (fn rex) (string-match rex fn)))
(flymake-log 3 "file %s ignored")
(let ((fnm flymake-proc-allowed-file-name-masks)
(mode-and-masks nil))
(while (and (not mode-and-masks) fnm)
(if (string-match (car (car fnm)) file-name)
(setq mode-and-masks (cdr (car fnm))))
(setq fnm (cdr fnm)))
(flymake-log 3 "file %s, init=%s" file-name (car mode-and-masks))
mode-and-masks)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-init-function (file-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Return init function to be used for the file."
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(let* ((init-f (nth 0 (flymake-proc--get-file-name-mode-and-masks file-name))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;;(flymake-log 0 "calling %s" init-f)
;;(funcall init-f (current-buffer))
init-f))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-cleanup-function (file-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Return cleanup function to be used for the file."
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(or (nth 1 (flymake-proc--get-file-name-mode-and-masks file-name))
'flymake-proc-simple-cleanup))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-real-file-name-function (file-name)
(or (nth 2 (flymake-proc--get-file-name-mode-and-masks file-name))
'flymake-proc-get-real-file-name))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defvar flymake-proc--find-buildfile-cache (make-hash-table :test #'equal))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-buildfile-from-cache (dir-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Look up DIR-NAME in cache and return its associated value.
If DIR-NAME is not found, return nil."
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(gethash dir-name flymake-proc--find-buildfile-cache))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--add-buildfile-to-cache (dir-name buildfile)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Associate DIR-NAME with BUILDFILE in the buildfile cache."
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(puthash dir-name buildfile flymake-proc--find-buildfile-cache))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--clear-buildfile-cache ()
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Clear the buildfile cache."
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(clrhash flymake-proc--find-buildfile-cache))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--find-buildfile (buildfile-name source-dir-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Find buildfile starting from current directory.
Buildfile includes Makefile, build.xml etc.
Return its file name if found, or nil if not found."
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(or (flymake-proc--get-buildfile-from-cache source-dir-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(let* ((file (locate-dominating-file source-dir-name buildfile-name)))
(if file
(progn
(flymake-log 3 "found buildfile at %s" file)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(flymake-proc--add-buildfile-to-cache source-dir-name file)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
file)
(progn
(flymake-log 3 "buildfile for %s not found" source-dir-name)
nil)))))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--fix-file-name (name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Replace all occurrences of `\\' with `/'."
(when name
(setq name (expand-file-name name))
(setq name (abbreviate-file-name name))
(setq name (directory-file-name name))
name))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--same-files (file-name-one file-name-two)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Check if FILE-NAME-ONE and FILE-NAME-TWO point to same file.
Return t if so, nil if not."
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(equal (flymake-proc--fix-file-name file-name-one)
(flymake-proc--fix-file-name file-name-two)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;; This is bound dynamically to pass a parameter to a sort predicate below
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defvar flymake-proc--included-file-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--find-possible-master-files (file-name master-file-dirs masks)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Find (by name and location) all possible master files.
Name is specified by FILE-NAME and location is specified by
MASTER-FILE-DIRS. Master files include .cpp and .c for .h.
Files are searched for starting from the .h directory and max
max-level parent dirs. File contents are not checked."
(let* ((dirs master-file-dirs)
(files nil)
(done nil))
(while (and (not done) dirs)
(let* ((dir (expand-file-name (car dirs) (file-name-directory file-name)))
(masks masks))
(while (and (file-exists-p dir) (not done) masks)
(let* ((mask (car masks))
(dir-files (directory-files dir t mask)))
(flymake-log 3 "dir %s, %d file(s) for mask %s"
dir (length dir-files) mask)
(while (and (not done) dir-files)
(when (not (file-directory-p (car dir-files)))
(setq files (cons (car dir-files) files))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(when (>= (length files) flymake-proc-master-file-count-limit)
(flymake-log 3 "master file count limit (%d) reached" flymake-proc-master-file-count-limit)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(setq done t)))
(setq dir-files (cdr dir-files))))
(setq masks (cdr masks))))
(setq dirs (cdr dirs)))
(when files
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(let ((flymake-proc--included-file-name (file-name-nondirectory file-name)))
(setq files (sort files 'flymake-proc--master-file-compare))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(flymake-log 3 "found %d possible master file(s)" (length files))
files))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--master-file-compare (file-one file-two)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Compare two files specified by FILE-ONE and FILE-TWO.
This function is used in sort to move most possible file names
to the beginning of the list (File.h -> File.cpp moved to top)."
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(and (equal (file-name-sans-extension flymake-proc--included-file-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(file-name-base file-one))
(not (equal file-one file-two))))
The tedious game of whack-a-mole with compiler warnings continues * lisp/abbrev.el (edit-abbrevs-map): * lisp/emacs-lock.el (emacs-lock-from-exiting): * lisp/htmlfontify.el (hfy-optimisations): * lisp/ielm.el (inferior-emacs-lisp-mode-hook) (inferior-emacs-lisp-mode-map): * lisp/isearch.el (isearch-lazy-highlight-word): * lisp/select.el (x-select-enable-clipboard, x-select-enable-primary): * lisp/shell.el (shell-dirtrack-mode): * lisp/skeleton.el (skeleton-transformation, skeleton-filter): * lisp/startup.el (inhibit-splash-screen, inhibit-startup-message): * lisp/window.el (even-window-heights): * lisp/calendar/timeclock.el (timeclock-modeline-display): * lisp/cedet/semantic/db-mode.el (semanticdb-mode-hook) (semanticdb-global-mode): * lisp/emacs-lisp/edebug.el (gud-inhibit-global-bindings): * lisp/emacs-lisp/warnings.el (display-warning-minimum-level) (log-warning-minimum-level): * lisp/erc/erc-dcc.el (erc-dcc-chat-filter-hook): * lisp/gnus/nnspool.el (news-path): * lisp/org/org-agenda.el (org-agenda-search-view-search-words-only) (org-agenda-remove-tags-when-in-prefix) (org-agenda-align-tags-to-column, org-agenda-keymap): * lisp/org/org.el (org-special-ctrl-a) (org-log-state-notes-into-drawer) (org-agenda-multi-occur-extra-files): * lisp/progmodes/flymake-proc.el (flymake-err-line-patterns) (flymake-check-file-limit): * lisp/progmodes/make-mode.el (makefile-query-one-target-method): * lisp/progmodes/octave.el (inferior-octave-startup-hook): * lisp/progmodes/python.el (python-buffer) (python-preoutput-result): * lisp/progmodes/sql.el (sql-dialect): * lisp/textmodes/artist.el (artist-text-renderer): * lisp/textmodes/bibtex.el (bibtex-autokey-name-case-convert) (bibtex-autokey-titleword-case-convert): * lisp/textmodes/flyspell.el (flyspell-generic-check-word-p): * lisp/textmodes/ispell.el (ispell-format-word): * lisp/textmodes/rst.el (rst-preferred-decorations): * lisp/textmodes/sgml-mode.el (sgml-transformation): Move aliases before targets, to silence new compiler warning. * lisp/term/ns-win.el (ns-option-modifier, ns-right-option-modifier): Silence warning.
2018-04-20 18:34:39 -04:00
(define-obsolete-variable-alias 'flymake-check-file-limit
'flymake-proc-check-file-limit "26.1")
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defvar flymake-proc-check-file-limit 8192
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Maximum number of chars to look at when checking possible master file.
Nil means search the entire file.")
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--check-patch-master-file-buffer
Batch of minor Flymake cleanup actions agreed to with Stefan Discussed with Stefan, in no particular order - Remove aliases for symbols thought to be internal to flymake-proc.el - Don’t need :group in defcustom and defface in flymake.el - Fix docstring of flymake-make-diagnostic - Fix docstring of flymake-diagnostic-functions to clarify keywords. - Mark overlays with just the property ’flymake, not ’flymake-overlay - Tune flymake-overlays for performance - Make flymake-mode-on and flymake-mode-off obsolete - Don’t use hash-table-keys unless necessary. - Copyright notice in flymake-elisp. Added some more - Clarify docstring of flymake-goto-next-error - Clarify a comment in flymake--run-backend complaining about ert-deftest. - Prevent compilation warnings in flymake-proc.el - Remove doctring from obsolete aliases Now the changelog: * lisp/progmodes/flymake-elisp.el: Proper copyright notice. * lisp/progmodes/flymake-proc.el (flymake-warning-re) (flymake-proc-diagnostic-type-pred) (flymake-proc-default-guess) (flymake-proc--get-file-name-mode-and-masks): Move up to beginning of file to shoosh compiler warnings (define-obsolete-variable-alias): Delete many obsolete aliases. * lisp/progmodes/flymake.el (flymake-error-bitmap) (flymake-warning-bitmap, flymake-note-bitmap) (flymake-fringe-indicator-position) (flymake-start-syntax-check-on-newline) (flymake-no-changes-timeout, flymake-gui-warnings-enabled) (flymake-start-syntax-check-on-find-file, flymake-log-level) (flymake-wrap-around, flymake-error, flymake-warning) (flymake-note): Don't need :group in these defcustom and defface. (flymake--run-backend): Clarify comment (flymake-mode-map): Remove. (flymake-make-diagnostic): Fix docstring. (flymake--highlight-line, flymake--overlays): Identify flymake overlays with just ’flymake. (flymake--overlays): Reverse order of invocation for cl-remove-if-not and cl-sort. (flymake-mode-on) (flymake-mode-off): Make obsolete. (flymake-goto-next-error, flymake-goto-prev-error): Fix docstring. (flymake-diagnostic-functions): Clarify keyword arguments in docstring. Maybe squash in that one where I remove many obsoletes
2017-09-29 11:02:36 +01:00
(master-file-temp-buffer
master-file-name patched-master-file-name
source-file-name patched-source-file-name
include-dirs regexp)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Check if MASTER-FILE-NAME is a master file for SOURCE-FILE-NAME.
If yes, patch a copy of MASTER-FILE-NAME to include PATCHED-SOURCE-FILE-NAME
instead of SOURCE-FILE-NAME.
For example, foo.cpp is a master file if it includes foo.h.
When a buffer for MASTER-FILE-NAME exists, use it as a source
instead of reading master file from disk."
(let* ((source-file-nondir (file-name-nondirectory source-file-name))
(source-file-extension (file-name-extension source-file-nondir))
(source-file-nonext (file-name-sans-extension source-file-nondir))
(found nil)
(inc-name nil)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(search-limit flymake-proc-check-file-limit))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(setq regexp
(format regexp ; "[ \t]*#[ \t]*include[ \t]*\"\\(.*%s\\)\""
;; Hack for tex files, where \include often excludes .tex.
;; Maybe this is safe generally.
(if (and (> (length source-file-extension) 1)
(string-equal source-file-extension "tex"))
(format "%s\\(?:\\.%s\\)?"
(regexp-quote source-file-nonext)
(regexp-quote source-file-extension))
(regexp-quote source-file-nondir))))
(unwind-protect
(with-current-buffer master-file-temp-buffer
(if (or (not search-limit)
(> search-limit (point-max)))
(setq search-limit (point-max)))
(flymake-log 3 "checking %s against regexp %s"
master-file-name regexp)
(goto-char (point-min))
(while (and (< (point) search-limit)
(re-search-forward regexp search-limit t))
(let ((match-beg (match-beginning 1))
(match-end (match-end 1)))
(flymake-log 3 "found possible match for %s" source-file-nondir)
(setq inc-name (match-string 1))
(and (> (length source-file-extension) 1)
(string-equal source-file-extension "tex")
(not (string-match (format "\\.%s\\'" source-file-extension)
inc-name))
(setq inc-name (concat inc-name "." source-file-extension)))
(when (eq t (compare-strings
source-file-nondir nil nil
inc-name (- (length inc-name)
(length source-file-nondir)) nil))
(flymake-log 3 "inc-name=%s" inc-name)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(when (flymake-proc--check-include source-file-name inc-name
Batch of minor Flymake cleanup actions agreed to with Stefan Discussed with Stefan, in no particular order - Remove aliases for symbols thought to be internal to flymake-proc.el - Don’t need :group in defcustom and defface in flymake.el - Fix docstring of flymake-make-diagnostic - Fix docstring of flymake-diagnostic-functions to clarify keywords. - Mark overlays with just the property ’flymake, not ’flymake-overlay - Tune flymake-overlays for performance - Make flymake-mode-on and flymake-mode-off obsolete - Don’t use hash-table-keys unless necessary. - Copyright notice in flymake-elisp. Added some more - Clarify docstring of flymake-goto-next-error - Clarify a comment in flymake--run-backend complaining about ert-deftest. - Prevent compilation warnings in flymake-proc.el - Remove doctring from obsolete aliases Now the changelog: * lisp/progmodes/flymake-elisp.el: Proper copyright notice. * lisp/progmodes/flymake-proc.el (flymake-warning-re) (flymake-proc-diagnostic-type-pred) (flymake-proc-default-guess) (flymake-proc--get-file-name-mode-and-masks): Move up to beginning of file to shoosh compiler warnings (define-obsolete-variable-alias): Delete many obsolete aliases. * lisp/progmodes/flymake.el (flymake-error-bitmap) (flymake-warning-bitmap, flymake-note-bitmap) (flymake-fringe-indicator-position) (flymake-start-syntax-check-on-newline) (flymake-no-changes-timeout, flymake-gui-warnings-enabled) (flymake-start-syntax-check-on-find-file, flymake-log-level) (flymake-wrap-around, flymake-error, flymake-warning) (flymake-note): Don't need :group in these defcustom and defface. (flymake--run-backend): Clarify comment (flymake-mode-map): Remove. (flymake-make-diagnostic): Fix docstring. (flymake--highlight-line, flymake--overlays): Identify flymake overlays with just ’flymake. (flymake--overlays): Reverse order of invocation for cl-remove-if-not and cl-sort. (flymake-mode-on) (flymake-mode-off): Make obsolete. (flymake-goto-next-error, flymake-goto-prev-error): Fix docstring. (flymake-diagnostic-functions): Clarify keyword arguments in docstring. Maybe squash in that one where I remove many obsoletes
2017-09-29 11:02:36 +01:00
include-dirs)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(setq found t)
;; replace-match is not used here as it fails in
;; XEmacs with 'last match not a buffer' error as
;; check-includes calls replace-in-string
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(flymake-proc--replace-region
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
match-beg match-end
(file-name-nondirectory patched-source-file-name))))
(forward-line 1)))
(when found
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(flymake-proc--save-buffer-in-file patched-master-file-name)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;;+(flymake-log 3 "killing buffer %s"
;; (buffer-name master-file-temp-buffer))
(kill-buffer master-file-temp-buffer))
;;+(flymake-log 3 "check-patch master file %s: %s" master-file-name found)
(when found
(flymake-log 2 "found master file %s" master-file-name))
found))
;;; XXX: remove
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--replace-region (beg end rep)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Replace text in BUFFER in region (BEG END) with REP."
(save-excursion
(goto-char end)
;; Insert before deleting, so as to better preserve markers's positions.
(insert rep)
(delete-region beg end)))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--read-file-to-temp-buffer (file-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Insert contents of FILE-NAME into newly created temp buffer."
Inhibit buffer hooks in temporary buffers Give get-buffer-create an optional argument to inhibit buffer hooks in internal or temporary buffers for efficiency (bug#34765). * etc/NEWS: Announce new parameter of get-buffer-create and generate-new-buffer, and that with-temp-buffer and with-temp-file now inhibit buffer hooks. * doc/lispref/buffers.texi (Buffer Names): Fix typo. (Creating Buffers): Document new parameter of get-buffer-create and generate-new-buffer. (Buffer List, Killing Buffers): Document when buffer hooks are inhibited. (Current Buffer): * doc/lispref/files.texi (Writing to Files): Document that with-temp-buffer and with-temp-file inhibit buffer hooks. * doc/lispref/internals.texi (Buffer Internals): Document inhibit_buffer_hooks flag. Remove stale comment. * doc/misc/gnus-faq.texi (FAQ 5-8): * lisp/simple.el (shell-command-on-region): Fix indentation. * lisp/files.el (kill-buffer-hook): Document when hook is inhibited. (create-file-buffer): * lisp/gnus/gnus-uu.el (gnus-uu-unshar-article): * lisp/international/mule.el (load-with-code-conversion): * lisp/mh-e/mh-xface.el (mh-x-image-url-fetch-image): * lisp/net/imap.el (imap-open): * lisp/net/mailcap.el (mailcap-maybe-eval): * lisp/progmodes/flymake-proc.el (flymake-proc--read-file-to-temp-buffer) (flymake-proc--copy-buffer-to-temp-buffer): Simplify. * lisp/subr.el (generate-new-buffer): Forward new optional argument to inhibit buffer hooks to get-buffer-create. (with-temp-file, with-temp-buffer, with-output-to-string): * lisp/json.el (json-encode-string): Inhibit buffer hooks in buffer used. * src/buffer.c (run_buffer_list_update_hook): New helper function. (Fget_buffer_create): Use it. Add optional argument to set inhibit_buffer_hooks flag instead of comparing the buffer name to Vcode_conversion_workbuf_name. All callers changed. (Fmake_indirect_buffer, Frename_buffer, Fbury_buffer_internal) (record_buffer): Use run_buffer_list_update_hook. (Fkill_buffer): Document when buffer hooks are inhibited. Use run_buffer_list_update_hook. (init_buffer_once): Inhibit buffer hooks in Vprin1_to_string_buffer. (Vkill_buffer_query_functions, Vbuffer_list_update_hook): Document when hooks are inhibited. * src/buffer.h (struct buffer): Update inhibit_buffer_hooks commentary. * src/coding.h (Vcode_conversion_workbuf_name): * src/coding.c (Vcode_conversion_workbuf_name): Make static again since it is no longer needed in src/buffer.c. (code_conversion_restore, code_conversion_save, syms_of_coding): Prefer boolean over integer constants. * src/fileio.c (Finsert_file_contents): Inhibit buffer hooks in " *code-converting-work*" buffer. * src/window.c (Fselect_window): Fix grammar. Mention window-selection-change-functions alongside buffer-list-update-hook. * test/src/buffer-tests.el: Fix requires. (buffer-tests-inhibit-buffer-hooks): New test.
2020-12-19 12:39:45 +00:00
(with-current-buffer (generate-new-buffer
(concat "flymake:" (file-name-nondirectory file-name)))
(insert-file-contents file-name)
(current-buffer)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--copy-buffer-to-temp-buffer (buffer)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Copy contents of BUFFER into newly created temp buffer."
Inhibit buffer hooks in temporary buffers Give get-buffer-create an optional argument to inhibit buffer hooks in internal or temporary buffers for efficiency (bug#34765). * etc/NEWS: Announce new parameter of get-buffer-create and generate-new-buffer, and that with-temp-buffer and with-temp-file now inhibit buffer hooks. * doc/lispref/buffers.texi (Buffer Names): Fix typo. (Creating Buffers): Document new parameter of get-buffer-create and generate-new-buffer. (Buffer List, Killing Buffers): Document when buffer hooks are inhibited. (Current Buffer): * doc/lispref/files.texi (Writing to Files): Document that with-temp-buffer and with-temp-file inhibit buffer hooks. * doc/lispref/internals.texi (Buffer Internals): Document inhibit_buffer_hooks flag. Remove stale comment. * doc/misc/gnus-faq.texi (FAQ 5-8): * lisp/simple.el (shell-command-on-region): Fix indentation. * lisp/files.el (kill-buffer-hook): Document when hook is inhibited. (create-file-buffer): * lisp/gnus/gnus-uu.el (gnus-uu-unshar-article): * lisp/international/mule.el (load-with-code-conversion): * lisp/mh-e/mh-xface.el (mh-x-image-url-fetch-image): * lisp/net/imap.el (imap-open): * lisp/net/mailcap.el (mailcap-maybe-eval): * lisp/progmodes/flymake-proc.el (flymake-proc--read-file-to-temp-buffer) (flymake-proc--copy-buffer-to-temp-buffer): Simplify. * lisp/subr.el (generate-new-buffer): Forward new optional argument to inhibit buffer hooks to get-buffer-create. (with-temp-file, with-temp-buffer, with-output-to-string): * lisp/json.el (json-encode-string): Inhibit buffer hooks in buffer used. * src/buffer.c (run_buffer_list_update_hook): New helper function. (Fget_buffer_create): Use it. Add optional argument to set inhibit_buffer_hooks flag instead of comparing the buffer name to Vcode_conversion_workbuf_name. All callers changed. (Fmake_indirect_buffer, Frename_buffer, Fbury_buffer_internal) (record_buffer): Use run_buffer_list_update_hook. (Fkill_buffer): Document when buffer hooks are inhibited. Use run_buffer_list_update_hook. (init_buffer_once): Inhibit buffer hooks in Vprin1_to_string_buffer. (Vkill_buffer_query_functions, Vbuffer_list_update_hook): Document when hooks are inhibited. * src/buffer.h (struct buffer): Update inhibit_buffer_hooks commentary. * src/coding.h (Vcode_conversion_workbuf_name): * src/coding.c (Vcode_conversion_workbuf_name): Make static again since it is no longer needed in src/buffer.c. (code_conversion_restore, code_conversion_save, syms_of_coding): Prefer boolean over integer constants. * src/fileio.c (Finsert_file_contents): Inhibit buffer hooks in " *code-converting-work*" buffer. * src/window.c (Fselect_window): Fix grammar. Mention window-selection-change-functions alongside buffer-list-update-hook. * test/src/buffer-tests.el: Fix requires. (buffer-tests-inhibit-buffer-hooks): New test.
2020-12-19 12:39:45 +00:00
(with-current-buffer (generate-new-buffer
(concat "flymake:" (buffer-name buffer)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(insert-buffer-substring buffer)
(current-buffer)))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--check-include (source-file-name inc-name include-dirs)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Check if SOURCE-FILE-NAME can be found in include path.
lisp/*.el, src/*.c: Doc fixes related to returning t vs non-nil * lisp/progmodes/flymake-proc.el (flymake-proc--find-buffer-for-file): Doc fix; return value is a buffer, not t. * lisp/progmodes/ebrowse.el (ebrowse-member-display-p): Doc fix; return value is the MEMBER argument, not nil. * lisp/files.el (hack-one-local-variable-eval-safep): * lisp/play/doctor.el (doctor-nounp, doctor-pronounp): * lisp/progmodes/flymake-proc.el (flymake-proc--check-include): * lisp/progmodes/js.el (js--broken-arrow-terminates-line-p): Doc fix; a non-nil return value is not always t. * lisp/image.el (image-type-available-p): * lisp/simple.el (region-active-p): * lisp/window.el (frame-root-window-p): * src/buffer.c (Fbuffer_live_p): * src/image.c (Finit_image_library): * src/window.c (Fwindow_minibuffer_p): Doc fix; a non-nil return value is always t. * doc/lispref/minibuf.texi (Minibuffer Windows): Doc fix.
2019-10-17 02:45:06 +02:00
Return non-nil if it can be found via include path using INC-NAME."
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(if (file-name-absolute-p inc-name)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(flymake-proc--same-files source-file-name inc-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(while (and include-dirs
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(not (flymake-proc--same-files
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
source-file-name
(concat (file-name-directory source-file-name)
"/" (car include-dirs)
"/" inc-name))))
(setq include-dirs (cdr include-dirs)))
include-dirs))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--find-buffer-for-file (file-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Check if there exists a buffer visiting FILE-NAME.
lisp/*.el, src/*.c: Doc fixes related to returning t vs non-nil * lisp/progmodes/flymake-proc.el (flymake-proc--find-buffer-for-file): Doc fix; return value is a buffer, not t. * lisp/progmodes/ebrowse.el (ebrowse-member-display-p): Doc fix; return value is the MEMBER argument, not nil. * lisp/files.el (hack-one-local-variable-eval-safep): * lisp/play/doctor.el (doctor-nounp, doctor-pronounp): * lisp/progmodes/flymake-proc.el (flymake-proc--check-include): * lisp/progmodes/js.el (js--broken-arrow-terminates-line-p): Doc fix; a non-nil return value is not always t. * lisp/image.el (image-type-available-p): * lisp/simple.el (region-active-p): * lisp/window.el (frame-root-window-p): * src/buffer.c (Fbuffer_live_p): * src/image.c (Finit_image_library): * src/window.c (Fwindow_minibuffer_p): Doc fix; a non-nil return value is always t. * doc/lispref/minibuf.texi (Minibuffer Windows): Doc fix.
2019-10-17 02:45:06 +02:00
Return the buffer if it exists, nil if not."
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(let ((buffer-name (get-file-buffer file-name)))
(if buffer-name
(get-buffer buffer-name))))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--create-master-file (source-file-name patched-source-file-name get-incl-dirs-f create-temp-f masks include-regexp)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Save SOURCE-FILE-NAME with a different name.
Find master file, patch and save it."
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(let* ((possible-master-files (flymake-proc--find-possible-master-files source-file-name flymake-proc-master-file-dirs masks))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(master-file-count (length possible-master-files))
(idx 0)
(temp-buffer nil)
(master-file-name nil)
(patched-master-file-name nil)
(found nil))
(while (and (not found) (< idx master-file-count))
(setq master-file-name (nth idx possible-master-files))
(setq patched-master-file-name (funcall create-temp-f master-file-name "flymake_master"))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(if (flymake-proc--find-buffer-for-file master-file-name)
(setq temp-buffer (flymake-proc--copy-buffer-to-temp-buffer (flymake-proc--find-buffer-for-file master-file-name)))
(setq temp-buffer (flymake-proc--read-file-to-temp-buffer master-file-name)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(setq found
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(flymake-proc--check-patch-master-file-buffer
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
temp-buffer
master-file-name
patched-master-file-name
source-file-name
patched-source-file-name
(funcall get-incl-dirs-f (file-name-directory master-file-name))
include-regexp))
(setq idx (1+ idx)))
(if found
(list master-file-name patched-master-file-name)
(progn
(flymake-log 3 "none of %d master file(s) checked includes %s" master-file-count
(file-name-nondirectory source-file-name))
nil))))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--save-buffer-in-file (file-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Save the entire buffer contents into file FILE-NAME.
Create parent directories as needed."
(make-directory (file-name-directory file-name) 1)
(write-region nil nil file-name nil 566)
(flymake-log 3 "saved buffer %s in file %s" (buffer-name) file-name))
Completely rewrite Flymake's subprocess output processing Instead of parsing and matching regexps line-by-line, insert subprocess output in a separate buffer and parse using `search-forward-regexp'. This eventually enables multi-line error patterns and simplifies code all around. Store per-check information in the subprocess using `process-get' and `process-put'. Treat error messages, warnings, etc. more generically as "diagnostics". Create these objects as soon as possible, reusing existing `flymake-ler' structure. Fix some whitespace. * lisp/progmodes/flymake.el (cl-lib): Require also when loading. (flymake--fix-line-numbers): Rename from flymake-fix-line-numbers. Simplify. (flymake-report): Call flymake--fix-line-numbers. Rearrange plain diagnostics list into alist format expected by flymake-highlight-err-lines. * lisp/progmodes/flymake-proc.el (flymake-process-filter): Insert process output and parse in dedicated output buffer. (flymake-proc--diagnostics-for-pattern): New helper function. (flymake-process-sentinel): Call flymake-post-syntax-check with collected diagnostics. Kill output buffer. (flymake-post-syntax-check): Receive diagnostics as third argument. (flymake-parse-output-and-residual, flymake-new-err-info) (flymake-parse-residual, flymake-parse-err-lines) (flymake-split-output, flymake-proc-parse-line) (flymake-output-residual): Delete. (flymake-start-syntax-check-process): Use make-process. Setup dedicated an output buffer
2017-08-23 02:23:41 +01:00
(defun flymake-proc--diagnostics-for-pattern (proc pattern)
Flymake highlights GCC info/notes as detected by flymake-proc.el * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Rewrite (using cl-loop) to honour more sophisticated flymake-proc-diagnostic-type-pred. (flymake-warning-re): Is now an obsolete alias for flymake-proc-diagnostic-type-pred. (flymake-proc-diagnostic-type-pred): Rename and augment from flymake-proc-warning-predicate. (flymake-proc-warning-predicate): Delete. * lisp/progmodes/flymake.el (flymake-note): New face. (flymake-diagnostic-types-alist): Simplify. (flymake-note): New overlay category. (flymake--lookup-type-property): Only lookup single keys, not lists. (flymake--diag-errorp): Rewrite. (flymake--highlight-line): Use flymake--lookup-type-property. * test/lisp/progmodes/flymake-tests.el (different-diagnostic-types): Rename from errors-and-warnings. Check notes. (flymake-tests--call-with-fixture): Use flymake-proc-diagnostic-type-pred.
2017-09-21 14:44:13 +01:00
(cl-flet ((guess-type
(pred message)
(cond ((null message)
:error)
((stringp pred)
(if (string-match pred message)
:warning
:error))
((functionp pred)
(let ((probe (funcall pred message)))
Obsolete Flymake's flymake-diagnostic-types-alist That varaiable was an association between symbols and properties, effecively duplicating symbol's property lists. It is simpler to just put properties on symbols. Backward compatibility to the old variable has been kept. * doc/misc/flymake.texi (Flymake error types): Don't mention flymake-diagnostic-types-alist. (Flymake error types): Rework section. (Backend functions): Refill a paragraph. (Flymake utility functions): Don't mention flymake-diagnostic-types-alist. (Proc customization variables): Don't mention flymake-diagnostic-types-alist. * etc/NEWS: Mention obsoletion of flymake-diagnostic-types-alist. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Don't use flymake-diagnostic-types-alist. * lisp/progmodes/flymake.el: Rewrite commentary. (flymake-make-diagnostic, flymake-mode, flymake-goto-next-error) (flymake-goto-prev-error): Don't mention flymake-diagnostic-types-alist in docstring. (flymake-diagnostic-types-alist): Make obsolete. (:error, :warning, :note): Put flymake-category in these symbols. (flymake-error, flymake-warning, flymake-note): Put `flymake-bitmap', not `bitmap' in these symbols. (flymake--lookup-type-property, flymake--highlight-line): Rewrite. Honor flymake-diagnostic-types-alist for backward compatibility. * lisp/progmodes/python.el (python-flymake-msg-alist): Don't mention flymake-diagnostic-types-alist.
2018-06-05 15:13:02 +01:00
(cond ((and (symbolp probe)
(get probe 'flymake-category))
Flymake highlights GCC info/notes as detected by flymake-proc.el * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Rewrite (using cl-loop) to honour more sophisticated flymake-proc-diagnostic-type-pred. (flymake-warning-re): Is now an obsolete alias for flymake-proc-diagnostic-type-pred. (flymake-proc-diagnostic-type-pred): Rename and augment from flymake-proc-warning-predicate. (flymake-proc-warning-predicate): Delete. * lisp/progmodes/flymake.el (flymake-note): New face. (flymake-diagnostic-types-alist): Simplify. (flymake-note): New overlay category. (flymake--lookup-type-property): Only lookup single keys, not lists. (flymake--diag-errorp): Rewrite. (flymake--highlight-line): Use flymake--lookup-type-property. * test/lisp/progmodes/flymake-tests.el (different-diagnostic-types): Rename from errors-and-warnings. Check notes. (flymake-tests--call-with-fixture): Use flymake-proc-diagnostic-type-pred.
2017-09-21 14:44:13 +01:00
probe)
(probe
:warning)
(t
:error)))))))
Flymake's flymake-proc.el backend slightly easier to debug Misc cleanup in flymake-proc.el Improve description of what this file contains. Better name for the backend function. Fix the case where it is run interactively. Keep the output buffer alive iff the external process panics. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Rename from flymake-proc-start-syntax-check. Allow running interactively. (flymake-start-syntax-check): Obsolete alias for flymake-proc-legacy-flymake. (flymake-proc-start-syntax-check): Delete. (flymake-diagnostic-functions): Include flymake-proc-legacy-flymake (flymake-proc--process-sentinel): Keep output buffer alive. Clarify with comments. (flymake-proc--diagnostics-for-pattern) (flymake-proc--process-sentinel) (flymake-proc--safe-delete-directory) (flymake-proc--start-syntax-check-process): Use condition-case-unless-debug.
2017-09-19 14:56:59 +01:00
(condition-case-unless-debug err
Flymake highlights GCC info/notes as detected by flymake-proc.el * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Rewrite (using cl-loop) to honour more sophisticated flymake-proc-diagnostic-type-pred. (flymake-warning-re): Is now an obsolete alias for flymake-proc-diagnostic-type-pred. (flymake-proc-diagnostic-type-pred): Rename and augment from flymake-proc-warning-predicate. (flymake-proc-warning-predicate): Delete. * lisp/progmodes/flymake.el (flymake-note): New face. (flymake-diagnostic-types-alist): Simplify. (flymake-note): New overlay category. (flymake--lookup-type-property): Only lookup single keys, not lists. (flymake--diag-errorp): Rewrite. (flymake--highlight-line): Use flymake--lookup-type-property. * test/lisp/progmodes/flymake-tests.el (different-diagnostic-types): Rename from errors-and-warnings. Check notes. (flymake-tests--call-with-fixture): Use flymake-proc-diagnostic-type-pred.
2017-09-21 14:44:13 +01:00
(cl-loop
with (regexp file-idx line-idx col-idx message-idx) = pattern
Fix three Flymake bugs when checking C header files The first of these problems is longstanding: if an error-less B.h is included from error-ridden A.h, flymake's legacy parser will panic (and disable itself) since it sees a non-zero exit for a clean file. To fix this, recommend returning 'true' in the documentation for the check-syntax target. Another problem was introduced by the parser rewrite. For error patterns spanning more than one line, point may be left in the middle of a line and thus render other patterns useless. Those patterns were written for the old line-by-line parser. To make them useful again, move to the beginning of line in those situations. The third problem was also longstanding and happened on newer GCC's: The "In file included from" prefix confused flymake-proc-get-real-file-name. Fix this. Also updated flymake--diag-region to fallback to highlighting a full line less often. Add automatic tests to check this. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Fix bug when patterns accidentally spans more than one line. Don't create diagnostics without error messages. (flymake-proc-real-file-name-considering-includes): New helper. (flymake-proc-allowed-file-name-masks): Use it. * lisp/progmodes/flymake.el (flymake-diag-region): Make COL argument explicitly optional. Only fall back to full line in extreme cases. * test/lisp/progmodes/flymake-tests.el (included-c-header-files): New test. (different-diagnostic-types): Update. * test/lisp/progmodes/flymake-resources/Makefile (check-syntax): Always return success (0) error code. (CC_OPTS): Add -Wextra * test/lisp/progmodes/flymake-resources/errors-and-warnings.c (main): Rewrite comments. * test/lisp/progmodes/flymake-resources/errors-and-warnings.c: Include some dummy header files. * test/lisp/progmodes/flymake-resources/no-problems.h: New file. * test/lisp/progmodes/flymake-resources/some-problems.h: New file. * doc/misc/flymake.texi (Example---Configuring a tool called via make): Recommend adding "|| true" to the check-syntax target.
2017-09-28 12:06:56 +01:00
while (and
(search-forward-regexp regexp nil t)
;; If the preceding search spanned more than one line,
;; move to the start of the line we ended up in. This
;; preserves the usefulness of the patterns in
;; `flymake-proc-err-line-patterns', which were
;; written primarily for flymake's original
;; line-by-line parsing and thus never spanned
;; multiple lines.
(if (/= (line-number-at-pos (match-beginning 0))
(line-number-at-pos))
(goto-char (line-beginning-position))
t))
Flymake highlights GCC info/notes as detected by flymake-proc.el * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Rewrite (using cl-loop) to honour more sophisticated flymake-proc-diagnostic-type-pred. (flymake-warning-re): Is now an obsolete alias for flymake-proc-diagnostic-type-pred. (flymake-proc-diagnostic-type-pred): Rename and augment from flymake-proc-warning-predicate. (flymake-proc-warning-predicate): Delete. * lisp/progmodes/flymake.el (flymake-note): New face. (flymake-diagnostic-types-alist): Simplify. (flymake-note): New overlay category. (flymake--lookup-type-property): Only lookup single keys, not lists. (flymake--diag-errorp): Rewrite. (flymake--highlight-line): Use flymake--lookup-type-property. * test/lisp/progmodes/flymake-tests.el (different-diagnostic-types): Rename from errors-and-warnings. Check notes. (flymake-tests--call-with-fixture): Use flymake-proc-diagnostic-type-pred.
2017-09-21 14:44:13 +01:00
for fname = (and file-idx (match-string file-idx))
for message = (and message-idx (match-string message-idx))
for line-string = (and line-idx (match-string line-idx))
Fix three Flymake bugs when checking C header files The first of these problems is longstanding: if an error-less B.h is included from error-ridden A.h, flymake's legacy parser will panic (and disable itself) since it sees a non-zero exit for a clean file. To fix this, recommend returning 'true' in the documentation for the check-syntax target. Another problem was introduced by the parser rewrite. For error patterns spanning more than one line, point may be left in the middle of a line and thus render other patterns useless. Those patterns were written for the old line-by-line parser. To make them useful again, move to the beginning of line in those situations. The third problem was also longstanding and happened on newer GCC's: The "In file included from" prefix confused flymake-proc-get-real-file-name. Fix this. Also updated flymake--diag-region to fallback to highlighting a full line less often. Add automatic tests to check this. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Fix bug when patterns accidentally spans more than one line. Don't create diagnostics without error messages. (flymake-proc-real-file-name-considering-includes): New helper. (flymake-proc-allowed-file-name-masks): Use it. * lisp/progmodes/flymake.el (flymake-diag-region): Make COL argument explicitly optional. Only fall back to full line in extreme cases. * test/lisp/progmodes/flymake-tests.el (included-c-header-files): New test. (different-diagnostic-types): Update. * test/lisp/progmodes/flymake-resources/Makefile (check-syntax): Always return success (0) error code. (CC_OPTS): Add -Wextra * test/lisp/progmodes/flymake-resources/errors-and-warnings.c (main): Rewrite comments. * test/lisp/progmodes/flymake-resources/errors-and-warnings.c: Include some dummy header files. * test/lisp/progmodes/flymake-resources/no-problems.h: New file. * test/lisp/progmodes/flymake-resources/some-problems.h: New file. * doc/misc/flymake.texi (Example---Configuring a tool called via make): Recommend adding "|| true" to the check-syntax target.
2017-09-28 12:06:56 +01:00
for line-number = (or (and line-string
(string-to-number line-string))
1)
Flymake highlights GCC info/notes as detected by flymake-proc.el * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Rewrite (using cl-loop) to honour more sophisticated flymake-proc-diagnostic-type-pred. (flymake-warning-re): Is now an obsolete alias for flymake-proc-diagnostic-type-pred. (flymake-proc-diagnostic-type-pred): Rename and augment from flymake-proc-warning-predicate. (flymake-proc-warning-predicate): Delete. * lisp/progmodes/flymake.el (flymake-note): New face. (flymake-diagnostic-types-alist): Simplify. (flymake-note): New overlay category. (flymake--lookup-type-property): Only lookup single keys, not lists. (flymake--diag-errorp): Rewrite. (flymake--highlight-line): Use flymake--lookup-type-property. * test/lisp/progmodes/flymake-tests.el (different-diagnostic-types): Rename from errors-and-warnings. Check notes. (flymake-tests--call-with-fixture): Use flymake-proc-diagnostic-type-pred.
2017-09-21 14:44:13 +01:00
for col-string = (and col-idx (match-string col-idx))
for col-number = (and col-string
(string-to-number col-string))
More Flymake cleanup before advancing to backend redesign Diagnostics are reported for buffers, not necessarily files. It’s the backend’s responsibility to compute the buffer where the diagnostic is applicable. For now, this has to match the buffer where flymake-mode is active and which is at the origin of the backend call. flymake.el knows nothing about line/column diagnostics (except for backward-compatible flymake-ler-make-ler, which must yet be tested). It’s also the backend’s reponsibility to compute a BEG and END positions for the diagnostic in the relevant buffer. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Convert LINE/COL to region here. Check file buffer here. (flymake-proc--process-sentinel): Don’t kill output buffer if high enough log level. * lisp/progmodes/flymake.el (flymake-diag-region): Make this a utility function. (flymake--highlight-line): Diagnostic has region now. (flymake-popup-current-error-menu): Don’t add file and line numbers to already this silly menu. (flymake--fix-line-numbers): Remove. (flymake-report): No need to fix diagnostics here.
2017-09-23 18:15:40 +01:00
for full-file = (with-current-buffer (process-buffer proc)
(and fname
(funcall
(flymake-proc--get-real-file-name-function
fname)
fname)))
for buffer = (and full-file
(find-buffer-visiting full-file))
Fix three Flymake bugs when checking C header files The first of these problems is longstanding: if an error-less B.h is included from error-ridden A.h, flymake's legacy parser will panic (and disable itself) since it sees a non-zero exit for a clean file. To fix this, recommend returning 'true' in the documentation for the check-syntax target. Another problem was introduced by the parser rewrite. For error patterns spanning more than one line, point may be left in the middle of a line and thus render other patterns useless. Those patterns were written for the old line-by-line parser. To make them useful again, move to the beginning of line in those situations. The third problem was also longstanding and happened on newer GCC's: The "In file included from" prefix confused flymake-proc-get-real-file-name. Fix this. Also updated flymake--diag-region to fallback to highlighting a full line less often. Add automatic tests to check this. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Fix bug when patterns accidentally spans more than one line. Don't create diagnostics without error messages. (flymake-proc-real-file-name-considering-includes): New helper. (flymake-proc-allowed-file-name-masks): Use it. * lisp/progmodes/flymake.el (flymake-diag-region): Make COL argument explicitly optional. Only fall back to full line in extreme cases. * test/lisp/progmodes/flymake-tests.el (included-c-header-files): New test. (different-diagnostic-types): Update. * test/lisp/progmodes/flymake-resources/Makefile (check-syntax): Always return success (0) error code. (CC_OPTS): Add -Wextra * test/lisp/progmodes/flymake-resources/errors-and-warnings.c (main): Rewrite comments. * test/lisp/progmodes/flymake-resources/errors-and-warnings.c: Include some dummy header files. * test/lisp/progmodes/flymake-resources/no-problems.h: New file. * test/lisp/progmodes/flymake-resources/some-problems.h: New file. * doc/misc/flymake.texi (Example---Configuring a tool called via make): Recommend adding "|| true" to the check-syntax target.
2017-09-28 12:06:56 +01:00
if (and (eq buffer (process-buffer proc)) message)
Misc. minor adjustments to Flymake - Add a half-decent minor-mode menu; - Fix "waiting for backends" mode line message; - Adjust the flymake-diag-region API; - Autoload the flymake-log macro; - Auto-disable the legacy backend in more situations; - Fix a couple of warnings in legacy backend. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Use new flymake-diag-region. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Do error when no buffer-file-name or not writable. (flymake-proc-legacy-flymake) (flymake-proc-simple-cleanup): Don't reference flymake-last-change-time * lisp/progmodes/flymake.el (flymake-diag-region): Autoload. Take buffer as first argument. * lisp/progmodes/flymake.el (flymake-switch-to-log-buffer): New command. (flymake-menu): Add a simple menu. (flymake--mode-line-format): Use menu. Fix message. Switch to log buffer when clicking exceptional warnings.
2017-10-05 02:42:01 +01:00
collect (pcase-let ((`(,beg . ,end)
(flymake-diag-region buffer line-number col-number)))
(flymake-make-diagnostic
buffer beg end
(with-current-buffer buffer
(guess-type flymake-proc-diagnostic-type-pred message))
message))
More Flymake cleanup before advancing to backend redesign Diagnostics are reported for buffers, not necessarily files. It’s the backend’s responsibility to compute the buffer where the diagnostic is applicable. For now, this has to match the buffer where flymake-mode is active and which is at the origin of the backend call. flymake.el knows nothing about line/column diagnostics (except for backward-compatible flymake-ler-make-ler, which must yet be tested). It’s also the backend’s reponsibility to compute a BEG and END positions for the diagnostic in the relevant buffer. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Convert LINE/COL to region here. Check file buffer here. (flymake-proc--process-sentinel): Don’t kill output buffer if high enough log level. * lisp/progmodes/flymake.el (flymake-diag-region): Make this a utility function. (flymake--highlight-line): Diagnostic has region now. (flymake-popup-current-error-menu): Don’t add file and line numbers to already this silly menu. (flymake--fix-line-numbers): Remove. (flymake-report): No need to fix diagnostics here.
2017-09-23 18:15:40 +01:00
else
Simplify Flymake logging and erroring Use display-warning and a dedicated *Flymake log* buffer. To ease readability, flymake log messages are now prefixed with a common prefix and the buffer that originated them. Some situations of over-zealous logging are fixed. Use byte-compiler info, if available, to determine whence the flymake-related log message is coming. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Improve log message. (flymake-proc--panic): Always flymake-log an error (flymake-proc--safe-delete-file) (flymake-proc--safe-delete-directory): Downgrade warning (flymake-proc-start-syntax-check): Simplify slightly. (flymake-proc--start-syntax-check-process): Simplify. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): No need to warn twice. * lisp/progmodes/flymake.el (flymake-log): Convert to macro. (flymake--log-1): New helper. (flymake-log-level): Deprecate. (flymake-error): New helper. (flymake-ler-make-ler, flymake--handle-report, flymake-mode): Use flymake-error. (flymake-on-timer-event) (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake-start, flymake-mode-on) (flymake-mode-off, flymake-after-change-function) (flymake-after-save-hook, flymake-find-file-hook): Adjust flymake-log calls. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Only log errors.
2017-09-26 01:35:43 +01:00
do (flymake-log 2 "Reference to file %s is out of scope" fname))
Flymake highlights GCC info/notes as detected by flymake-proc.el * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Rewrite (using cl-loop) to honour more sophisticated flymake-proc-diagnostic-type-pred. (flymake-warning-re): Is now an obsolete alias for flymake-proc-diagnostic-type-pred. (flymake-proc-diagnostic-type-pred): Rename and augment from flymake-proc-warning-predicate. (flymake-proc-warning-predicate): Delete. * lisp/progmodes/flymake.el (flymake-note): New face. (flymake-diagnostic-types-alist): Simplify. (flymake-note): New overlay category. (flymake--lookup-type-property): Only lookup single keys, not lists. (flymake--diag-errorp): Rewrite. (flymake--highlight-line): Use flymake--lookup-type-property. * test/lisp/progmodes/flymake-tests.el (different-diagnostic-types): Rename from errors-and-warnings. Check notes. (flymake-tests--call-with-fixture): Use flymake-proc-diagnostic-type-pred.
2017-09-21 14:44:13 +01:00
(error
(flymake-log 1 "Error parsing process output for pattern %s: %s"
pattern err)
nil))))
Completely rewrite Flymake's subprocess output processing Instead of parsing and matching regexps line-by-line, insert subprocess output in a separate buffer and parse using `search-forward-regexp'. This eventually enables multi-line error patterns and simplifies code all around. Store per-check information in the subprocess using `process-get' and `process-put'. Treat error messages, warnings, etc. more generically as "diagnostics". Create these objects as soon as possible, reusing existing `flymake-ler' structure. Fix some whitespace. * lisp/progmodes/flymake.el (cl-lib): Require also when loading. (flymake--fix-line-numbers): Rename from flymake-fix-line-numbers. Simplify. (flymake-report): Call flymake--fix-line-numbers. Rearrange plain diagnostics list into alist format expected by flymake-highlight-err-lines. * lisp/progmodes/flymake-proc.el (flymake-process-filter): Insert process output and parse in dedicated output buffer. (flymake-proc--diagnostics-for-pattern): New helper function. (flymake-process-sentinel): Call flymake-post-syntax-check with collected diagnostics. Kill output buffer. (flymake-post-syntax-check): Receive diagnostics as third argument. (flymake-parse-output-and-residual, flymake-new-err-info) (flymake-parse-residual, flymake-parse-err-lines) (flymake-split-output, flymake-proc-parse-line) (flymake-output-residual): Delete. (flymake-start-syntax-check-process): Use make-process. Setup dedicated an output buffer
2017-08-23 02:23:41 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--process-filter (proc string)
Completely rewrite Flymake's subprocess output processing Instead of parsing and matching regexps line-by-line, insert subprocess output in a separate buffer and parse using `search-forward-regexp'. This eventually enables multi-line error patterns and simplifies code all around. Store per-check information in the subprocess using `process-get' and `process-put'. Treat error messages, warnings, etc. more generically as "diagnostics". Create these objects as soon as possible, reusing existing `flymake-ler' structure. Fix some whitespace. * lisp/progmodes/flymake.el (cl-lib): Require also when loading. (flymake--fix-line-numbers): Rename from flymake-fix-line-numbers. Simplify. (flymake-report): Call flymake--fix-line-numbers. Rearrange plain diagnostics list into alist format expected by flymake-highlight-err-lines. * lisp/progmodes/flymake-proc.el (flymake-process-filter): Insert process output and parse in dedicated output buffer. (flymake-proc--diagnostics-for-pattern): New helper function. (flymake-process-sentinel): Call flymake-post-syntax-check with collected diagnostics. Kill output buffer. (flymake-post-syntax-check): Receive diagnostics as third argument. (flymake-parse-output-and-residual, flymake-new-err-info) (flymake-parse-residual, flymake-parse-err-lines) (flymake-split-output, flymake-proc-parse-line) (flymake-output-residual): Delete. (flymake-start-syntax-check-process): Use make-process. Setup dedicated an output buffer
2017-08-23 02:23:41 +01:00
"Parse STRING and collect diagnostics info."
(flymake-log 3 "received %d byte(s) of output from process %d"
(length string) (process-id proc))
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(let ((output-buffer (process-get proc 'flymake-proc--output-buffer)))
Completely rewrite Flymake's subprocess output processing Instead of parsing and matching regexps line-by-line, insert subprocess output in a separate buffer and parse using `search-forward-regexp'. This eventually enables multi-line error patterns and simplifies code all around. Store per-check information in the subprocess using `process-get' and `process-put'. Treat error messages, warnings, etc. more generically as "diagnostics". Create these objects as soon as possible, reusing existing `flymake-ler' structure. Fix some whitespace. * lisp/progmodes/flymake.el (cl-lib): Require also when loading. (flymake--fix-line-numbers): Rename from flymake-fix-line-numbers. Simplify. (flymake-report): Call flymake--fix-line-numbers. Rearrange plain diagnostics list into alist format expected by flymake-highlight-err-lines. * lisp/progmodes/flymake-proc.el (flymake-process-filter): Insert process output and parse in dedicated output buffer. (flymake-proc--diagnostics-for-pattern): New helper function. (flymake-process-sentinel): Call flymake-post-syntax-check with collected diagnostics. Kill output buffer. (flymake-post-syntax-check): Receive diagnostics as third argument. (flymake-parse-output-and-residual, flymake-new-err-info) (flymake-parse-residual, flymake-parse-err-lines) (flymake-split-output, flymake-proc-parse-line) (flymake-output-residual): Delete. (flymake-start-syntax-check-process): Use make-process. Setup dedicated an output buffer
2017-08-23 02:23:41 +01:00
(when (and (buffer-live-p (process-buffer proc))
output-buffer)
(with-current-buffer output-buffer
(let ((moving (= (point) (process-mark proc)))
(inhibit-read-only t)
(unprocessed-mark
(or (process-get proc 'flymake-proc--unprocessed-mark)
(set-marker (make-marker) (point-min)))))
(save-excursion
;; Insert the text, advancing the process marker.
(goto-char (process-mark proc))
(insert string)
(set-marker (process-mark proc) (point)))
(if moving (goto-char (process-mark proc)))
;; check for new diagnostics
;;
(save-excursion
(goto-char unprocessed-mark)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(dolist (pattern flymake-proc-err-line-patterns)
Completely rewrite Flymake's subprocess output processing Instead of parsing and matching regexps line-by-line, insert subprocess output in a separate buffer and parse using `search-forward-regexp'. This eventually enables multi-line error patterns and simplifies code all around. Store per-check information in the subprocess using `process-get' and `process-put'. Treat error messages, warnings, etc. more generically as "diagnostics". Create these objects as soon as possible, reusing existing `flymake-ler' structure. Fix some whitespace. * lisp/progmodes/flymake.el (cl-lib): Require also when loading. (flymake--fix-line-numbers): Rename from flymake-fix-line-numbers. Simplify. (flymake-report): Call flymake--fix-line-numbers. Rearrange plain diagnostics list into alist format expected by flymake-highlight-err-lines. * lisp/progmodes/flymake-proc.el (flymake-process-filter): Insert process output and parse in dedicated output buffer. (flymake-proc--diagnostics-for-pattern): New helper function. (flymake-process-sentinel): Call flymake-post-syntax-check with collected diagnostics. Kill output buffer. (flymake-post-syntax-check): Receive diagnostics as third argument. (flymake-parse-output-and-residual, flymake-new-err-info) (flymake-parse-residual, flymake-parse-err-lines) (flymake-split-output, flymake-proc-parse-line) (flymake-output-residual): Delete. (flymake-start-syntax-check-process): Use make-process. Setup dedicated an output buffer
2017-08-23 02:23:41 +01:00
(let ((new (flymake-proc--diagnostics-for-pattern proc pattern)))
(process-put
proc
'flymake-proc--collected-diagnostics
(append new
(process-get proc
'flymake-proc--collected-diagnostics)))))
(process-put proc 'flymake-proc--unprocessed-mark
(point-marker))))))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
(defun flymake-proc--process-sentinel (proc _event)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Sentinel for syntax check buffers."
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(let (debug
(pid (process-id proc))
(source-buffer (process-buffer proc)))
(unwind-protect
(when (buffer-live-p source-buffer)
(with-current-buffer source-buffer
(cond ((process-get proc 'flymake-proc--obsolete)
(flymake-log 3 "proc %s considered obsolete"
pid))
((process-get proc 'flymake-proc--interrupted)
(flymake-log 3 "proc %s interrupted by user"
pid))
((not (process-live-p proc))
(let* ((exit-status (process-exit-status proc))
(command (process-command proc))
(diagnostics (process-get
proc
'flymake-proc--collected-diagnostics)))
(flymake-log 2 "process %d exited with code %d"
pid exit-status)
(cond
((equal 0 exit-status)
(funcall flymake-proc--report-fn diagnostics
:explanation (format "a gift from %s" (process-id proc))
))
(diagnostics
;; non-zero exit but some diagnostics is quite
;; normal...
(funcall flymake-proc--report-fn diagnostics
:explanation (format "a gift from %s" (process-id proc))))
((null diagnostics)
;; ...but no diagnostics is strange, so panic.
(setq debug debug-on-error)
(flymake-proc--panic
:configuration-error
(format "Command %s errored, but no diagnostics"
command)))))))))
(let ((output-buffer (process-get proc 'flymake-proc--output-buffer)))
(cond (debug
(flymake-log 3 "Output buffer %s kept alive for debugging"
output-buffer))
(t
(when (buffer-live-p source-buffer)
(with-current-buffer source-buffer
(let ((cleanup-f (flymake-proc--get-cleanup-function
(buffer-file-name))))
(flymake-log 3 "cleaning up using %s" cleanup-f)
Fix flymake-proc temporary file deletion bug * list/progmodes/flymake-proc.el (flymake-proc-create-temp-inplace): Include a time string part (hour + minute + second + nanosecond) in the temporary name to make it unique enough. (flymake-proc-legacy-flymake): Store temporary file names in the process for usage in the sentinel. (flymake-proc--process-sentinel): Bind values of temporary file names dynamically to values stored in the process so that the cleanup function will delete the correct temporary file(s). Fixes bug#31981.
2019-08-28 21:00:00 +02:00
;; Make cleanup-f see the temporary file names
;; created by its corresponding init function
;; (bug#31981).
(let ((flymake-proc--temp-source-file-name
(process-get proc 'flymake-proc--temp-source-file-name))
(flymake-proc--temp-master-file-name
(process-get proc 'flymake-proc--temp-master-file-name)))
(funcall cleanup-f)))))
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(kill-buffer output-buffer)))))))
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
(defun flymake-proc--panic (problem explanation)
Capitalize "Flymake" in docstrings and comments * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-setup-backends): Capitalize "Flymake" * lisp/progmodes/flymake-proc.el: (flymake-proc-reformat-err-line-patterns-from-compile-el) (flymake-proc--panic, flymake-proc-legacy-flymake) (flymake-start-syntax-check, flymake-proc-compile) (define-obsolete-variable-alias): Capitalize "Flymake" * lisp/progmodes/flymake.el (flymake-fringe-indicator-position) (flymake-make-diagnostic, flymake-delete-own-overlays) (flymake-diagnostic-functions) (flymake-diagnostic-types-alist, flymake-is-running) (flymake-make-report-fn, flymake-mode-on, flymake-mode-off) (flymake-goto-next-error, flymake-goto-prev-error): Capitalize "Flymake"
2017-09-30 18:04:45 +01:00
"Tell Flymake UI about a fatal PROBLEM with this backend.
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
May only be called in a dynamic environment where
Fix typos in Flymake documentation * doc/misc/flymake.texi (Syntax check statuses) (Adding support for a new syntax check tool) (Implementation overview, Locating the buildfile): Fix typos. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn) (flymake-proc--find-possible-master-files):Fix typos. (flymake-proc--panic) (flymake-proc-legacy-flymake): Fix function reference in doc. * lisp/progmodes/flymake.el (flymake-error) (flymake-diagnostic-functions): Fix typos. (flymake-diagnostic-types-alist): Rephrase and fix typos. (flymake--backend-state): Fix typos and rephrase. (flymake--handle-report): Delete empty line. (flymake--disable-backend) (flymake--run-backend): Fix typos. (flymake-goto-next-error, flymake-goto-prev-error): Rephrase.
2017-10-06 14:08:49 +01:00
`flymake-proc--report-fn' is bound."
Don't log "emergencies" in the Flymake legacy backend * lisp/progmodes/flymake-proc.el (flymake-proc--panic) (flymake-proc-legacy-flymake): Don't log "emergencies"
2017-10-10 12:30:42 +01:00
(flymake-log 1 "%s: %s" problem explanation)
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
(if (and (boundp 'flymake-proc--report-fn)
flymake-proc--report-fn)
(funcall flymake-proc--report-fn :panic
:explanation (format "%s: %s" problem explanation))
Simplify Flymake logging and erroring Use display-warning and a dedicated *Flymake log* buffer. To ease readability, flymake log messages are now prefixed with a common prefix and the buffer that originated them. Some situations of over-zealous logging are fixed. Use byte-compiler info, if available, to determine whence the flymake-related log message is coming. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Improve log message. (flymake-proc--panic): Always flymake-log an error (flymake-proc--safe-delete-file) (flymake-proc--safe-delete-directory): Downgrade warning (flymake-proc-start-syntax-check): Simplify slightly. (flymake-proc--start-syntax-check-process): Simplify. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): No need to warn twice. * lisp/progmodes/flymake.el (flymake-log): Convert to macro. (flymake--log-1): New helper. (flymake-log-level): Deprecate. (flymake-error): New helper. (flymake-ler-make-ler, flymake--handle-report, flymake-mode): Use flymake-error. (flymake-on-timer-event) (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake-start, flymake-mode-on) (flymake-mode-off, flymake-after-change-function) (flymake-after-save-hook, flymake-find-file-hook): Adjust flymake-log calls. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Only log errors.
2017-09-26 01:35:43 +01:00
(flymake-error "Trouble telling flymake-ui about problem %s(%s)"
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
problem explanation)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(require 'compile)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-get-project-include-dirs-imp (basedir)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Include dirs for the project current file belongs to."
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(if (flymake-proc--get-project-include-dirs-from-cache basedir)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(progn
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(flymake-proc--get-project-include-dirs-from-cache basedir))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;;else
(let* ((command-line (concat "make -C "
(shell-quote-argument basedir)
" DUMPVARS=INCLUDE_DIRS dumpvars"))
(output (shell-command-to-string command-line))
(lines (split-string output "\n" t))
(count (length lines))
(idx 0)
(inc-dirs nil))
(while (and (< idx count) (not (string-match "^INCLUDE_DIRS=.*" (nth idx lines))))
(setq idx (1+ idx)))
(when (< idx count)
(let* ((inc-lines (split-string (nth idx lines) " *-I" t))
(inc-count (length inc-lines)))
(while (> inc-count 0)
(when (not (string-match "^INCLUDE_DIRS=.*" (nth (1- inc-count) inc-lines)))
(push (replace-regexp-in-string "\"" "" (nth (1- inc-count) inc-lines)) inc-dirs))
(setq inc-count (1- inc-count)))))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(flymake-proc--add-project-include-dirs-to-cache basedir inc-dirs)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
inc-dirs)))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defvar flymake-proc-get-project-include-dirs-function #'flymake-proc-get-project-include-dirs-imp
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Function used to get project include dirs, one parameter: basedir name.")
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-project-include-dirs (basedir)
(funcall flymake-proc-get-project-include-dirs-function basedir))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-system-include-dirs ()
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"System include dirs - from the `INCLUDE' env setting."
(let* ((includes (getenv "INCLUDE")))
(if includes (split-string includes path-separator t) nil)))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defvar flymake-proc--project-include-dirs-cache (make-hash-table :test #'equal))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-project-include-dirs-from-cache (base-dir)
(gethash base-dir flymake-proc--project-include-dirs-cache))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--add-project-include-dirs-to-cache (base-dir include-dirs)
(puthash base-dir include-dirs flymake-proc--project-include-dirs-cache))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--clear-project-include-dirs-cache ()
(clrhash flymake-proc--project-include-dirs-cache))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-get-include-dirs (base-dir)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Get dirs to use when resolving local file names."
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(let* ((include-dirs (append '(".") (flymake-proc--get-project-include-dirs base-dir) (flymake-proc--get-system-include-dirs))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
include-dirs))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
;; (defun flymake-proc--restore-formatting ()
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;; "Remove any formatting made by flymake."
;; )
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
;; (defun flymake-proc--get-program-dir (buffer)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;; "Get dir to start program in."
;; (unless (bufferp buffer)
;; (error "Invalid buffer"))
;; (with-current-buffer buffer
;; default-directory))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--safe-delete-file (file-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(when (and file-name (file-exists-p file-name))
(delete-file file-name)
Simplify Flymake logging and erroring Use display-warning and a dedicated *Flymake log* buffer. To ease readability, flymake log messages are now prefixed with a common prefix and the buffer that originated them. Some situations of over-zealous logging are fixed. Use byte-compiler info, if available, to determine whence the flymake-related log message is coming. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Improve log message. (flymake-proc--panic): Always flymake-log an error (flymake-proc--safe-delete-file) (flymake-proc--safe-delete-directory): Downgrade warning (flymake-proc-start-syntax-check): Simplify slightly. (flymake-proc--start-syntax-check-process): Simplify. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): No need to warn twice. * lisp/progmodes/flymake.el (flymake-log): Convert to macro. (flymake--log-1): New helper. (flymake-log-level): Deprecate. (flymake-error): New helper. (flymake-ler-make-ler, flymake--handle-report, flymake-mode): Use flymake-error. (flymake-on-timer-event) (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake-start, flymake-mode-on) (flymake-mode-off, flymake-after-change-function) (flymake-after-save-hook, flymake-find-file-hook): Adjust flymake-log calls. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Only log errors.
2017-09-26 01:35:43 +01:00
(flymake-log 2 "deleted file %s" file-name)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--safe-delete-directory (dir-name)
Flymake's flymake-proc.el backend slightly easier to debug Misc cleanup in flymake-proc.el Improve description of what this file contains. Better name for the backend function. Fix the case where it is run interactively. Keep the output buffer alive iff the external process panics. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Rename from flymake-proc-start-syntax-check. Allow running interactively. (flymake-start-syntax-check): Obsolete alias for flymake-proc-legacy-flymake. (flymake-proc-start-syntax-check): Delete. (flymake-diagnostic-functions): Include flymake-proc-legacy-flymake (flymake-proc--process-sentinel): Keep output buffer alive. Clarify with comments. (flymake-proc--diagnostics-for-pattern) (flymake-proc--process-sentinel) (flymake-proc--safe-delete-directory) (flymake-proc--start-syntax-check-process): Use condition-case-unless-debug.
2017-09-19 14:56:59 +01:00
(condition-case-unless-debug nil
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(progn
(delete-directory dir-name)
Simplify Flymake logging and erroring Use display-warning and a dedicated *Flymake log* buffer. To ease readability, flymake log messages are now prefixed with a common prefix and the buffer that originated them. Some situations of over-zealous logging are fixed. Use byte-compiler info, if available, to determine whence the flymake-related log message is coming. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Improve log message. (flymake-proc--panic): Always flymake-log an error (flymake-proc--safe-delete-file) (flymake-proc--safe-delete-directory): Downgrade warning (flymake-proc-start-syntax-check): Simplify slightly. (flymake-proc--start-syntax-check-process): Simplify. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): No need to warn twice. * lisp/progmodes/flymake.el (flymake-log): Convert to macro. (flymake--log-1): New helper. (flymake-log-level): Deprecate. (flymake-error): New helper. (flymake-ler-make-ler, flymake--handle-report, flymake-mode): Use flymake-error. (flymake-on-timer-event) (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake-start, flymake-mode-on) (flymake-mode-off, flymake-after-change-function) (flymake-after-save-hook, flymake-find-file-hook): Adjust flymake-log calls. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Only log errors.
2017-09-26 01:35:43 +01:00
(flymake-log 2 "deleted dir %s" dir-name))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(error
(flymake-log 1 "Failed to delete dir %s, error ignored" dir-name))))
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
Minimal tweak as an attempt to future-proof Flymake API Discussed with Stefan that this should allow Flymake to request more from backends in the future, while also allowing backends to report more accurately. * lisp/progmodes/elisp-mode.el (elisp-flymake-checkdoc) (elisp-flymake-byte-compile): Adjust to new API. * lisp/progmodes/flymake-proc.el () (flymake-proc-legacy-flymake): Adjust to new API. * lisp/progmodes/flymake.el (flymake-diagnostic-functions): Review API again. (flymake--handle-report): Allow other keys. Change ACTION to REPORT-ACTION.
2017-10-02 13:28:18 +01:00
(defun flymake-proc-legacy-flymake (report-fn &rest args)
Capitalize "Flymake" in docstrings and comments * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-setup-backends): Capitalize "Flymake" * lisp/progmodes/flymake-proc.el: (flymake-proc-reformat-err-line-patterns-from-compile-el) (flymake-proc--panic, flymake-proc-legacy-flymake) (flymake-start-syntax-check, flymake-proc-compile) (define-obsolete-variable-alias): Capitalize "Flymake" * lisp/progmodes/flymake.el (flymake-fringe-indicator-position) (flymake-make-diagnostic, flymake-delete-own-overlays) (flymake-diagnostic-functions) (flymake-diagnostic-types-alist, flymake-is-running) (flymake-make-report-fn, flymake-mode-on, flymake-mode-off) (flymake-goto-next-error, flymake-goto-prev-error): Capitalize "Flymake"
2017-09-30 18:04:45 +01:00
"Flymake backend based on the original Flymake implementation.
Flymake's flymake-proc.el backend slightly easier to debug Misc cleanup in flymake-proc.el Improve description of what this file contains. Better name for the backend function. Fix the case where it is run interactively. Keep the output buffer alive iff the external process panics. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Rename from flymake-proc-start-syntax-check. Allow running interactively. (flymake-start-syntax-check): Obsolete alias for flymake-proc-legacy-flymake. (flymake-proc-start-syntax-check): Delete. (flymake-diagnostic-functions): Include flymake-proc-legacy-flymake (flymake-proc--process-sentinel): Keep output buffer alive. Clarify with comments. (flymake-proc--diagnostics-for-pattern) (flymake-proc--process-sentinel) (flymake-proc--safe-delete-directory) (flymake-proc--start-syntax-check-process): Use condition-case-unless-debug.
2017-09-19 14:56:59 +01:00
This function is suitable for inclusion in
; Minor stylistic fixes found by checkdoc
2021-09-14 08:43:18 +02:00
`flymake-diagnostic-functions'. For backward compatibility, it
Flymake's flymake-proc.el backend slightly easier to debug Misc cleanup in flymake-proc.el Improve description of what this file contains. Better name for the backend function. Fix the case where it is run interactively. Keep the output buffer alive iff the external process panics. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Rename from flymake-proc-start-syntax-check. Allow running interactively. (flymake-start-syntax-check): Obsolete alias for flymake-proc-legacy-flymake. (flymake-proc-start-syntax-check): Delete. (flymake-diagnostic-functions): Include flymake-proc-legacy-flymake (flymake-proc--process-sentinel): Keep output buffer alive. Clarify with comments. (flymake-proc--diagnostics-for-pattern) (flymake-proc--process-sentinel) (flymake-proc--safe-delete-directory) (flymake-proc--start-syntax-check-process): Use condition-case-unless-debug.
2017-09-19 14:56:59 +01:00
can also be executed interactively independently of
`flymake-mode'."
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
;; Interactively, behave as if flymake had invoked us through its
;; `flymake-diagnostic-functions' with a suitable ID so flymake can
;; clean up consistently
Flymake's flymake-proc.el backend slightly easier to debug Misc cleanup in flymake-proc.el Improve description of what this file contains. Better name for the backend function. Fix the case where it is run interactively. Keep the output buffer alive iff the external process panics. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Rename from flymake-proc-start-syntax-check. Allow running interactively. (flymake-start-syntax-check): Obsolete alias for flymake-proc-legacy-flymake. (flymake-proc-start-syntax-check): Delete. (flymake-diagnostic-functions): Include flymake-proc-legacy-flymake (flymake-proc--process-sentinel): Keep output buffer alive. Clarify with comments. (flymake-proc--diagnostics-for-pattern) (flymake-proc--process-sentinel) (flymake-proc--safe-delete-directory) (flymake-proc--start-syntax-check-process): Use condition-case-unless-debug.
2017-09-19 14:56:59 +01:00
(interactive (list
(lambda (diags &rest args)
(apply (flymake-make-report-fn 'flymake-proc-legacy-flymake)
diags
(append args '(:force t))))
Minimal tweak as an attempt to future-proof Flymake API Discussed with Stefan that this should allow Flymake to request more from backends in the future, while also allowing backends to report more accurately. * lisp/progmodes/elisp-mode.el (elisp-flymake-checkdoc) (elisp-flymake-byte-compile): Adjust to new API. * lisp/progmodes/flymake-proc.el () (flymake-proc-legacy-flymake): Adjust to new API. * lisp/progmodes/flymake.el (flymake-diagnostic-functions): Review API again. (flymake--handle-report): Allow other keys. Change ACTION to REPORT-ACTION.
2017-10-02 13:28:18 +01:00
:interactive t))
(let ((interactive (plist-get args :interactive))
(proc flymake-proc--current-process)
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(flymake-proc--report-fn report-fn))
(when (processp proc)
(process-put proc 'flymake-proc--obsolete t)
(flymake-log 3 "marking %s obsolete" (process-id proc))
(when (process-live-p proc)
(when interactive
(user-error
Capitalize "Flymake" in docstrings and comments * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-setup-backends): Capitalize "Flymake" * lisp/progmodes/flymake-proc.el: (flymake-proc-reformat-err-line-patterns-from-compile-el) (flymake-proc--panic, flymake-proc-legacy-flymake) (flymake-start-syntax-check, flymake-proc-compile) (define-obsolete-variable-alias): Capitalize "Flymake" * lisp/progmodes/flymake.el (flymake-fringe-indicator-position) (flymake-make-diagnostic, flymake-delete-own-overlays) (flymake-diagnostic-functions) (flymake-diagnostic-types-alist, flymake-is-running) (flymake-make-report-fn, flymake-mode-on, flymake-mode-off) (flymake-goto-next-error, flymake-goto-prev-error): Capitalize "Flymake"
2017-09-30 18:04:45 +01:00
"There's already a Flymake process running in this buffer")
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(kill-process proc))))
(when
Misc. minor adjustments to Flymake - Add a half-decent minor-mode menu; - Fix "waiting for backends" mode line message; - Adjust the flymake-diag-region API; - Autoload the flymake-log macro; - Auto-disable the legacy backend in more situations; - Fix a couple of warnings in legacy backend. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Use new flymake-diag-region. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Do error when no buffer-file-name or not writable. (flymake-proc-legacy-flymake) (flymake-proc-simple-cleanup): Don't reference flymake-last-change-time * lisp/progmodes/flymake.el (flymake-diag-region): Autoload. Take buffer as first argument. * lisp/progmodes/flymake.el (flymake-switch-to-log-buffer): New command. (flymake-menu): Add a simple menu. (flymake--mode-line-format): Use menu. Fix message. Switch to log buffer when clicking exceptional warnings.
2017-10-05 02:42:01 +01:00
;; This particular situation make us not want to error right
;; away (and disable ourselves), in case the situation changes
;; in the near future.
(and (or (not flymake-proc-compilation-prevents-syntax-check)
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(not (flymake-proc--compilation-is-running))))
Misc. minor adjustments to Flymake - Add a half-decent minor-mode menu; - Fix "waiting for backends" mode line message; - Adjust the flymake-diag-region API; - Autoload the flymake-log macro; - Auto-disable the legacy backend in more situations; - Fix a couple of warnings in legacy backend. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Use new flymake-diag-region. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Do error when no buffer-file-name or not writable. (flymake-proc-legacy-flymake) (flymake-proc-simple-cleanup): Don't reference flymake-last-change-time * lisp/progmodes/flymake.el (flymake-diag-region): Autoload. Take buffer as first argument. * lisp/progmodes/flymake.el (flymake-switch-to-log-buffer): New command. (flymake-menu): Add a simple menu. (flymake--mode-line-format): Use menu. Fix message. Switch to log buffer when clicking exceptional warnings.
2017-10-05 02:42:01 +01:00
(let ((init-f
(and
buffer-file-name
;; Since we write temp files in current dir, there's no point
;; trying if the directory is read-only (bug#8954).
(file-writable-p (file-name-directory buffer-file-name))
(flymake-proc--get-init-function buffer-file-name))))
; Fix a typo
2017-11-22 00:46:59 +02:00
(unless init-f (error "Can't find a suitable init function"))
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(flymake-proc--clear-buildfile-cache)
(flymake-proc--clear-project-include-dirs-cache)
Fix filesystem littering by Flymake's legacy backend The Flymake legacy "proc" backend, which is active by default will try to syntax-check foo.c/foo.cpp and many other types of files, but on failing to find a suitable Makefile target, will fail. There's nothing wrong with that except that it used to leave behind the foo_flymake.c and foo_flymake.cpp auxiliary files behind, littering the filesystem. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Call init-function inside of the unwind-protect.
2018-05-11 23:28:40 +01:00
(let ((cleanup-f (flymake-proc--get-cleanup-function buffer-file-name))
(success nil))
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(unwind-protect
Fix filesystem littering by Flymake's legacy backend The Flymake legacy "proc" backend, which is active by default will try to syntax-check foo.c/foo.cpp and many other types of files, but on failing to find a suitable Makefile target, will fail. There's nothing wrong with that except that it used to leave behind the foo_flymake.c and foo_flymake.cpp auxiliary files behind, littering the filesystem. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Call init-function inside of the unwind-protect.
2018-05-11 23:28:40 +01:00
(let* ((cmd-and-args (funcall init-f))
(cmd (nth 0 cmd-and-args))
(args (nth 1 cmd-and-args))
(dir (nth 2 cmd-and-args)))
(cond
((not cmd-and-args)
(flymake-log 1 "init function %s for %s failed, cleaning up"
init-f buffer-file-name))
(t
(setq proc
(let ((default-directory (or dir default-directory)))
(when dir
(flymake-log 3 "starting process on dir %s" dir))
(make-process
:name "flymake-proc"
:buffer (current-buffer)
:command (cons cmd args)
:noquery t
:filter
(lambda (proc string)
(let ((flymake-proc--report-fn report-fn))
(flymake-proc--process-filter proc string)))
:sentinel
(lambda (proc event)
(let ((flymake-proc--report-fn report-fn))
(flymake-proc--process-sentinel proc event))))))
(process-put proc 'flymake-proc--output-buffer
(generate-new-buffer
(format " *flymake output for %s*" (current-buffer))))
Fix flymake-proc temporary file deletion bug * list/progmodes/flymake-proc.el (flymake-proc-create-temp-inplace): Include a time string part (hour + minute + second + nanosecond) in the temporary name to make it unique enough. (flymake-proc-legacy-flymake): Store temporary file names in the process for usage in the sentinel. (flymake-proc--process-sentinel): Bind values of temporary file names dynamically to values stored in the process so that the cleanup function will delete the correct temporary file(s). Fixes bug#31981.
2019-08-28 21:00:00 +02:00
(process-put proc 'flymake-proc--temp-source-file-name
flymake-proc--temp-source-file-name)
(process-put proc 'flymake-proc--temp-master-file-name
flymake-proc--temp-master-file-name)
Fix filesystem littering by Flymake's legacy backend The Flymake legacy "proc" backend, which is active by default will try to syntax-check foo.c/foo.cpp and many other types of files, but on failing to find a suitable Makefile target, will fail. There's nothing wrong with that except that it used to leave behind the foo_flymake.c and foo_flymake.cpp auxiliary files behind, littering the filesystem. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Call init-function inside of the unwind-protect.
2018-05-11 23:28:40 +01:00
(setq flymake-proc--current-process proc)
(flymake-log 2 "started process %d, command=%s, dir=%s"
(process-id proc) (process-command proc)
default-directory)
(setq success t))))
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(unless success
(funcall cleanup-f))))))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Flymake's flymake-proc.el backend slightly easier to debug Misc cleanup in flymake-proc.el Improve description of what this file contains. Better name for the backend function. Fix the case where it is run interactively. Keep the output buffer alive iff the external process panics. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Rename from flymake-proc-start-syntax-check. Allow running interactively. (flymake-start-syntax-check): Obsolete alias for flymake-proc-legacy-flymake. (flymake-proc-start-syntax-check): Delete. (flymake-diagnostic-functions): Include flymake-proc-legacy-flymake (flymake-proc--process-sentinel): Keep output buffer alive. Clarify with comments. (flymake-proc--diagnostics-for-pattern) (flymake-proc--process-sentinel) (flymake-proc--safe-delete-directory) (flymake-proc--start-syntax-check-process): Use condition-case-unless-debug.
2017-09-19 14:56:59 +01:00
(define-obsolete-function-alias 'flymake-start-syntax-check
Batch of minor Flymake cleanup actions agreed to with Stefan Discussed with Stefan, in no particular order - Remove aliases for symbols thought to be internal to flymake-proc.el - Don’t need :group in defcustom and defface in flymake.el - Fix docstring of flymake-make-diagnostic - Fix docstring of flymake-diagnostic-functions to clarify keywords. - Mark overlays with just the property ’flymake, not ’flymake-overlay - Tune flymake-overlays for performance - Make flymake-mode-on and flymake-mode-off obsolete - Don’t use hash-table-keys unless necessary. - Copyright notice in flymake-elisp. Added some more - Clarify docstring of flymake-goto-next-error - Clarify a comment in flymake--run-backend complaining about ert-deftest. - Prevent compilation warnings in flymake-proc.el - Remove doctring from obsolete aliases Now the changelog: * lisp/progmodes/flymake-elisp.el: Proper copyright notice. * lisp/progmodes/flymake-proc.el (flymake-warning-re) (flymake-proc-diagnostic-type-pred) (flymake-proc-default-guess) (flymake-proc--get-file-name-mode-and-masks): Move up to beginning of file to shoosh compiler warnings (define-obsolete-variable-alias): Delete many obsolete aliases. * lisp/progmodes/flymake.el (flymake-error-bitmap) (flymake-warning-bitmap, flymake-note-bitmap) (flymake-fringe-indicator-position) (flymake-start-syntax-check-on-newline) (flymake-no-changes-timeout, flymake-gui-warnings-enabled) (flymake-start-syntax-check-on-find-file, flymake-log-level) (flymake-wrap-around, flymake-error, flymake-warning) (flymake-note): Don't need :group in these defcustom and defface. (flymake--run-backend): Clarify comment (flymake-mode-map): Remove. (flymake-make-diagnostic): Fix docstring. (flymake--highlight-line, flymake--overlays): Identify flymake overlays with just ’flymake. (flymake--overlays): Reverse order of invocation for cl-remove-if-not and cl-sort. (flymake-mode-on) (flymake-mode-off): Make obsolete. (flymake-goto-next-error, flymake-goto-prev-error): Fix docstring. (flymake-diagnostic-functions): Clarify keyword arguments in docstring. Maybe squash in that one where I remove many obsoletes
2017-09-29 11:02:36 +01:00
'flymake-proc-legacy-flymake "26.1")
Flymake's flymake-proc.el backend slightly easier to debug Misc cleanup in flymake-proc.el Improve description of what this file contains. Better name for the backend function. Fix the case where it is run interactively. Keep the output buffer alive iff the external process panics. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Rename from flymake-proc-start-syntax-check. Allow running interactively. (flymake-start-syntax-check): Obsolete alias for flymake-proc-legacy-flymake. (flymake-proc-start-syntax-check): Delete. (flymake-diagnostic-functions): Include flymake-proc-legacy-flymake (flymake-proc--process-sentinel): Keep output buffer alive. Clarify with comments. (flymake-proc--diagnostics-for-pattern) (flymake-proc--process-sentinel) (flymake-proc--safe-delete-directory) (flymake-proc--start-syntax-check-process): Use condition-case-unless-debug.
2017-09-19 14:56:59 +01:00
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
(defun flymake-proc-stop-all-syntax-checks (&optional reason)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Kill all syntax check processes."
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
(interactive (list "Interrupted by user"))
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(dolist (buf (buffer-list))
(with-current-buffer buf
flymake: fix typo in variable binding (bug#38752) This mistake was found by an experimental elisp optimiser. * lisp/progmodes/flymake-proc.el (flymake-proc-stop-all-syntax-checks): Add missing brackets.
2020-01-10 18:12:32 +01:00
(let ((p flymake-proc--current-process))
Flymake backends can report multiple times per check Rewrote a significant part of the Flymake backend API. Flymake now ignores the return value of backend functions: a function can either returns or errors. If it doesn't error, a backend is no longer constrained to call REPORT-FN exactly once. It may do so any number of times, cumulatively reporting diagnostics. Flymake keeps track of outdated REPORT-FN instances and disconsiders obsolete reports. Backends should avoid reporting obsolete data by cancelling any ongoing processing at every renewed call to the backend function. Consolidated flymake.el internal data structures to require less buffer-local variables. Adjusted Flymake's mode-line indicator to the new semantics. Adapted and simplified the implementation of elisp and legacy backends, fixing potential race conditions when calling backends in rapid succession. Added a new test for a backend that calls REPORT-FN multiple times. Simplify test infrastructure. * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-byte-compile): Error instead of returning nil if not in emacs-lisp-mode. (flymake-elisp--byte-compile-process): New buffer-local variable. (flymake-elisp-byte-compile): Mark (and kill) previous process obsolete process before starting a new one. Don't report if obsolete process. * lisp/progmodes/flymake-proc.el (flymake-proc--current-process): New buffer-local variable. (flymake-proc--processes): Remove. (flymake-proc--process-filter): Don't bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite. Don't report if obsolete process. (flymake-proc-legacy-flymake): Rewrite. Mark (and kill) previous process obsolete process before starting a new one. Integrate flymake-proc--start-syntax-check-process helper. (flymake-proc--start-syntax-check-process): Delete. (flymake-proc-stop-all-syntax-checks): Don't use flymake-proc--processes, iterate buffers. (flymake-proc-compile): * lisp/progmodes/flymake.el (subr-x): Require it explicitly. (flymake-diagnostic-functions): Reword docstring. (flymake--running-backends, flymake--disabled-backends) (flymake--diagnostics-table): Delete. (flymake--backend-state): New buffer-local variable and new defstruct. (flymake--with-backend-state, flymake--collect) (flymake-running-backends, flymake-disabled-backends) (flymake-reporting-backends): New helpers. (flymake-is-running): Use flymake-running-backends. (flymake--handle-report): Rewrite. (flymake-make-report-fn): Ensure REPORT-FN runs in the correct buffer or not at all. (flymake--disable-backend, flymake--run-backend): Rewrite. (flymake-start): Rewrite. (flymake-mode): Set flymake--backend-state. (flymake--mode-line-format): Rewrite. * test/lisp/progmodes/flymake-tests.el (flymake-tests--wait-for-backends): New helper. (flymake-tests--call-with-fixture): Use it. (included-c-header-files): Fix whitespace. (flymake-tests--diagnose-words): New helper. (dummy-backends): Rewrite for new semantics. Use cl-letf. (flymake-tests--assert-set): Use quote. (recurrent-backend): New test.
2017-09-30 17:32:53 +01:00
(when (process-live-p p)
(kill-process p)
(process-put p 'flymake-proc--interrupted reason)
(flymake-log 2 "killed process %d" (process-id p)))))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--compilation-is-running ()
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(and (boundp 'compilation-in-progress)
compilation-in-progress))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-compile ()
Capitalize "Flymake" in docstrings and comments * lisp/progmodes/flymake-elisp.el (flymake-elisp-checkdoc) (flymake-elisp-setup-backends): Capitalize "Flymake" * lisp/progmodes/flymake-proc.el: (flymake-proc-reformat-err-line-patterns-from-compile-el) (flymake-proc--panic, flymake-proc-legacy-flymake) (flymake-start-syntax-check, flymake-proc-compile) (define-obsolete-variable-alias): Capitalize "Flymake" * lisp/progmodes/flymake.el (flymake-fringe-indicator-position) (flymake-make-diagnostic, flymake-delete-own-overlays) (flymake-diagnostic-functions) (flymake-diagnostic-types-alist, flymake-is-running) (flymake-make-report-fn, flymake-mode-on, flymake-mode-off) (flymake-goto-next-error, flymake-goto-prev-error): Capitalize "Flymake"
2017-09-30 18:04:45 +01:00
"Kill all Flymake syntax checks, start compilation."
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(interactive)
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
(flymake-proc-stop-all-syntax-checks "Stopping for proper compilation")
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(call-interactively 'compile))
;;;; general init-cleanup and helper routines
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-create-temp-inplace (file-name prefix)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(unless (stringp file-name)
(error "Invalid file-name"))
(or prefix
(setq prefix "flymake"))
(let* ((ext (file-name-extension file-name))
(temp-name (file-truename
(concat (file-name-sans-extension file-name)
Fix flymake-proc temporary file deletion bug * list/progmodes/flymake-proc.el (flymake-proc-create-temp-inplace): Include a time string part (hour + minute + second + nanosecond) in the temporary name to make it unique enough. (flymake-proc-legacy-flymake): Store temporary file names in the process for usage in the sentinel. (flymake-proc--process-sentinel): Bind values of temporary file names dynamically to values stored in the process so that the cleanup function will delete the correct temporary file(s). Fixes bug#31981.
2019-08-28 21:00:00 +02:00
"_" (format-time-string "%H%M%S%N")
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"_" prefix
(and ext (concat "." ext))))))
(flymake-log 3 "create-temp-inplace: file=%s temp=%s" file-name temp-name)
temp-name))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-create-temp-with-folder-structure (file-name _prefix)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(unless (stringp file-name)
(error "Invalid file-name"))
Fix Bug#33524 * lisp/progmodes/flymake-proc.el (flymake-proc-create-temp-with-folder-structure): Unquote file-name. (Bug#33524)
2018-12-17 11:56:05 +01:00
(let* ((dir (file-name-directory (file-name-unquote file-name)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;; Not sure what this slash-pos is all about, but I guess it's just
;; trying to remove the leading / of absolute file names.
(slash-pos (string-match "/" dir))
(temp-dir (expand-file-name (substring dir (1+ slash-pos))
temporary-file-directory)))
(file-truename (expand-file-name (file-name-nondirectory file-name)
temp-dir))))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--delete-temp-directory (dir-name)
; Adjust overly long docstrings to fit 80 characters
2021-09-24 14:46:56 +02:00
"Attempt to delete temp dir DIR-NAME, do not fail on error."
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(let* ((temp-dir temporary-file-directory)
Fix flymake-proc--delete-temp-directory if temp dir ends in slash Fixes: bug#34074 Reported by 林宝龙 <lbl52001@gmail.com>. * lisp/progmodes/flymake-proc.el (flymake-proc--delete-temp-directory): Use directory-file-name.
2019-01-17 14:38:44 +00:00
(suffix (substring dir-name (1+ (length (directory-file-name temp-dir))))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(while (> (length suffix) 0)
(setq suffix (directory-file-name suffix))
;;+(flymake-log 0 "suffix=%s" suffix)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(flymake-proc--safe-delete-directory
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(file-truename (expand-file-name suffix temp-dir)))
(setq suffix (file-name-directory suffix)))))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defvar-local flymake-proc--temp-source-file-name nil)
(defvar-local flymake-proc--master-file-name nil)
(defvar-local flymake-proc--temp-master-file-name nil)
(defvar-local flymake-proc--base-dir nil)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-init-create-temp-buffer-copy (create-temp-f)
; Adjust overly long docstrings to fit 80 characters
2021-09-24 14:46:56 +02:00
"Make a temporary copy of the current buffer, save its name in buffer data.
Return the name."
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(let* ((source-file-name buffer-file-name)
(temp-source-file-name (funcall create-temp-f source-file-name "flymake")))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(flymake-proc--save-buffer-in-file temp-source-file-name)
(setq flymake-proc--temp-source-file-name temp-source-file-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
temp-source-file-name))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-simple-cleanup ()
"Do cleanup after `flymake-proc-init-create-temp-buffer-copy'.
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Delete temp file."
Misc. minor adjustments to Flymake - Add a half-decent minor-mode menu; - Fix "waiting for backends" mode line message; - Adjust the flymake-diag-region API; - Autoload the flymake-log macro; - Auto-disable the legacy backend in more situations; - Fix a couple of warnings in legacy backend. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Use new flymake-diag-region. * lisp/progmodes/flymake-proc.el (flymake-proc-legacy-flymake): Do error when no buffer-file-name or not writable. (flymake-proc-legacy-flymake) (flymake-proc-simple-cleanup): Don't reference flymake-last-change-time * lisp/progmodes/flymake.el (flymake-diag-region): Autoload. Take buffer as first argument. * lisp/progmodes/flymake.el (flymake-switch-to-log-buffer): New command. (flymake-menu): Add a simple menu. (flymake--mode-line-format): Use menu. Fix message. Switch to log buffer when clicking exceptional warnings.
2017-10-05 02:42:01 +01:00
(flymake-proc--safe-delete-file flymake-proc--temp-source-file-name))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-get-real-file-name (file-name-from-err-msg)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Translate file name from error message to \"real\" file name.
Return full-name. Names are real, not patched."
(let* ((real-name nil)
(source-file-name buffer-file-name)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(master-file-name flymake-proc--master-file-name)
(temp-source-file-name flymake-proc--temp-source-file-name)
(temp-master-file-name flymake-proc--temp-master-file-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(base-dirs
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(list flymake-proc--base-dir
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(file-name-directory source-file-name)
(if master-file-name (file-name-directory master-file-name))))
(files (list (list source-file-name source-file-name)
(list temp-source-file-name source-file-name)
(list master-file-name master-file-name)
(list temp-master-file-name master-file-name))))
(when (equal 0 (length file-name-from-err-msg))
(setq file-name-from-err-msg source-file-name))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(setq real-name (flymake-proc--get-full-patched-file-name file-name-from-err-msg base-dirs files))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;; if real-name is nil, than file name from err msg is none of the files we've patched
(if (not real-name)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(setq real-name (flymake-proc--get-full-nonpatched-file-name file-name-from-err-msg base-dirs)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(if (not real-name)
(setq real-name file-name-from-err-msg))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(setq real-name (flymake-proc--fix-file-name real-name))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(flymake-log 3 "get-real-file-name: file-name=%s real-name=%s" file-name-from-err-msg real-name)
real-name))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-full-patched-file-name (file-name-from-err-msg base-dirs files)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(let* ((base-dirs-count (length base-dirs))
(file-count (length files))
(real-name nil))
(while (and (not real-name) (> base-dirs-count 0))
(setq file-count (length files))
(while (and (not real-name) (> file-count 0))
(let* ((this-dir (nth (1- base-dirs-count) base-dirs))
(this-file (nth 0 (nth (1- file-count) files)))
(this-real-name (nth 1 (nth (1- file-count) files))))
;;+(flymake-log 0 "this-dir=%s this-file=%s this-real=%s msg-file=%s" this-dir this-file this-real-name file-name-from-err-msg)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(when (and this-dir this-file (flymake-proc--same-files
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(expand-file-name file-name-from-err-msg this-dir)
this-file))
(setq real-name this-real-name)))
(setq file-count (1- file-count)))
(setq base-dirs-count (1- base-dirs-count)))
real-name))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-full-nonpatched-file-name (file-name-from-err-msg base-dirs)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(let* ((real-name nil))
(if (file-name-absolute-p file-name-from-err-msg)
(setq real-name file-name-from-err-msg)
(let* ((base-dirs-count (length base-dirs)))
(while (and (not real-name) (> base-dirs-count 0))
(let* ((full-name (expand-file-name file-name-from-err-msg
(nth (1- base-dirs-count) base-dirs))))
(if (file-exists-p full-name)
(setq real-name full-name))
(setq base-dirs-count (1- base-dirs-count))))))
real-name))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--init-find-buildfile-dir (source-file-name buildfile-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Find buildfile, store its dir in buffer data and return its dir, if found."
(let* ((buildfile-dir
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(flymake-proc--find-buildfile buildfile-name
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
(file-name-directory source-file-name))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(if buildfile-dir
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(setq flymake-proc--base-dir buildfile-dir)
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
(flymake-proc--panic
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"NOMK" (format "No buildfile (%s) found for %s"
buildfile-name source-file-name)))))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--init-create-temp-source-and-master-buffer-copy (get-incl-dirs-f create-temp-f master-file-masks include-regexp)
; Adjust overly long docstrings to fit 80 characters
2021-09-24 14:46:56 +02:00
"Find master file (or buffer), create its copy and a copy of the source file."
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(let* ((source-file-name buffer-file-name)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(temp-source-file-name (flymake-proc-init-create-temp-buffer-copy create-temp-f))
(master-and-temp-master (flymake-proc--create-master-file
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
source-file-name temp-source-file-name
get-incl-dirs-f create-temp-f
master-file-masks include-regexp)))
(if (not master-and-temp-master)
(progn
Simplify Flymake logging and erroring Use display-warning and a dedicated *Flymake log* buffer. To ease readability, flymake log messages are now prefixed with a common prefix and the buffer that originated them. Some situations of over-zealous logging are fixed. Use byte-compiler info, if available, to determine whence the flymake-related log message is coming. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Improve log message. (flymake-proc--panic): Always flymake-log an error (flymake-proc--safe-delete-file) (flymake-proc--safe-delete-directory): Downgrade warning (flymake-proc-start-syntax-check): Simplify slightly. (flymake-proc--start-syntax-check-process): Simplify. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): No need to warn twice. * lisp/progmodes/flymake.el (flymake-log): Convert to macro. (flymake--log-1): New helper. (flymake-log-level): Deprecate. (flymake-error): New helper. (flymake-ler-make-ler, flymake--handle-report, flymake-mode): Use flymake-error. (flymake-on-timer-event) (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake-start, flymake-mode-on) (flymake-mode-off, flymake-after-change-function) (flymake-after-save-hook, flymake-find-file-hook): Adjust flymake-log calls. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Only log errors.
2017-09-26 01:35:43 +01:00
(flymake-proc--panic
"NOMASTER"
(format-message "cannot find master file for %s"
source-file-name))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
nil)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(setq flymake-proc--master-file-name (nth 0 master-and-temp-master))
(setq flymake-proc--temp-master-file-name (nth 1 master-and-temp-master)))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-master-cleanup ()
(flymake-proc-simple-cleanup)
(flymake-proc--safe-delete-file flymake-proc--temp-master-file-name))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;;;; make-specific init-cleanup routines
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-syntax-check-program-args (source-file-name base-dir use-relative-base-dir use-relative-source get-cmd-line-f)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Create a command line for syntax check using GET-CMD-LINE-F."
(funcall get-cmd-line-f
(if use-relative-source
(file-relative-name source-file-name base-dir)
source-file-name)
(if use-relative-base-dir
(file-relative-name base-dir
(file-name-directory source-file-name))
base-dir)))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-get-make-cmdline (source base-dir)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(list "make"
(list "-s"
"-C"
base-dir
(concat "CHK_SOURCES=" source)
"SYNTAX_CHECK_MODE=1"
"check-syntax")))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-get-ant-cmdline (source base-dir)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(list "ant"
(list "-buildfile"
(concat base-dir "/" "build.xml")
(concat "-DCHK_SOURCES=" source)
"check-syntax")))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-simple-make-init-impl (create-temp-f use-relative-base-dir use-relative-source build-file-name get-cmdline-f)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Create syntax check command line for a directly checked source file.
Use CREATE-TEMP-F for creating temp copy."
(let* ((args nil)
(source-file-name buffer-file-name)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(buildfile-dir (flymake-proc--init-find-buildfile-dir source-file-name build-file-name)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(if buildfile-dir
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(let* ((temp-source-file-name (flymake-proc-init-create-temp-buffer-copy create-temp-f)))
(setq args (flymake-proc--get-syntax-check-program-args temp-source-file-name buildfile-dir
Batch of minor Flymake cleanup actions agreed to with Stefan Discussed with Stefan, in no particular order - Remove aliases for symbols thought to be internal to flymake-proc.el - Don’t need :group in defcustom and defface in flymake.el - Fix docstring of flymake-make-diagnostic - Fix docstring of flymake-diagnostic-functions to clarify keywords. - Mark overlays with just the property ’flymake, not ’flymake-overlay - Tune flymake-overlays for performance - Make flymake-mode-on and flymake-mode-off obsolete - Don’t use hash-table-keys unless necessary. - Copyright notice in flymake-elisp. Added some more - Clarify docstring of flymake-goto-next-error - Clarify a comment in flymake--run-backend complaining about ert-deftest. - Prevent compilation warnings in flymake-proc.el - Remove doctring from obsolete aliases Now the changelog: * lisp/progmodes/flymake-elisp.el: Proper copyright notice. * lisp/progmodes/flymake-proc.el (flymake-warning-re) (flymake-proc-diagnostic-type-pred) (flymake-proc-default-guess) (flymake-proc--get-file-name-mode-and-masks): Move up to beginning of file to shoosh compiler warnings (define-obsolete-variable-alias): Delete many obsolete aliases. * lisp/progmodes/flymake.el (flymake-error-bitmap) (flymake-warning-bitmap, flymake-note-bitmap) (flymake-fringe-indicator-position) (flymake-start-syntax-check-on-newline) (flymake-no-changes-timeout, flymake-gui-warnings-enabled) (flymake-start-syntax-check-on-find-file, flymake-log-level) (flymake-wrap-around, flymake-error, flymake-warning) (flymake-note): Don't need :group in these defcustom and defface. (flymake--run-backend): Clarify comment (flymake-mode-map): Remove. (flymake-make-diagnostic): Fix docstring. (flymake--highlight-line, flymake--overlays): Identify flymake overlays with just ’flymake. (flymake--overlays): Reverse order of invocation for cl-remove-if-not and cl-sort. (flymake-mode-on) (flymake-mode-off): Make obsolete. (flymake-goto-next-error, flymake-goto-prev-error): Fix docstring. (flymake-diagnostic-functions): Clarify keyword arguments in docstring. Maybe squash in that one where I remove many obsoletes
2017-09-29 11:02:36 +01:00
use-relative-base-dir use-relative-source
get-cmdline-f))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
args))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-simple-make-init ()
(flymake-proc-simple-make-init-impl 'flymake-proc-create-temp-inplace t t "Makefile" 'flymake-proc-get-make-cmdline))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-master-make-init (get-incl-dirs-f master-file-masks include-regexp)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
"Create make command line for a source file checked via master file compilation."
(let* ((make-args nil)
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(temp-master-file-name (flymake-proc--init-create-temp-source-and-master-buffer-copy
get-incl-dirs-f 'flymake-proc-create-temp-inplace
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
master-file-masks include-regexp)))
(when temp-master-file-name
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(let* ((buildfile-dir (flymake-proc--init-find-buildfile-dir temp-master-file-name "Makefile")))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(if buildfile-dir
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(setq make-args (flymake-proc--get-syntax-check-program-args
temp-master-file-name buildfile-dir nil nil 'flymake-proc-get-make-cmdline)))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
make-args))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--find-make-buildfile (source-dir)
(flymake-proc--find-buildfile "Makefile" source-dir))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;;;; .h/make specific
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-master-make-header-init ()
(flymake-proc-master-make-init
'flymake-proc-get-include-dirs
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
'("\\.\\(?:c\\(?:pp\\|xx\\|\\+\\+\\)?\\|CC\\)\\'")
"[ \t]*#[ \t]*include[ \t]*\"\\([[:word:]0-9/\\_.]*%s\\)\""))
Fix three Flymake bugs when checking C header files The first of these problems is longstanding: if an error-less B.h is included from error-ridden A.h, flymake's legacy parser will panic (and disable itself) since it sees a non-zero exit for a clean file. To fix this, recommend returning 'true' in the documentation for the check-syntax target. Another problem was introduced by the parser rewrite. For error patterns spanning more than one line, point may be left in the middle of a line and thus render other patterns useless. Those patterns were written for the old line-by-line parser. To make them useful again, move to the beginning of line in those situations. The third problem was also longstanding and happened on newer GCC's: The "In file included from" prefix confused flymake-proc-get-real-file-name. Fix this. Also updated flymake--diag-region to fallback to highlighting a full line less often. Add automatic tests to check this. * lisp/progmodes/flymake-proc.el (flymake-proc--diagnostics-for-pattern): Fix bug when patterns accidentally spans more than one line. Don't create diagnostics without error messages. (flymake-proc-real-file-name-considering-includes): New helper. (flymake-proc-allowed-file-name-masks): Use it. * lisp/progmodes/flymake.el (flymake-diag-region): Make COL argument explicitly optional. Only fall back to full line in extreme cases. * test/lisp/progmodes/flymake-tests.el (included-c-header-files): New test. (different-diagnostic-types): Update. * test/lisp/progmodes/flymake-resources/Makefile (check-syntax): Always return success (0) error code. (CC_OPTS): Add -Wextra * test/lisp/progmodes/flymake-resources/errors-and-warnings.c (main): Rewrite comments. * test/lisp/progmodes/flymake-resources/errors-and-warnings.c: Include some dummy header files. * test/lisp/progmodes/flymake-resources/no-problems.h: New file. * test/lisp/progmodes/flymake-resources/some-problems.h: New file. * doc/misc/flymake.texi (Example---Configuring a tool called via make): Recommend adding "|| true" to the check-syntax target.
2017-09-28 12:06:56 +01:00
(defun flymake-proc-real-file-name-considering-includes (scraped)
(flymake-proc-get-real-file-name
(let ((case-fold-search t))
(replace-regexp-in-string "^in file included from[ \t*]"
""
scraped))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;;;; .java/make specific
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-simple-make-java-init ()
(flymake-proc-simple-make-init-impl 'flymake-proc-create-temp-with-folder-structure nil nil "Makefile" 'flymake-proc-get-make-cmdline))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-simple-ant-java-init ()
(flymake-proc-simple-make-init-impl 'flymake-proc-create-temp-with-folder-structure nil nil "build.xml" 'flymake-proc-get-ant-cmdline))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-simple-java-cleanup ()
"Cleanup after `flymake-proc-simple-make-java-init' -- delete temp file and dirs."
(flymake-proc--safe-delete-file flymake-proc--temp-source-file-name)
(when flymake-proc--temp-source-file-name
(flymake-proc--delete-temp-directory
(file-name-directory flymake-proc--temp-source-file-name))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;;;; perl-specific init-cleanup routines
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-perl-init ()
(let* ((temp-file (flymake-proc-init-create-temp-buffer-copy
'flymake-proc-create-temp-inplace))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(local-file (file-relative-name
temp-file
(file-name-directory buffer-file-name))))
(list "perl" (list "-wc " local-file))))
;;;; php-specific init-cleanup routines
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-php-init ()
(let* ((temp-file (flymake-proc-init-create-temp-buffer-copy
'flymake-proc-create-temp-inplace))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(local-file (file-relative-name
temp-file
(file-name-directory buffer-file-name))))
(list "php" (list "-f" local-file "-l"))))
;;;; tex-specific init-cleanup routines
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-tex-args (file-name)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;;(list "latex" (list "-c-style-errors" file-name))
(list "texify" (list "--pdf" "--tex-option=-c-style-errors" file-name)))
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-simple-tex-init ()
(flymake-proc--get-tex-args (flymake-proc-init-create-temp-buffer-copy 'flymake-proc-create-temp-inplace)))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
;; Perhaps there should be a buffer-local variable flymake-master-file
;; that people can set to override this stuff. Could inherit from
;; the similar AUCTeX variable.
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-master-tex-init ()
(let* ((temp-master-file-name (flymake-proc--init-create-temp-source-and-master-buffer-copy
'flymake-proc-get-include-dirs-dot 'flymake-proc-create-temp-inplace
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
'("\\.tex\\'")
Fix more regular expression typos Problem reported by Mattias Engdegård in: https://lists.gnu.org/r/emacs-devel/2019-03/msg00548.html except that I didn’t address the issues involving Hebrew, or involving comint-prompt-regexp. * lisp/align.el (align-rules-list, align-exclude-rules-list): * lisp/auth-source-pass.el (auth-source-pass--parse-secret) (auth-source-pass--parse-data): * lisp/cedet/data-debug.el (data-debug-next) (data-debug-prev, data-debug-expand-or-contract): * lisp/comint.el (comint-within-quotes): * lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine): * lisp/emulation/viper-ex.el (ex-cmd-complete): * lisp/gnus/gnus-cite.el (gnus-message-search-citation-line): * lisp/gnus/nnir.el (nnir-imap-end-of-input): * lisp/mail/mail-extr.el (mail-extr-all-letters): * lisp/minibuffer.el (minibuffer-maybe-quote-filename): * lisp/nxml/rng-nxml.el (rng-complete-tag) (rng-complete-end-tag, rng-complete-attribute-name): * lisp/obsolete/vip.el (vip-get-ex-token, vip-get-ex-pat): * lisp/org/org-pcomplete.el (org-thing-at-point): * lisp/org/org.el (org-set-tags) (org-increase-number-at-point) (org-fill-line-break-nobreak-p): * lisp/pcomplete.el (pcomplete-parse-comint-arguments): * lisp/progmodes/ada-mode.el (ada-compile-goto-error): * lisp/progmodes/cperl-mode.el (cperl-highlight-charclass) (cperl-find-pods-heres, cperl-not-bad-style-regexp) (cperl-regext-to-level-start): * lisp/progmodes/ebnf-yac.el (ebnf-yac-skip-spaces): * lisp/progmodes/flymake-proc.el (flymake-proc-master-tex-init): * lisp/progmodes/flymake.el (flymake-diag-region): * lisp/progmodes/fortran.el (fortran-current-line-indentation): * lisp/progmodes/idlw-complete-structtag.el: (idlwave-complete-structure-tag): * lisp/progmodes/idlwave.el (idlwave-complete-sysvar-or-tag): * lisp/progmodes/prolog.el (prolog-pred-end) (prolog-clause-info): * lisp/progmodes/ruby-mode.el (ruby-forward-sexp) (ruby-backward-sexp): * lisp/progmodes/verilog-mode.el (verilog-repair-open-comma): * lisp/term.el (term-within-quotes): * lisp/textmodes/bib-mode.el (bib-capitalize-title-stop-words): * lisp/textmodes/refbib.el (r2b-capitalize-title-stop-words): * lisp/textmodes/reftex-parse.el (reftex-nth-arg): * lisp/textmodes/rst.el (rst-svn-rev): * lisp/url/url-http.el (url-http-parse-response): * test/lisp/progmodes/f90-tests.el (f90-test-bug3730): Fix regular expression typos.
2019-03-18 17:02:01 -07:00
"[ \t]*in\\(?:put\\|clude\\)[ \t]*{\\(.*%s\\)}")))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(when temp-master-file-name
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(flymake-proc--get-tex-args temp-master-file-name))))
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc--get-include-dirs-dot (_base-dir)
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
'("."))
;;;; xml-specific init-cleanup routines
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
(defun flymake-proc-xml-init ()
(list flymake-proc-xml-program
(list "val" (flymake-proc-init-create-temp-buffer-copy
'flymake-proc-create-temp-inplace))))
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
;;;; Hook onto flymake-ui
Flymake variable flymake-diagnostic-functions now a special hook * lisp/progmodes/flymake-proc.el: Use add-hook to affect flymake-diagnostic-functions. * lisp/progmodes/flymake-elisp.el (flymake-elisp-setup-backends): Use add-hook. * lisp/progmodes/flymake.el (flymake-diagnostic-functions): Revise docstring. (flymake-start): Use run-hook-wrapped.
2017-09-29 12:18:30 +01:00
(add-hook 'flymake-diagnostic-functions 'flymake-proc-legacy-flymake)
New Flymake API variable flymake-diagnostic-functions Lay groundwork for multiple active backends in the same buffer. Backends are lisp functions called when flymake-mode sees fit. They are responsible for examining the current buffer and telling flymake.el, via return value, if they can syntax check it. Backends should return quickly and inexpensively, but they are also passed a REPORT-FN argument which they may or may not call asynchronously after performing more expensive work. REPORT-FN's calling convention stipulates that a backend calls it with a list of diagnostics as argument, or, alternatively, with a symbol denoting an exceptional situation, usually some panic resulting from a misconfigured backend. In keeping with legacy behaviour, flymake.el's response to a panic is to disable the issuing backend. The flymake--diag object representing a diagnostic now also keeps information about its source backend. Among other uses, this allows flymake to selectively cleanup overlays based on which backend is updating its diagnostics. * lisp/progmodes/flymake-proc.el (flymake-proc--report-fn): New dynamic variable. (flymake-proc--process): New variable. (flymake-can-syntax-check-buffer): Remove. (flymake-proc--process-sentinel): Simplify. Use unwind-protect. Affect flymake-proc--processes here. Bind flymake-proc--report-fn. (flymake-proc--process-filter): Bind flymake-proc--report-fn. (flymake-proc--post-syntax-check): Delete (flymake-proc-start-syntax-check): Take mandatory report-fn. Rewrite. Bind flymake-proc--report-fn. (flymake-proc--process-sentinel): Rewrite and simplify. (flymake-proc--panic): New helper. (flymake-proc--start-syntax-check-process): Record report-fn in process. Use flymake-proc--panic. (flymake-proc-stop-all-syntax-checks): Use mapc. Don't affect flymake-proc--processes here. Record interruption reason. (flymake-proc--init-find-buildfile-dir) (flymake-proc--init-create-temp-source-and-master-buffer-copy): Use flymake-proc--panic. (flymake-diagnostic-functions): Add flymake-proc-start-syntax-check. (flymake-proc-compile): Call flymake-proc-stop-all-syntax-checks with a reason. * lisp/progmodes/flymake.el (flymake-backends): Delete. (flymake-check-was-interrupted): Delete. (flymake--diag): Add backend slot. (flymake-delete-own-overlays): Take optional filter arg. (flymake-diagnostic-functions): New user-visible variable. (flymake--running-backends, flymake--disabled-backends): New buffer-local variables. (flymake-is-running): Now a function, not a variable. (flymake-mode-line, flymake-mode-line-e-w) (flymake-mode-line-status): Delete. (flymake-lighter): flymake's minor-mode "lighter". (flymake-report): Delete. (flymake--backend): Delete. (flymake--can-syntax-check-buffer): Delete. (flymake--handle-report, flymake--disable-backend) (flymake--run-backend, flymake--run-backend): New helpers. (flymake-make-report-fn): Make a lambda. (flymake--start-syntax-check): Iterate flymake-diagnostic-functions. (flymake-mode): Use flymake-lighter. Simplify. Initialize flymake--running-backends and flymake--disabled-backends. (flymake-find-file-hook): Simplify. * test/lisp/progmodes/flymake-tests.el (flymake-tests--call-with-fixture): Use flymake-is-running the function. Check if flymake-mode already active before activating it. Add a thorough test for flymake multiple backends * lisp/progmodes/flymake.el (flymake--start-syntax-check): Don't use condition-case-unless-debug, use condition-case * test/lisp/progmodes/flymake-tests.el (flymake-tests--assert-set): New helper macro. (dummy-backends): New test.
2017-09-26 00:45:46 +01:00
Move symbols in flymake-proc.el to separate namespace Every symbol in this flymake now starts with the prefix flymake-proc-. Make obsolete aliases for (almost?) every symbol. Furthermore, many flymake-proc.el symbols are prefixed with "flymake-proc--", that is they were considered internal. Some customization variables, interactive functions, and other symbols considered useful to user customizations or third-party libraries are considered "public" or "external" and so use a "flymake-proc-" prefix. * lisp/progmodes/flymake-proc.el: Every symbol renamed. * test/lisp/progmodes/flymake-tests.el (flymake-tests--current-face): Use flymake-proc-warning-predicate, not flymake-warning-predicate. * lisp/progmodes/flymake-proc.el (flymake-proc--get-project-include-dirs-function) (flymake-proc--get-project-include-dirs-imp) (flymake-proc--get-include-dirs-dot) (flymake-proc--get-tex-args) (flymake-proc--find-make-buildfile) (flymake-proc--get-syntax-check-program-args) (flymake-proc--init-create-temp-source-and-master-buffer-copy) (flymake-proc--init-find-buildfile-dir) (flymake-proc--get-full-nonpatched-file-name) (flymake-proc--get-full-patched-file-name) (flymake-proc--base-dir, flymake-proc--temp-master-file-name) (flymake-proc--master-file-name) (flymake-proc--temp-source-file-name) (flymake-proc--delete-temp-directory) (flymake-proc--kill-process) (flymake-proc--start-syntax-check-process) (flymake-proc--compilation-is-running) (flymake-proc--safe-delete-directory) (flymake-proc--safe-delete-file) (flymake-proc--get-program-dir) (flymake-proc--restore-formatting) (flymake-proc--clear-project-include-dirs-cache) (flymake-proc--project-include-dirs-cache) (flymake-proc--get-system-include-dirs) (flymake-proc--get-project-include-dirs) (flymake-proc--add-project-include-dirs-to-cache) (flymake-proc--get-project-include-dirs-from-cache) (flymake-proc--post-syntax-check) (flymake-proc--process-sentinel) (flymake-proc--process-filter) (flymake-proc--create-master-file) (flymake-proc--find-buffer-for-file) (flymake-proc--copy-buffer-to-temp-buffer) (flymake-proc--read-file-to-temp-buffer) (flymake-proc--save-buffer-in-file) (flymake-proc--replace-region, flymake-proc--check-include) (flymake-proc--check-patch-master-file-buffer) (flymake-proc--master-file-compare) (flymake-proc--find-possible-master-files) (flymake-proc--included-file-name, flymake-proc--same-files) (flymake-proc--fix-file-name, flymake-proc--find-buildfile) (flymake-proc--clear-buildfile-cache) (flymake-proc--add-buildfile-to-cache) (flymake-proc--get-buildfile-from-cache) (flymake-proc--find-buildfile-cache) (flymake-proc--get-real-file-name-function) (flymake-proc--get-cleanup-function) (flymake-proc--get-init-function) (flymake-proc--get-file-name-mode-and-masks) (flymake-proc--processes): Rename to internal symbol from flymake-proc- version.
2017-08-23 23:18:05 +01:00
;;;;
Fix some flymake aliases * lisp/progmodes/flymake-proc.el (flymake-xml-program) (flymake-compilation-prevents-syntax-check, flymake-master-file-dirs) (flymake-master-file-count-limit, flymake-allowed-file-name-masks): * lisp/progmodes/flymake.el (flymake-start-syntax-check-on-find-file): Define aliases to user options before the options are defined.
2017-12-20 14:31:03 -05:00
(define-obsolete-function-alias 'flymake-reformat-err-line-patterns-from-compile-el
'flymake-proc-reformat-err-line-patterns-from-compile-el "26.1")
(define-obsolete-function-alias 'flymake-parse-line
'flymake-proc-parse-line "26.1")
(define-obsolete-function-alias 'flymake-get-include-dirs
'flymake-proc-get-include-dirs "26.1")
(define-obsolete-function-alias 'flymake-stop-all-syntax-checks
'flymake-proc-stop-all-syntax-checks "26.1")
(define-obsolete-function-alias 'flymake-compile
'flymake-proc-compile "26.1")
(define-obsolete-function-alias 'flymake-create-temp-inplace
'flymake-proc-create-temp-inplace "26.1")
(define-obsolete-function-alias 'flymake-create-temp-with-folder-structure
'flymake-proc-create-temp-with-folder-structure "26.1")
(define-obsolete-function-alias 'flymake-init-create-temp-buffer-copy
'flymake-proc-init-create-temp-buffer-copy "26.1")
(define-obsolete-function-alias 'flymake-simple-cleanup
'flymake-proc-simple-cleanup "26.1")
(define-obsolete-function-alias 'flymake-get-real-file-name
'flymake-proc-get-real-file-name "26.1")
(define-obsolete-function-alias 'flymake-master-cleanup
'flymake-proc-master-cleanup "26.1")
(define-obsolete-function-alias 'flymake-get-make-cmdline
'flymake-proc-get-make-cmdline "26.1")
(define-obsolete-function-alias 'flymake-get-ant-cmdline
'flymake-proc-get-ant-cmdline "26.1")
(define-obsolete-function-alias 'flymake-simple-make-init-impl
'flymake-proc-simple-make-init-impl "26.1")
(define-obsolete-function-alias 'flymake-simple-make-init
'flymake-proc-simple-make-init "26.1")
(define-obsolete-function-alias 'flymake-master-make-init
'flymake-proc-master-make-init "26.1")
(define-obsolete-function-alias 'flymake-find-make-buildfile
'flymake-proc--find-make-buildfile "26.1")
(define-obsolete-function-alias 'flymake-master-make-header-init
'flymake-proc-master-make-header-init "26.1")
(define-obsolete-function-alias 'flymake-simple-make-java-init
'flymake-proc-simple-make-java-init "26.1")
(define-obsolete-function-alias 'flymake-simple-ant-java-init
'flymake-proc-simple-ant-java-init "26.1")
(define-obsolete-function-alias 'flymake-simple-java-cleanup
'flymake-proc-simple-java-cleanup "26.1")
(define-obsolete-function-alias 'flymake-perl-init
'flymake-proc-perl-init "26.1")
(define-obsolete-function-alias 'flymake-php-init
'flymake-proc-php-init "26.1")
(define-obsolete-function-alias 'flymake-simple-tex-init
'flymake-proc-simple-tex-init "26.1")
(define-obsolete-function-alias 'flymake-master-tex-init
'flymake-proc-master-tex-init "26.1")
(define-obsolete-function-alias 'flymake-xml-init
'flymake-proc-xml-init "26.1")
Split Flymake into flymake.el into flymake-proc.el (again!) After deciding that this work would continue on master only, which caused two commits named Revert "Split flymake.el into flymake-proc.el and flymake-ui.el" and Revert "Add flymake-backends defcustom" to be added to the emacs-26 branch, further discussion reversed that decision. See: https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01020.html https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg01030.html This means that those two commits MUST be merged to master AFTER ALL. flymke-proc.el contains the main syntax-checking backend, while flymake.el keeps mostly the UI part. * lisp/progmodes/flymake-proc.el: New file. Require flymake. * lisp/progmodes/flymake.el: Require flymake-proc.el at the end.
2017-08-17 15:38:12 +01:00
(provide 'flymake-proc)
;;; flymake-proc.el ends here
Reference in a new issue Copy permalink