Stefan Kangas
7c68c84674
Silence byte-compiler in some tests
...
* test/lisp/dired-tests.el:
* test/lisp/emacs-lisp/cl-macs-tests.el:
* test/lisp/emacs-lisp/derived-tests.el:
* test/lisp/emacs-lisp/eieio-tests/eieio-tests.el:
* test/lisp/emacs-lisp/generator-tests.el:
* test/lisp/emacs-lisp/lisp-tests.el:
* test/lisp/emacs-lisp/seq-tests.el (test-seq-let)
(test-seq-setq):
* test/lisp/emacs-lisp/subr-x-tests.el (subr-x-test-if-let*-false)
(subr-x-test-if-let*-and-laziness-is-preserved)
(subr-x-test-when-let*-false)
(subr-x-test-when-let*-and-laziness-is-preserved):
* test/lisp/emacs-lisp/timer-tests.el
(timer-tests-debug-timer-check):
* test/lisp/format-spec-tests.el (format-spec-do-flags-truncate)
(format-spec-do-flags-pad):
* test/lisp/ls-lisp-tests.el (ls-lisp-test-bug27762):
* test/lisp/obsolete/cl-tests.el (labels-function-quoting):
* test/lisp/progmodes/elisp-mode-tests.el:
* test/lisp/replace-tests.el (replace-regexp-bug45973):
* test/lisp/ses-tests.el:
* test/lisp/subr-tests.el:
* test/lisp/tar-mode-tests.el (tar-mode-test-tar-grind-file-mode):
* test/src/data-tests.el (data-tests--set-default-per-buffer):
* test/src/search-tests.el
(test-replace-match-modification-hooks): Silence byte-compiler.
2021-12-04 15:49:42 +01:00
Stefan Kangas
a3a3d3dd07
Make 'eval' use lexical scoping in most tests
...
* test/lisp/electric-tests.el (electric-pair-define-test-form)
(define-electric-pair-test):
* test/lisp/emacs-lisp/backtrace-tests.el
(backtrace-tests--uncompiled-functions):
* test/lisp/emacs-lisp/cl-macs-tests.el
(cl-macs-test--symbol-macrolet):
* test/lisp/emacs-lisp/let-alist-tests.el
(let-alist-list-to-sexp):
* test/lisp/emacs-lisp/lisp-tests.el
(elisp-tests-with-temp-buffer, core-elisp-tests-3-backquote):
* test/lisp/emacs-lisp/testcover-resources/testcases.el
(testcover-testcase-nth-case):
* test/lisp/ffap-tests.el (ffap-ido-mode):
* test/lisp/files-tests.el (file-test--do-local-variables-test):
* test/lisp/net/tramp-tests.el (tramp--test-utf8):
* test/lisp/progmodes/elisp-mode-tests.el
(find-defs-defgeneric-eval, find-defs-defun-eval)
(find-defs-defvar-eval, find-defs-face-eval)
(find-defs-feature-eval): Give 'eval' non-nil LEXICAL argument.
* test/lisp/subr-tests.el
(subr-tests--dolist--wrong-number-of-args):
* test/src/eval-tests.el (eval-tests--if-dot-string)
(eval-tests--mutating-cond)
(eval-tests-19790-backquote-comma-dot-substitution): Test 'eval'
using LEXICAL as both nil and non-nil.
(eval-tests--let-with-circular-defs): Give explicit nil to 'eval'.
2021-11-20 12:55:37 +01:00
Lars Ingebrigtsen
de477ec683
Add new 'keymap-*' functions
...
* lisp/keymap.el: New file with all the new keymap-* functions.
* lisp/loadup.el ("keymap"): Load.
* lisp/subr.el (kbd): Refactor out all the code to key-parse.
(define-key-after, keyboard-translate, global-set-key)
(local-set-key, global-unset-key, local-unset-key)
(local-key-binding, global-key-binding)
(substitute-key-definition): Note in doc strings that these are
legacy functions.
(define-keymap--define): Use keymap-set.
* lisp/emacs-lisp/byte-opt.el: Remove the optimizations for
defvar-keymap and define-keymap since the macros now only
understand the kbd syntax.
* lisp/emacs-lisp/bytecomp.el (byte-compile-define-keymap)
(byte-compile-define-keymap--define): Warn about invalid key
definitions in all keymap-* functions.
* lisp/emacs-lisp/shortdoc.el (keymaps): Add shortdocs form
keymap* functions.
* src/keymap.c (possibly_translate_key_sequence): Adjust callers
to key-valid-p and key-parse.
(syms_of_keymap): Adjust defs.
2021-11-16 08:26:24 +01:00
Lars Ingebrigtsen
595dcf88fd
Do kbd-valid-p prefix comparisons case-sensitively
...
* lisp/subr.el (kbd-valid-p): Compare case-sensitively.
2021-10-18 07:37:08 +02:00
Lars Ingebrigtsen
c0f5987ffd
Allow <mouse-1> in kbd-valid-p
...
* lisp/subr.el (kbd-valid-p): Allow (kbd-valid-p "<mouse-1>").
2021-10-17 21:49:43 +02:00
Lars Ingebrigtsen
4c468c6b3c
Add new function 'kbd-valid-p'
...
* doc/lispref/keymaps.texi (Key Sequences): New function
'kbd-valid-p'.
* lisp/subr.el (kbd-valid-p): Document it.
2021-10-16 17:50:40 +02:00
Stefan Kangas
845640538e
New tests for kbd and edmacro-parse-keys
...
* test/lisp/edmacro-tests.el: New file.
* test/lisp/subr-tests.el (subr-test-kbd): Expand test.
2021-10-13 23:40:50 +02:00
Glenn Morris
e0fdb68f8c
Merge from origin/emacs-28
...
3b8dda6c90e1fb731393595e506c82d00f3d4c05317eb2d5b5c0793cd9de87153cc9157e871dcd272a006348806d9b3c0eaafd274d7d24cc3fc94f09d3a832a61a48314261580bb42ef803732c70a0d9fc32a3bd953cc77aa9765deeb0947d121a5abeae0c341e6e84931a7276c03863919a007a6d34cd1fc1b1e1f545137fa2d716e6fbc45b7b17e6f3bee53dae1e33d1b228ec9fab7fb2789509b47d7ce1b8b1a8a66fb06c01a2136555dadbc57ebb209cd5ab4341e79a5fb6f6b593c662d6cecfcdf9111d87843dc094abeea5b4356d377bc0cee115348947141713e5943386bd60fca2fa340e527beda9052248dad5059718949307889d685c77cc9584
2021-10-04 08:13:11 -07:00
Stefan Kangas
6c01a21365
Clarify the purpose of internal--format-docstring-line
...
* test/lisp/subr-tests.el (subr-test-internal--format-docstring-line):
* lisp/subr.el (internal--format-docstring-line): Make it more clear
that this function is not intended for the first line of a docstring.
* lisp/emacs-lisp/cl-macs.el (cl-defstruct): Add comment explaining
why we use 'internal--format-docstring-line'.
Problem pointed out by Stefan Monnier <monnier@iro.umontreal.ca>.
2021-10-03 01:59:52 +02:00
Stefan Kangas
ea3e51732d
Expand internal--format-docstring-line test
...
* test/lisp/subr-tests.el (subr-test-internal--format-docstring-line):
Check for error on newline.
2021-10-02 16:20:06 +02:00
Stefan Kangas
3d2d7e8ea2
Fix automatic filling of docstring in cl-defstruct
...
* lisp/emacs-lisp/cl-macs.el (cl-defstruct): Fix bug where a paragraph
was filled as if it were a single line, which led to garbled
output in the docstring. (Bug#50839)
* test/lisp/subr-tests.el
(subr-test-internal--format-docstring-line): New test.
2021-09-27 11:47:55 +02:00
Lars Ingebrigtsen
85e9e5f616
Don't quote nil and t in doc strings and comments
...
* test/src/minibuf-tests.el (test-try-completion-ignore-case):
* test/lisp/url/url-auth-tests.el
(url-auth-test-digest-auth-retrieve-cache):
* test/lisp/subr-tests.el (subr-tests-add-hook-depth):
* test/lisp/so-long-tests/so-long-tests.el
(so-long-tests-invisible-buffer-function):
* test/lisp/emacs-lisp/tabulated-list-test.el (tabulated-list-sort):
* src/xfaces.c:
* src/process.c (Finterrupt_process):
(syms_of_process):
* src/minibuf.c (Fread_from_minibuffer):
(Fcompleting_read):
(syms_of_minibuf):
* src/dispnew.c (syms_of_display):
* src/data.c:
* lisp/so-long.el (so-long--hack-local-variables):
* lisp/progmodes/elisp-mode.el (elisp--xref-find-definitions):
(elisp--xref-find-definitions):
* lisp/org/ox-html.el (org-html-htmlize-output-type):
* lisp/org/org-agenda.el (org-agenda-do-in-region):
* lisp/net/tramp.el:
* lisp/minibuffer.el (set-minibuffer-message):
* lisp/isearch.el (isearch-wrap-pause):
(isearch-repeat-on-direction-change):
* lisp/emacs-lisp/timer.el (timer):
* lisp/emacs-lisp/package.el (package-read-archive-contents):
* lisp/emacs-lisp/faceup.el (faceup-next-property-change):
* lisp/emacs-lisp/comp.el (comp-func):
* lisp/emacs-lisp/comp-cstr.el (comp-cstr-empty-p):
* lisp/emacs-lisp/cl-macs.el (cl-do):
(cl-do*):
(cl--self-tco):
* lisp/emacs-lisp/bytecomp.el (byte-compile-unresolved-functions):
(byte-compile-cond-jump-table): Don't quote t and nil.
2021-09-21 22:11:43 +02:00
Lars Ingebrigtsen
be4f858498
Add new function `ensure-list'
...
* doc/lispref/lists.texi (Building Lists): Document it.
* lisp/subr.el (ensure-list): New function.
* lisp/emacs-lisp/shortdoc.el (list): Mention it.
2021-09-21 20:31:05 +02:00
Stefan Kangas
07e8ff7f0f
Move cl-lib tests for caaXr to subr-tests.el
...
* test/lisp/emacs-lisp/cl-lib-tests.el (cl-test-caaar)
(cl-test-caadr): Move tests using a cl-lib alias from here...
* test/lisp/subr-tests.el (subr-test-caaar, subr-test-caadr): ...to
here. The functions under test are in subr.el.
2021-09-03 10:18:54 +02:00
Lars Ingebrigtsen
6a6de68daf
Add new macro `with-existing-directory'
...
* doc/lispref/files.texi (Testing Accessibility): Document it.
* lisp/subr.el (with-existing-directory): New macro (bug#32004).
2021-09-01 15:56:04 +02:00
Lars Ingebrigtsen
751f1707f0
Add new functions to replace strings/regexp in a region
...
* doc/lispref/searching.texi (Search and Replace): Document them.
* lisp/subr.el (replace-string-in-region)
(replace-regexp-in-region): New functions.
* lisp/emacs-lisp/shortdoc.el (regexp, buffer): Mention them.
2021-08-16 13:20:35 +02:00
Philipp Stephani
f2896fdb6a
; * test/lisp/subr-tests.el (subr-tests-add-hook-depth): Fix a typo.
2021-07-05 20:34:55 +02:00
Lars Ingebrigtsen
77f67d12f6
Add new convenience function `buffer-local-boundp'
...
* doc/lispref/variables.texi (Creating Buffer-Local): Document it.
* lisp/subr.el (buffer-local-boundp): New function.
* src/data.c (Flocal_variable_p): Mention it.
2021-05-31 07:21:09 +02:00
Lars Ingebrigtsen
bd5aebce03
Fix failing subr test
...
* test/lisp/subr-tests.el (subr-tests-bug22027): Fix mocked
signature of `read-string' (bug#48022).
2021-04-27 01:31:52 +02:00
Andrea Corallo
82bd6d57d5
Merge remote-tracking branch 'savannah/master' into native-comp
2021-03-12 16:42:51 +01:00
Basil L. Contovounesios
8558ecd65f
Fix string-replace error data
...
* lisp/subr.el (string-replace): Signal an error with data that is a
list, and whose contents are consistent with other uses of
wrong-length-argument.
* test/lisp/subr-tests.el (string-replace): Test for this.
(subr-test-define-prefix-command): Pacify byte-compiler warnings.
2021-03-07 14:55:15 +00:00
Andrea Corallo
0a7ac0b550
Merge remote-tracking branch 'savannah/master' into native-comp
2021-01-16 13:26:10 +01:00
Stefan Kangas
a9658cd5b0
Lift {global,local}-key-binding to Lisp
...
* lisp/subr.el (local-key-binding, global-key-binding): New defuns.
* src/keymap.c (Flocal_key_binding, Fglobal_key_binding): Remove DEFUNs.
(syms_of_keymap): Remove defsubrs for above DEFUNs.
* test/lisp/subr-tests.el (subr-test-local-key-binding)
(subr-test-global-key-binding): New tests.
2021-01-13 18:54:09 +01:00
Stefan Monnier
3b9dad88e0
* lisp/subr.el (letrec): Optimize some non-recursive bindings
...
* lisp/emacs-lisp/macroexp.el (macroexp--fgrep): Look inside bytecode
objects as well.
* test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs--labels):
* test/lisp/subr-tests.el (subr--tests-letrec): New tests.
2021-01-08 18:44:13 -05:00
Andrea Corallo
400f620f24
Merge remote-tracking branch 'savannah/master' into HEAD
2021-01-08 21:40:45 +01:00
Stefan Kangas
a31bfd5945
Merge recently added kbd tests
...
* test/lisp/subr-tests.el (subr--kbd): Merge test...
(subr-test-kbd): ...with this one. Fix thinko in my previous commit.
Thanks to Mattias Engdegård <mattiase@acm.org>.
2021-01-08 15:26:11 +01:00
Stefan Kangas
5ac7b48075
Lift define-prefix-command to Lisp
...
* lisp/subr.el (define-prefix-command): New defun.
* src/keymap.c (Fdefine_prefix_command): Remove DEFUN.
(syms_of_keymap): Remove defsubr for Fdefine_prefix_command.
* test/lisp/subr-tests.el (subr-test-define-prefix-command): New
test.
2021-01-08 15:16:02 +01:00
Stefan Kangas
f5cfe5a0a9
* test/lisp/subr-tests.el (subr-test-kbd): New test.
2021-01-08 14:00:42 +01:00
Mattias Engdegård
7f16f17727
Pretty-print keys without <> around modifiers (bug#45536)
...
Be consistent when pretty-printing keys: put modifiers outside <>,
thus the more logical C-M-<return> instead of <C-M-return>.
* src/keymap.c (Fsingle_key_description):
Skip modifier prefix before adding <>.
* doc/lispref/help.texi (Describing Characters): Update example.
* doc/lispref/debugging.texi (Backtraces):
* doc/lispref/minibuf.texi (Text from Minibuffer):
Use @kbd instead of @key.
* etc/NEWS: Announce the change.
* test/src/keymap-tests.el (keymap--key-description):
* test/lisp/subr-tests.el (subr--kbd): New tests.
2021-01-05 11:28:58 +01:00
Andrea Corallo
5db5064395
Merge remote-tracking branch 'savannah/master' into HEAD
2021-01-02 10:11:15 +01:00
Paul Eggert
ba05d005e5
Update copyright year to 2021
...
Run "TZ=UTC0 admin/update-copyright".
2021-01-01 01:13:56 -08:00
Lars Ingebrigtsen
d22e74795d
Revert recent add-to-ordered-list changes
...
* doc/lispref/lists.texi (List Variables): Revert.
* lisp/subr.el (add-to-ordered-list): Revert recent changes
because the semantics are too muddled.
2021-01-01 05:48:02 +01:00
Lars Ingebrigtsen
b1ac23ebef
Allow add-to-ordered-list to use a test predicate
...
* doc/lispref/lists.texi (List Variables): Update manual.
* lisp/subr.el (add-to-ordered-list): Allow using a test
predicate, and make slightly more efficient (bug#45539).
2020-12-31 05:28:47 +01:00
Lars Ingebrigtsen
3d9f20cfcf
Add test for add-to-ordered-list
2020-12-31 05:00:45 +01:00
Andrea Corallo
f244c21902
Merge remote-tracking branch 'savannah/master' into HEAD
2020-12-20 22:08:42 +01:00
Stefan Kangas
7c3d3b8335
Convert apropos-internal from C to Lisp (Bug#44529)
...
This runs insignificantly faster in C, and is already fast enough on
reasonably modern hardware. We might as well lift it to Lisp.
This benchmark can be used to verify:
(benchmark-run 10 (apropos-command "test"))
=> (0.12032415399999999 2 0.014772391999999995) ; C
=> (0.13513192100000002 2 0.017216643000000004) ; Lisp
* lisp/subr.el (apropos-internal): New defun, converted from C.
* src/keymap.c (Fapropos_internal): Remove defun.
(apropos_accum): Remove function.
(apropos_predicate, apropos_accumulate): Remove variables.
(syms_of_keymap): Remove defsubr for Fapropos_internal, and
definitions of the above variables.
* test/src/keymap-tests.el (keymap-apropos-internal)
(keymap-apropos-internal/predicate): Move tests from here...
* test/lisp/subr-tests.el (apropos-apropos-internal)
(apropos-apropos-internal/predicate): ...to here.
2020-12-19 19:54:46 +01:00
Andrea Corallo
715a1ca174
Merge remote-tracking branch 'savannah/master' into HEAD
2020-12-06 18:07:27 +01:00
Mattias Engdegård
7bdc40e8d1
Speed up match-substitute-replacement
...
* lisp/subr.el (match-substitute-replacement): Use match-data--translate.
* src/search.c (Fmatch_data__translate): Remove string restriction.
* test/lisp/subr-tests.el (subr-match-substitute-replacement): New test.
2020-12-04 18:39:13 +01:00
Andrea Corallo
6523b84015
Merge remote-tracking branch 'savannah/master' into HEAD
2020-11-29 15:11:38 +01:00
Stefan Monnier
1f633311c1
* lisp/subr.el (activate-change-group): Refine fix for bug#33341
2020-11-27 10:19:21 -05:00
Stefan Monnier
66eeaaa488
* lisp/subr.el (activate-change-group): Fix bug#33341
2020-11-27 09:43:56 -05:00
Mattias Engdegård
558b6dbca7
Fix replace-regexp-in-string substring match data translation
...
For certain patterns, re-matching the same regexp on the matched
substring does not produce correctly translated match data
(bug#15107 and bug#44861).
Using a new builtin function also improves performance since the
number of calls to string-match is halved.
Reported by Kevin Ryde and Shigeru Fukaya.
* lisp/subr.el (replace-regexp-in-string): Translate the match data
using match-data--translate instead of trusting a call to string-match
on the matched string to do the job.
* test/lisp/subr-tests.el (subr-replace-regexp-in-string):
Add test cases.
* src/search.c (Fmatch_data__translate): New internal function.
(syms_of_search): Register it as a subroutine.
2020-11-26 14:20:13 +01:00
Mattias Engdegård
d148d0259a
Add tests for replace-regexp-in-string
...
* test/lisp/subr-tests.el (subr-replace-regexp-in-string): New.
2020-11-25 13:57:16 +01:00
Andrea Corallo
29f7024b6c
* Fix a test in test/lisp/subr-tests.el
...
* test/lisp/subr-tests.el (subr-tests-bug22027): Redefine
`read-string' with a lambda with the same number of arguments.
2020-10-05 21:33:04 +02:00
Andrea Corallo
b3ade4de17
Revert "Use advice-flet' in place of cl-letf' to avoid primitive...
...
This reverts commit 825e85b393
2020-10-05 21:32:35 +02:00
Andrea Corallo
825e85b393
Use advice-flet' in place of cl-letf' to avoid primitive redefinition
...
* test/lisp/time-stamp-tests.el (with-time-stamp-system-name): Use
`advice-flet' to advice primitive avoiding redefinition.
* test/lisp/tempo-tests.el (tempo-p-element-test)
(tempo-P-element-test, tempo-r-element-test)
(tempo-s-element-test, tempo-r>-element-test): Likewise.
* test/lisp/subr-tests.el (subr-tests-bug22027): Likewise.
* test/lisp/shadowfile-tests.el (shadow-test00-clusters)
(shadow-test01-sites, shadow-test06-literal-groups)
(shadow-test07-regexp-groups): Likewise.
* test/lisp/replace-tests.el (replace-tests-with-undo): Likewise.
* test/lisp/play/dissociate-tests.el
(dissociate-tests-dissociated-press): Likewise.
* test/lisp/net/tramp-tests.el (tramp-test10-write-region)
(tramp-test21-file-links): Likewise.
* test/lisp/kmacro-tests.el (kmacro-tests-call-macro-hint-and-repeat)
(kmacro-tests-repeat-on-last-key)
(kmacro-tests-repeat-view-and-run)
(kmacro-tests-bind-to-key-with-key-sequence-in-use): Likewise.
* test/lisp/files-tests.el (files-tests-read-file-in-~): Likewise.
* test/lisp/emacs-lisp/rmc-tests.el (test-read-multiple-choice):
Likewise.
* test/lisp/bookmark-tests.el (bookmark-test-bmenu-locate):
Likewise.
* test/lisp/abbrev-tests.el
(inverse-add-abbrev-skips-trailing-nonword)
(inverse-add-abbrev-skips-trailing-nonword/positive-arg)
(inverse-add-abbrev-skips-trailing-nonword/negative-arg): Likewise.
2020-10-02 21:20:53 +02:00
Mattias Engdegård
72e9ec96d0
; * test/lisp/subr-tests.el (string-replace): Add more test cases
2020-09-27 13:32:27 +02:00
Lars Ingebrigtsen
104688feb4
Add tiny optimization for string-search
...
* src/fns.c (Fstring_search): Add tiny optimization for needles
that are longer than the haystack (bug#43598).
2020-09-27 00:35:11 +02:00
Lars Ingebrigtsen
baf331e40c
Rename replace-in-string to string-replace
...
* doc/lispref/searching.texi (Search and Replace): Update.
* lisp/bindings.el (mode-line-position): Update callers.
* lisp/subr.el (string-replace): Rename from replace-in-string
since that clashes with XEmacs' replace-in-string which is
equivalent to the Emacs replace-regexp-in-string (bug#43598).
2020-09-27 00:24:50 +02:00
Mattias Engdegård
8a253a96a0
Fix replace-in-string infloop with empty pattern string (bug#43598)
...
* lisp/subr.el (replace-in-string): Raise an error if FROMSTRING is
empty.
* test/lisp/subr-tests.el (replace-in-string): Add test case.
2020-09-25 13:15:42 +02:00
