masscollaborationlabs/emacs
2
0
Fork 0
mirror of https://github.com/masscollaborationlabs/emacs.git synced 2025-07-05 11:49:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Document internal use of 'above-suspended' z-group frame parameter

Browse source 
* src/w32fns.c (w32_dialog_in_progress, x_set_z_group):
* src/xterm.c (x_set_z_group): Clarify the internal use of
'above-suspended' when setting a frame's 'z-group' parameter.
This commit is contained in:
Martin Rudalics 2018-07-01 10:22:59 +02:00
parent 4bd43b0352
commit 4e58ca87f9
2 changed files with 25 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/w32fns.c
View file

@ -2192,6 +2192,11 @@ x_set_no_accept_focus (struct frame *f, Lisp_Object new_value, Lisp_Object old_v
* *
* Some window managers may not honor this parameter. The value `below' * Some window managers may not honor this parameter. The value `below'
* is not supported on Windows. * is not supported on Windows.
*
* Internally, this function also handles a value 'above-suspended'.
* That value is used to temporarily remove F from the 'above' group
* to make sure that it does not obscure the window of a dialog in
* progress.
*/ */
static void static void
x_set_z_group (struct frame *f, Lisp_Object new_value, Lisp_Object old_value) x_set_z_group (struct frame *f, Lisp_Object new_value, Lisp_Object old_value)
@ -7726,12 +7731,27 @@ file_dialog_callback (HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
return 0; return 0;
} }
/**
* w32_dialog_in_progress:
*
* This function is called by Fx_file_dialog and Fx_select_font and
* serves to temporarily remove any Emacs frame currently in the
* 'above' z-group from that group to assure that such a frame does
* not hide the dialog window. Frames that are temporarily removed
* from the 'above' group have their z_group bit-field set to
* z_group_above_suspended. Any such frame is moved back to the
* 'above' group as soon as the dialog finishes and has its z_group
* bit-field reset to z_group_above.
*
* This function does not affect the z-order or the z-group state of
* the dialog window itself.
*/
void void
w32_dialog_in_progress (Lisp_Object in_progress) w32_dialog_in_progress (Lisp_Object in_progress)
{ {
Lisp_Object frames, frame; Lisp_Object frames, frame;
/* Don't let frames in `above' z-group obscure popups. */ /* Don't let frames in `above' z-group obscure dialog windows. */
FOR_EACH_FRAME (frames, frame) FOR_EACH_FRAME (frames, frame)
{ {
struct frame *f = XFRAME (frame); struct frame *f = XFRAME (frame);

4
src/xterm.c
View file

@ -10560,6 +10560,10 @@ x_set_skip_taskbar (struct frame *f, Lisp_Object new_value, Lisp_Object old_valu
* windows that do not have the `below' property set. * windows that do not have the `below' property set.
* *
* Some window managers may not honor this parameter. * Some window managers may not honor this parameter.
*
* Internally, this function also handles a value 'above-suspended'.
* That value is used to temporarily remove F from the 'above' group
* to make sure that it does not obscure a menu currently popped up.
*/ */
void void
x_set_z_group (struct frame *f, Lisp_Object new_value, Lisp_Object old_value) x_set_z_group (struct frame *f, Lisp_Object new_value, Lisp_Object old_value)