masscollaborationlabs/emacs
2
0
Fork 0
mirror of https://github.com/masscollaborationlabs/emacs.git synced 2025-07-17 17:29:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix menu keyboard shortcuts on macOS (Bug#29595)

Browse source 
* src/nsmenu.m (addItemWithWidgetValue)[NS_IMPL_COCOA]: It looks like
macOS 10.13 no longer ignores long modifier strings, so explicitly use
an empty string.
This commit is contained in:
Alan Third 2017-12-22 12:27:05 +00:00
parent 30d6c31301
commit 4e20c8f220
1 changed files with 15 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/nsmenu.m
View file

@ -643,14 +643,23 @@ - (NSMenuItem *)addItemWithWidgetValue: (void *)wvptr
keyEq = [self parseKeyEquiv: wv->key]; keyEq = [self parseKeyEquiv: wv->key];
#ifdef NS_IMPL_COCOA #ifdef NS_IMPL_COCOA
/* macOS just ignores modifier strings longer than one character */ /* macOS mangles modifier strings longer than one character. */
if (keyEquivModMask == 0) if (keyEquivModMask == 0)
{
title = [title stringByAppendingFormat: @" (%@)", keyEq]; title = [title stringByAppendingFormat: @" (%@)", keyEq];
item = [self addItemWithTitle: (NSString *)title
action: @selector (menuDown:)
keyEquivalent: @""];
}
else
{
#endif #endif
item = [self addItemWithTitle: (NSString *)title item = [self addItemWithTitle: (NSString *)title
action: @selector (menuDown:) action: @selector (menuDown:)
keyEquivalent: keyEq]; keyEquivalent: keyEq];
#ifdef NS_IMPL_COCOA
}
#endif
[item setKeyEquivalentModifierMask: keyEquivModMask]; [item setKeyEquivalentModifierMask: keyEquivModMask];
[item setEnabled: wv->enabled]; [item setEnabled: wv->enabled];