masscollaborationlabs/emacs
2
0
Fork 0
mirror of https://github.com/masscollaborationlabs/emacs.git synced 2025-07-13 15:39:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add new Tramp test

Browse source 
* test/lisp/net/tramp-tests.el (tramp-test46-read-password):
Use `copy-tree' but `copy-sequence'.
(tramp-test46-read-otp-password): New test.
This commit is contained in:
Michael Albinus 2023-09-25 12:48:32 +02:00
parent ca5b48fd76
commit 4776d90c31
1 changed files with 60 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

61
test/lisp/net/tramp-tests.el
View file

@ -7843,7 +7843,7 @@ process sentinels. They shall not disturb each other."
(shell-command-to-string "read -s -p Password: pass")))) (shell-command-to-string "read -s -p Password: pass"))))
(let ((pass "secret") (let ((pass "secret")
(mock-entry (copy-sequence (assoc "mock" tramp-methods))) (mock-entry (copy-tree (assoc "mock" tramp-methods)))
mocked-input tramp-methods) mocked-input tramp-methods)
;; We must mock `read-string', in order to avoid interactive ;; We must mock `read-string', in order to avoid interactive
;; arguments. ;; arguments.
@ -7890,6 +7890,65 @@ process sentinels. They shall not disturb each other."
(let ((auth-sources `(,netrc-file))) (let ((auth-sources `(,netrc-file)))
(should (file-exists-p ert-remote-temporary-file-directory))))))))) (should (file-exists-p ert-remote-temporary-file-directory)))))))))
(ert-deftest tramp-test46-read-otp-password ()
"Check Tramp one-time password handling."
:tags '(:expensive-test)
(skip-unless (tramp--test-mock-p))
;; Not all read commands understand argument "-s" or "-p".
(skip-unless
(string-empty-p
(let ((shell-file-name "sh"))
(shell-command-to-string "read -s -p Password: pass"))))
(let ((pass "secret")
(mock-entry (copy-tree (assoc "mock" tramp-methods)))
mocked-input tramp-methods)
;; We must mock `read-string', in order to avoid interactive
;; arguments.
(cl-letf* (((symbol-function #'read-string)
(lambda (&rest _args) (pop mocked-input))))
(setcdr
(assq 'tramp-login-args mock-entry)
`((("-c")
(,(tramp-shell-quote-argument
(concat
"read -s -p 'Verification code: ' pass; echo; "
"(test \"pass$pass\" != \"pass" pass "\" && "
"echo \"Login incorrect\" || sh -i)"))))))
(setq tramp-methods `(,mock-entry))
;; Reading password from stdin works.
(tramp-cleanup-connection tramp-test-vec 'keep-debug)
;; We don't want to invalidate the password.
(setq mocked-input `(,(copy-sequence pass)))
(should (file-exists-p ert-remote-temporary-file-directory))
;; Don't entering a password returns in error.
(tramp-cleanup-connection tramp-test-vec 'keep-debug)
(setq mocked-input nil)
(should-error (file-exists-p ert-remote-temporary-file-directory))
;; A wrong password doesn't work either.
(tramp-cleanup-connection tramp-test-vec 'keep-debug)
(setq mocked-input `(,(concat pass pass)))
(should-error (file-exists-p ert-remote-temporary-file-directory))
;; The password shouldn't be read from auth-source.
;; Macro `ert-with-temp-file' was introduced in Emacs 29.1.
(with-no-warnings (when (symbol-plist 'ert-with-temp-file)
(tramp-cleanup-connection tramp-test-vec 'keep-debug)
(setq mocked-input nil)
(auth-source-forget-all-cached)
(ert-with-temp-file netrc-file
:prefix "tramp-test" :suffix ""
:text (format
"machine %s port mock password %s"
(file-remote-p ert-remote-temporary-file-directory 'host)
pass)
(let ((auth-sources `(,netrc-file)))
(should-error
(file-exists-p ert-remote-temporary-file-directory)))))))))
;; This test is inspired by Bug#29163. ;; This test is inspired by Bug#29163.
(ert-deftest tramp-test47-auto-load () (ert-deftest tramp-test47-auto-load ()
"Check that Tramp autoloads properly." "Check that Tramp autoloads properly."