Fix test error

Fix test error on 5.8.8 (reported by Wei Wang)
Also add to TODO file
This commit is contained in:
Duncan Ferguson 2010-09-09 12:17:43 +01:00
parent 98b93d91f4
commit e2cc9a0863
5 changed files with 13 additions and 6 deletions

View file

@ -1,4 +1,5 @@
????-??-?? Duncan Ferguson <duncan_ferguson@user.sf.net> - v4.01_01
????-??-?? Duncan Ferguson <duncan_ferguson@user.sf.net> - v4.00_06
* Fix test error on 5.8.8 (reported by Wei Wang)
2010-06-20 Duncan Ferguson <duncan_ferguson@user.sf.net> - v4.00_05

2
THANKS
View file

@ -34,3 +34,5 @@ Kristian Lyngstol
Mike Loseke
Ian Marsh
Roland Rosenfeld
Wei Wang
Markus Manzke

4
TODO
View file

@ -19,6 +19,10 @@ Getopts usage
Set up similar to Nagios::Plugin where Getopts::Long is subclassed
Sort out docs too
Add in '-l' to list all available tags
Add in '-l <tag>' to list all hosts for the given tag
Idea from Markus Manzke
Change way commands generated
=============================

View file

@ -3,7 +3,7 @@ package App::ClusterSSH;
use 5.008.004;
use warnings;
use strict;
use version; our $VERSION = version->new('4.01_01');
use version; our $VERSION = version->new('4.00_06');
use Carp;

View file

@ -4,7 +4,7 @@ use strict;
use warnings;
use version;
our $VERSION = version->new('0.02');
our $VERSION = version->new('0.03');
use Carp;
@ -31,9 +31,9 @@ sub new {
if ( !%ssh_hostname_for || !$ssh_configs_read{ $self->{ssh_config} } ) {
$ssh_configs_read{ $self->{ssh_config} } = 1;
if ( open( my $ssh_config_fh, '<', $self->{ssh_config} ) ) {
while ( my $_ = <$ssh_config_fh> ) {
chomp $_;
next unless (m/^\s*host\s+(.*)/i);
while ( my $line = <$ssh_config_fh> ) {
chomp $line;
next unless ($line =~ m/^\s*host\s+(.*)/i);
# account for multiple declarations of hosts
$ssh_hostname_for{$_} = 1 foreach ( split( /\s+/, $1 ) );