diff --git a/clusterssh/ChangeLog b/clusterssh/ChangeLog index 2fd2b16..9deca23 100644 --- a/clusterssh/ChangeLog +++ b/clusterssh/ChangeLog @@ -7,6 +7,7 @@ * Rearrange pod documentation to remove extraenous comment (Tony Mancill) * Cope better with IPv6 addresses * Fix bug with passing arguments from command line to comms method binary +* Rework defaultport code 2009-03-26 Duncan Ferguson - v3.25-1 diff --git a/clusterssh/src/cssh.pl b/clusterssh/src/cssh.pl index 317085c..12ec907 100755 --- a/clusterssh/src/cssh.pl +++ b/clusterssh/src/cssh.pl @@ -828,7 +828,6 @@ sub send_resizemove($$$$$) { sub setup_helper_script() { logmsg( 2, "Setting up helper script" ); - my $defaultport = ( defined $options{p} ) ? $options{p} : ""; $helper_script = <<" HERE"; my \$pipe=shift; my \$svr=shift; @@ -852,16 +851,14 @@ sub setup_helper_script() { \$command .= \$user; } } - if($config{comms} eq "telnet") { - \$port = \$port ? "\$port" : "$defaultport"; + if("$config{comms}" eq "telnet") { \$command .= "\$svr \$port"; } else { - if ((\$port) || ("$defaultport" ne "")) { - \$port = \$port ? "-p \$port" : "-p $defaultport"; - \$command .= "\$port \$svr"; - } else { + if (\$port) { + \$command .= "-p \$port \$svr"; + } else { \$command .= "\$svr"; - } + } } \$command .= " || sleep 5"; # warn("Running:\$command\\n"); # for debug purposes @@ -932,7 +929,7 @@ sub split_hostname { } } - $port ||= q{}; + $port ||= defined $options{p} ? $options{p} : q{}; $username ||= q{}; logmsg( 3, "username=$username, server=$server, port=$port" );