MasscollabsGamingStudios/kdenlive
1
0
Fork 0
mirror of https://invent.kde.org/multimedia/kdenlive.git synced 2025-07-17 03:20:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't create unnecessary pointers on render error

Browse source
This commit is contained in:
Jean-Baptiste Mardelle 2025-06-11 13:11:10 +02:00
parent b1857c1d0d
commit 059da23ee1
No known key found for this signature in database
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
renderer/kdenlive_render.cpp
View file

@ -176,7 +176,7 @@ int main(int argc, char **argv)
if (args.count() != 3) {
qCritical() << "Error: wrong number of arguments specified\n";
int pid = parser.value(pidOption).toInt();
auto *rJob = new RenderJob(QStringLiteral("Error: wrong number of arguments specified\n"), pid, &app);
RenderJob r(QStringLiteral("Error: wrong number of arguments specified\n"), pid, &app);
parser.showHelp(1);
// the command above will quit the app with return 1;
}
@ -194,13 +194,13 @@ int main(int argc, char **argv)
if (!f.open(QIODevice::ReadOnly)) {
qCWarning(KDENLIVE_RENDERER_LOG) << "Failed to open file" << f.fileName() << "for reading";
int pid = parser.value(pidOption).toInt();
auto *rJob = new RenderJob(QStringLiteral("Failed to open file %1").arg(f.fileName()), pid, &app);
RenderJob r(QStringLiteral("Failed to open file %1").arg(f.fileName()), pid, &app);
return 1;
}
if (!doc.setContent(&f)) {
qCWarning(KDENLIVE_RENDERER_LOG) << "Failed to parse file" << f.fileName() << "to QDomDocument";
int pid = parser.value(pidOption).toInt();
auto *rJob = new RenderJob(QStringLiteral("Failed to parse file %1").arg(f.fileName()), pid, &app);
RenderJob r(QStringLiteral("Failed to parse file %1").arg(f.fileName()), pid, &app);
f.close();
return 1;
}