MasscollabsGamingStudios/gnome-chess
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix error in testing for check - copy board before checking to avoid iterating across list that is changing (sf.net bug #106348)

Browse source 
svn path=/trunk/; revision=5874
This commit is contained in:
Robert Ancell 2007-01-21 11:05:43 +00:00
parent b83778b396
commit 13a8f51622
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ChangeLog
View file

@ -1,3 +1,7 @@
2007-01-21 Robert Ancell <bob27@users.sourceforge.net>
* Fix error in testing for check - copy board before checking to avoid
iterating across list that is changing (sf.net bug #106348)
2007-01-20 Robert Ancell <bob27@users.sourceforge.net>
* Fix exception when a save error occurs (Bug #389960)
* Tidied up error dialogs and PGN error messages

13
src/lib/chess/board.py
View file

@ -305,9 +305,10 @@ class ChessBoardState:
# Ignore friendly pieces
if enemyPiece.getColour() == colour:
continue
# See if this piece can take the king
(result, moves) = self.movePiece(enemyPiece.getColour(), enemyCoord, kingCoord,
board = ChessBoardState(self)
(result, moves) = board.movePiece(enemyPiece.getColour(), enemyCoord, kingCoord,
testCheck = False, testCheckMate = False,
applyMove = False)
if result is not MOVE_RESULT_ILLEGAL:
@ -331,10 +332,12 @@ class ChessBoardState:
# See if this piece can be moved anywhere
for rank in 'abcdefgh':
for file in '12345678':
(result, moves) = self.movePiece(colour, coord, rank + file,
board = ChessBoardState(self)
(result, moves) = board.movePiece(colour, coord, rank + file,
testCheckMate = False, applyMove = False)
if result is not MOVE_RESULT_ILLEGAL:
return False
return True
def movePiece(self, colour, start, end, promotionType = QUEEN, testCheck = True, testCheckMate = True, allowSuicide = False, applyMove = True):
@ -407,7 +410,7 @@ class ChessBoardState:
enPassantSquare = None
# Check move is valid:
# King can move one square or castle
if piece.getType() is KING:
# Castling:
@ -454,7 +457,7 @@ class ChessBoardState:
else:
if len(rankRange) > 2 or len(fileRange) > 2:
return (MOVE_RESULT_ILLEGAL, None)
# Can no longer castle if moved the king
playerState.canShortCastle = False
playerState.canLongCastle = False